Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5th version)

From: Pavel Machek <pavel@ucw.cz>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	alan@lxorguk.ukuu.org.uk, mgarski@post.pl,
	linux-input@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>,
	Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5th version)
Date: Sun, 21 Mar 2010 22:09:38 +0100	[thread overview]
Message-ID: <20100321210938.GB2057@elf.ucw.cz> (raw)
In-Reply-To: <20100310133004.GM5127@const.bordeaux.inria.fr>

Hi!

> Route keyboard LEDs through the generic LEDs layer.
> 
> This permits to reassign keyboard LEDs to something else than keyboard "leds"
> state, by adding keyboard led and modifier triggers connected to a series
> of global input LEDs, themselves connected to global input triggers, which
> per-input device LEDs use by default.  Userland can thus easily change the LED
> behavior of (a priori) all input devices, or of particular input devices.
> 
> This also permits to fix #7063 from userland by using a modifier to implement
> proper CapsLock behavior and have the keyboard caps lock led show that modifier
> state.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

I like it.

Tested-by: Pavel Machek <pavel@ucw.cz>

Now, minor comments:

sometimes it uses "numl" (led name), sometimes it uses "numlock"
trigger name.

root@amd:/sys/class/leds/input5::numl# echo heartbeat > trigger

did not do the trick on my thinkpad. It still acts as numlock led. Is
it driven by hw? input5::capsl works as expected.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html