Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Luotao Fu <l.fu@pengutronix.de>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"uclinux-dist-devel@blackfin.uclinux.org"
	<uclinux-dist-devel@blackfin.uclinux.org>,
	Chris Verges <chrisv@cyberswitching.com>
Subject: Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver
Date: Thu, 22 Jul 2010 23:44:02 -0700	[thread overview]
Message-ID: <20100723064401.GB20532@core.coreip.homeip.net> (raw)
In-Reply-To: <AANLkTikI3ps5u30x235VOtQgAN0KdMGRNotKjLYSTpCc@mail.gmail.com>

Hi Mike,

On Wed, Jul 21, 2010 at 09:50:12AM -0400, Mike Frysinger wrote:
> On Thu, Jul 1, 2010 at 03:53, Dmitry Torokhov wrote:
> > Input: adxl34 - make enable/disable separate from suspend/resume
> 
> this should be "adxl34x" i think to match the style we've used in the
> past and the actual driver name
> 
> > -void adxl34x_enable(struct adxl34x *ac)
> > +void adxl34x_resume(struct adxl34x *ac)
> >  {
> >        mutex_lock(&ac->mutex);
> > -       __adxl34x_enable(ac);
> > +
> > +       if (ac->suspended && !ac->disabled && ac->opened)
> > +               __adxl34x_enable(ac);
> > +
> > +       ac->suspended= false;
> 
> ERROR: spaces required around that '=' (ctx:VxW)
> #191: FILE: drivers/input/misc/adxl34x.c:435:
> +       ac->suspended= false;
> 
> >  }
> >
> > -EXPORT_SYMBOL_GPL(adxl34x_enable);
> > +EXPORT_SYMBOL_GPL(adxl34x_resume);
> 
> while you're here, might want to delete the newline after the brace to
> avoid the checkpatch warning:

Thanks for noticing these issues however as the original change is quite
buried I opted to roll these changes into another patch.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html