Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver

From: Mike Frysinger <vapier.adi@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Luotao Fu <l.fu@pengutronix.de>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"uclinux-dist-devel@blackfin.uclinux.org"
	<uclinux-dist-devel@blackfin.uclinux.org>,
	Chris Verges <chrisv@cyberswitching.com>
Subject: Re: [Uclinux-dist-devel] [PATCH v3] input/misc: new ADXL345/346 driver
Date: Wed, 21 Jul 2010 09:50:12 -0400	[thread overview]
Message-ID: <AANLkTikI3ps5u30x235VOtQgAN0KdMGRNotKjLYSTpCc@mail.gmail.com> (raw)
In-Reply-To: <20100701075316.GA14696@core.coreip.homeip.net>

On Thu, Jul 1, 2010 at 03:53, Dmitry Torokhov wrote:
> Input: adxl34 - make enable/disable separate from suspend/resume

this should be "adxl34x" i think to match the style we've used in the
past and the actual driver name

> -void adxl34x_enable(struct adxl34x *ac)
> +void adxl34x_resume(struct adxl34x *ac)
>  {
>        mutex_lock(&ac->mutex);
> -       __adxl34x_enable(ac);
> +
> +       if (ac->suspended && !ac->disabled && ac->opened)
> +               __adxl34x_enable(ac);
> +
> +       ac->suspended= false;

ERROR: spaces required around that '=' (ctx:VxW)
#191: FILE: drivers/input/misc/adxl34x.c:435:
+       ac->suspended= false;

>  }
>
> -EXPORT_SYMBOL_GPL(adxl34x_enable);
> +EXPORT_SYMBOL_GPL(adxl34x_resume);

while you're here, might want to delete the newline after the brace to
avoid the checkpatch warning:
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html