From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
sakari.ailus@maxwell.research.nokia.com,
broonie@opensource.wolfsonmicro.com, lennart@poettering.net
Subject: Re: [RFC/PATCH v6 02/12] media: Media device
Date: Thu, 25 Nov 2010 15:42:13 +0100 [thread overview]
Message-ID: <201011251542.14024.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <4CEE2D4E.6070906@ladisch.de>
Hi Clemens,
Thanks for the review.
On Thursday 25 November 2010 10:33:02 Clemens Ladisch wrote:
> Laurent Pinchart wrote:
> > +struct media_device {
> > ...
> > + u8 model[32];
> > + u8 serial[40];
> > + u8 bus_info[32];
>
> All drivers and userspace applications have to treat this as char[], so
> why u8[]?
Good question. I've copied the V4L2 practice of using u8 (or __u8) for fixed-
length strings in structures. I can't think of any reason for that.
I will replace u8 with char unless someone comes up with a good reason to keep
u8.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2010-11-25 14:42 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 2:28 [RFC/PATCH v6 00/12] Media controller (core and V4L2) Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 01/12] media: Media device node support Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 02/12] media: Media device Laurent Pinchart
2010-11-25 9:33 ` Clemens Ladisch
2010-11-25 14:42 ` Laurent Pinchart [this message]
2010-11-25 2:28 ` [RFC/PATCH v6 03/12] media: Entities, pads and links Laurent Pinchart
2010-11-25 9:38 ` [RFC/PATCH v6 03/12] [alsa-devel] " Clemens Ladisch
2010-11-25 9:38 ` [RFC/PATCH v6 03/12] " Clemens Ladisch
2010-11-25 13:41 ` [RFC/PATCH v6 03/12] [alsa-devel] " Mark Brown
2010-11-25 13:41 ` [RFC/PATCH v6 03/12] " Mark Brown
2010-11-25 15:29 ` [RFC/PATCH v6 03/12] [alsa-devel] " Laurent Pinchart
2010-11-25 15:35 ` Mark Brown
2010-11-25 15:35 ` [RFC/PATCH v6 03/12] " Mark Brown
2010-11-25 15:21 ` [RFC/PATCH v6 03/12] [alsa-devel] " Laurent Pinchart
2010-11-25 15:28 ` Mark Brown
2010-11-25 15:28 ` [RFC/PATCH v6 03/12] " Mark Brown
2010-11-26 9:10 ` [RFC/PATCH v6 03/12] [alsa-devel] " Clemens Ladisch
2010-11-26 9:10 ` [RFC/PATCH v6 03/12] " Clemens Ladisch
2010-12-13 16:10 ` [alsa-devel] " Clemens Ladisch
2010-12-13 16:10 ` Clemens Ladisch
2010-12-14 12:00 ` [alsa-devel] " Laurent Pinchart
2010-12-14 12:40 ` Hans Verkuil
2010-12-14 12:53 ` Laurent Pinchart
2010-12-14 12:53 ` Laurent Pinchart
2010-12-14 13:49 ` [alsa-devel] " Clemens Ladisch
2010-12-14 13:49 ` Clemens Ladisch
2010-12-14 23:50 ` [alsa-devel] " Laurent Pinchart
2010-12-14 23:50 ` Laurent Pinchart
2010-12-21 16:49 ` [alsa-devel] " Hans Verkuil
2010-12-14 13:31 ` Clemens Ladisch
2010-12-14 13:31 ` Clemens Ladisch
2010-12-14 13:54 ` [alsa-devel] " Takashi Iwai
2010-12-14 13:54 ` Takashi Iwai
2010-12-14 14:25 ` [alsa-devel] " Laurent Pinchart
2010-12-14 14:25 ` Laurent Pinchart
2010-12-14 15:30 ` [alsa-devel] " Clemens Ladisch
2010-12-14 15:30 ` Clemens Ladisch
2010-12-14 23:30 ` Raymond Yau
2010-12-14 14:51 ` [alsa-devel] " Hans Verkuil
2010-12-14 14:57 ` Laurent Pinchart
2010-12-14 14:57 ` Laurent Pinchart
2010-12-14 14:49 ` [alsa-devel] " Sakari Ailus
2010-11-25 13:36 ` Mark Brown
2010-11-25 15:40 ` Laurent Pinchart
2010-11-25 15:49 ` Mark Brown
2010-11-26 14:13 ` Laurent Pinchart
2010-11-26 14:14 ` Mark Brown
2010-11-28 12:34 ` Laurent Pinchart
2010-11-28 15:57 ` Hans Verkuil
2010-11-25 2:28 ` [RFC/PATCH v6 04/12] media: Entity graph traversal Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 05/12] media: Reference count and power handling Laurent Pinchart
2010-11-25 13:49 ` Mark Brown
2010-11-25 15:43 ` Laurent Pinchart
2010-11-25 17:49 ` Sakari Ailus
2010-11-25 21:47 ` Mark Brown
2010-11-28 12:33 ` Laurent Pinchart
2010-11-28 18:25 ` Mark Brown
2010-11-25 2:28 ` [RFC/PATCH v6 06/12] media: Media device information query Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 07/12] media: Entities, pads and links enumeration Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 08/12] media: Links setup Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 09/12] media: Entity locking and pipeline management Laurent Pinchart
2010-11-25 13:53 ` Mark Brown
2010-11-25 15:47 ` Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 10/12] v4l: Add a media_device pointer to the v4l2_device structure Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity Laurent Pinchart
2010-11-25 11:38 ` Hans Verkuil
2010-11-25 14:37 ` Laurent Pinchart
2010-11-25 2:28 ` [RFC/PATCH v6 12/12] v4l: Make v4l2_subdev " Laurent Pinchart
2010-11-25 14:28 ` [RFC/PATCH v6 00/12] Media controller (core and V4L2) Mark Brown
2010-11-26 14:07 ` Laurent Pinchart
[not found] ` <201012031119.36771.laurent.pinchart@ideasonboard.com>
[not found] ` <201012031306.18520.hverkuil@xs4all.nl>
2010-12-03 13:50 ` [RFC/PATCH v6 03/12] media: Entities, pads and links Laurent Pinchart
2010-12-03 14:54 ` Mark Brown
2010-12-07 17:13 ` Hans Verkuil
2010-12-07 17:55 ` Mark Brown
2010-12-07 18:11 ` Hans Verkuil
2010-12-07 19:03 ` Mark Brown
2010-12-09 12:53 ` Laurent Pinchart
2010-12-10 16:35 ` Sakari Ailus
2010-11-25 17:20 [RFC/PATCH v6 02/12] media: Media device Andy Walls
2010-11-25 17:20 ` Andy Walls
2010-11-25 17:30 ` Laurent Pinchart
2010-11-25 18:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011251542.14024.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clemens@ladisch.de \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.