Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, lennart@poettering.net
Subject: Re: [RFC/PATCH v6 03/12] media: Entities, pads and links
Date: Fri, 10 Dec 2010 18:35:00 +0200	[thread overview]
Message-ID: <4D0256B4.7010703@maxwell.research.nokia.com> (raw)
In-Reply-To: <20101207190328.GA789@rakim.wolfsonmicro.main>

Hi Mark and others!

Mark Brown wrote:
> On Tue, Dec 07, 2010 at 07:11:39PM +0100, Hans Verkuil wrote:
> 
>> Ah, now I understand what you mean. Would 'activated' be better than 'active'?
> 
> Better, yes, though it still sounds a bit like something should be
> actively (IYSWIM) happening.   In the absence of better ideas I could go
> with this.

Activated, to me, sounds like that it has happened as a consequence of
something, and primarily not as a result of a user request.

This flag is also set using MEDIA_IOC_SETUP_LINK ioctl and setting the
flags field would be something like this:

media_link_desc.flags |= MEDIA_LINK_ACTIVATED;

I'd prefer ACTIVE over ACTIVATED, since this may also be set (and is
mostly set) by the user.

But reading this discussion, ACTIVE has not received unanimous approval
either... :\

>> Or perhaps just say: the link 'is on' or the link 'is switched on'?
> 
>> So: ...LINK_SWITCHED_ON (sorry, forgot what the prefix is).
> 
>> Actually, I think 'switched on' is a pretty good description of what is going on
>> in the hardware.
> 
> I prefer activated, this makes me think of power.  Bear in mind that for
> most audio the power is a big portion of the control - either the audio
> is analogue or it looks like it.

What would you think about "ENABLED"? It's simple, quite generic and
thus doesn't explicitly suggest what is the exact effect it has on the
level of the underlying device.

I don't completely like it myself since it would be best to have an
adjective (like "active") but there's none for the word enable, so it
bears the same issues than "activated".

Cheers,

-- 
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com