From: Samuel Ortiz <sameo@linux.intel.com> To: Sundar Iyer <sundar.iyer@stericsson.com> Cc: linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, ben-linux@fluff.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/20] mfd/tc3589x: undo gpio module reset during chip init Date: Thu, 9 Dec 2010 16:50:22 +0100 [thread overview] Message-ID: <20101209155021.GW8884@sortiz-mobl> (raw) In-Reply-To: <1291388753-14662-13-git-send-email-sundar.iyer@stericsson.com> Hi Sundar, On Fri, Dec 03, 2010 at 08:35:45PM +0530, Sundar Iyer wrote: > Skip putting the GPIO module into a reset during the chip init. This makes > sure to preserve any existing GPIO configurations done by pre-kernel boot code. > Acked-by: Samuel Ortiz <sameo@linux.intel.com> Cheers, Samuel. > Signed-off-by: Sundar Iyer <sundar.iyer@stericsson.com> > --- > drivers/mfd/tc3589x.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c > index e173f33..fd206fd 100644 > --- a/drivers/mfd/tc3589x.c > +++ b/drivers/mfd/tc3589x.c > @@ -247,12 +247,15 @@ static int tc3589x_chip_init(struct tc3589x *tc3589x) > > dev_info(tc3589x->dev, "manufacturer: %#x, version: %#x\n", manf, ver); > > - /* Put everything except the IRQ module into reset */ > + /* > + * Put everything except the IRQ module into reset; > + * also spare the GPIO module for any pin initialization > + * done during pre-kernel boot > + */ > ret = tc3589x_reg_write(tc3589x, TC3589x_RSTCTRL, > TC3589x_RSTCTRL_TIMRST > | TC3589x_RSTCTRL_ROTRST > - | TC3589x_RSTCTRL_KBDRST > - | TC3589x_RSTCTRL_GPIRST); > + | TC3589x_RSTCTRL_KBDRST); > if (ret < 0) > return ret; > > -- > 1.7.2.dirty > -- Intel Open Source Technology Centre http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: sameo@linux.intel.com (Samuel Ortiz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/20] mfd/tc3589x: undo gpio module reset during chip init Date: Thu, 9 Dec 2010 16:50:22 +0100 [thread overview] Message-ID: <20101209155021.GW8884@sortiz-mobl> (raw) In-Reply-To: <1291388753-14662-13-git-send-email-sundar.iyer@stericsson.com> Hi Sundar, On Fri, Dec 03, 2010 at 08:35:45PM +0530, Sundar Iyer wrote: > Skip putting the GPIO module into a reset during the chip init. This makes > sure to preserve any existing GPIO configurations done by pre-kernel boot code. > Acked-by: Samuel Ortiz <sameo@linux.intel.com> Cheers, Samuel. > Signed-off-by: Sundar Iyer <sundar.iyer@stericsson.com> > --- > drivers/mfd/tc3589x.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c > index e173f33..fd206fd 100644 > --- a/drivers/mfd/tc3589x.c > +++ b/drivers/mfd/tc3589x.c > @@ -247,12 +247,15 @@ static int tc3589x_chip_init(struct tc3589x *tc3589x) > > dev_info(tc3589x->dev, "manufacturer: %#x, version: %#x\n", manf, ver); > > - /* Put everything except the IRQ module into reset */ > + /* > + * Put everything except the IRQ module into reset; > + * also spare the GPIO module for any pin initialization > + * done during pre-kernel boot > + */ > ret = tc3589x_reg_write(tc3589x, TC3589x_RSTCTRL, > TC3589x_RSTCTRL_TIMRST > | TC3589x_RSTCTRL_ROTRST > - | TC3589x_RSTCTRL_KBDRST > - | TC3589x_RSTCTRL_GPIRST); > + | TC3589x_RSTCTRL_KBDRST); > if (ret < 0) > return ret; > > -- > 1.7.2.dirty > -- Intel Open Source Technology Centre http://oss.intel.com/
next prev parent reply other threads:[~2010-12-09 15:50 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-03 15:05 [PATCH 00/20] ux500: platform data, TC3589x keypad driver Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 01/20] mfd/ab8500: remove spi support Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 14:29 ` Samuel Ortiz 2010-12-09 14:29 ` Samuel Ortiz 2010-12-09 14:35 ` Sundar R IYER 2010-12-09 14:35 ` Sundar R IYER 2010-12-09 15:36 ` Samuel Ortiz 2010-12-09 15:36 ` Samuel Ortiz 2010-12-19 20:48 ` Linus Walleij 2010-12-19 20:48 ` Linus Walleij 2010-12-24 10:53 ` Samuel Ortiz 2010-12-24 10:53 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 02/20] mach-ux500: deprecate spi support for ab8500 Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 03/20] mach-ux500: move keymaps to new file Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-19 20:53 ` Linus Walleij 2010-12-19 20:53 ` Linus Walleij 2010-12-03 15:05 ` [PATCH 04/20] nomadik-gpio: allow sleep mode dir/pull to differ from normal mode Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 05/20] mach-ux500: add STMPE1601 platform data Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-19 20:54 ` Linus Walleij 2010-12-19 20:54 ` Linus Walleij 2010-12-03 15:05 ` [PATCH 06/20] mfd/tc35892: rename tc35892 header to tc3589x Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:41 ` Samuel Ortiz 2010-12-09 15:41 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 07/20] mfd/tc35892: rename tc35892 core driver " Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:42 ` Samuel Ortiz 2010-12-09 15:42 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 08/20] mfd/tc3589x: rename tc35892 structs/registers to tc359x Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:45 ` Samuel Ortiz 2010-12-09 15:45 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 09/20] mfd/tc3589x: add block identifier for multiple child devices Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:48 ` Samuel Ortiz 2010-12-09 15:48 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 10/20] input/tc3589x: add tc3589x keypad support Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-05 18:38 ` Trilok Soni 2010-12-05 18:38 ` Trilok Soni 2010-12-03 15:05 ` [PATCH 11/20] mfd/tc3589x: fix random interrupt misses Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:49 ` Samuel Ortiz 2010-12-09 15:49 ` Samuel Ortiz 2010-12-10 4:31 ` Sundar R IYER 2010-12-03 15:05 ` [PATCH 12/20] mfd/tc3589x: undo gpio module reset during chip init Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 15:50 ` Samuel Ortiz [this message] 2010-12-09 15:50 ` Samuel Ortiz 2010-12-03 15:05 ` [PATCH 13/20] mfd/tc3589x: add suspend/resume support Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-09 17:03 ` Samuel Ortiz 2010-12-09 17:03 ` Samuel Ortiz 2010-12-10 4:32 ` Sundar R IYER 2010-12-10 4:32 ` Sundar R IYER 2010-12-10 4:32 ` Sundar R IYER 2010-12-03 15:05 ` [PATCH 14/20] plat-nomadik/gpio: add expander gpio pins enumeration Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 15/20] mach-ux500: add touchscreen interfaces platform data Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 16/20] i2c/nomadik: add adapter name for updated sanity checkings Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 17/20] mach-ux500: add TC35893 keypad platform data Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 18/20] mach-ux500: explicit enable MTU TCR in the kernel Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 19/20] mach-ux500: clean up checkpatch spits Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` [PATCH 20/20] i2c/nomadik: some checkpatch warnings Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-03 15:05 ` Sundar Iyer 2010-12-19 21:03 ` [PATCH 00/20] ux500: platform data, TC3589x keypad driver Linus Walleij 2010-12-19 21:03 ` Linus Walleij 2010-12-19 21:03 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101209155021.GW8884@sortiz-mobl \ --to=sameo@linux.intel.com \ --cc=ben-linux@fluff.org \ --cc=dmitry.torokhov@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sundar.iyer@stericsson.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.