From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org,
sakari.ailus@maxwell.research.nokia.com,
linux-media@vger.kernel.org
Subject: Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure
Date: Fri, 10 Dec 2010 02:12:00 +0100 [thread overview]
Message-ID: <201012100212.00503.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20101206193213.GN8345@atomide.com>
Hi Tony,
On Monday 06 December 2010 20:32:13 Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [101125 03:13]:
> > Hi,
> >
> > On Thu, Nov 25, 2010 at 12:17:59PM +0100, Laurent Pinchart wrote:
> > >>pass platform_data as an argument to this call ? Then remove the static
> > >>inline and export this one ?
> > >
> > >Yes indeed, why ? :-)
> > >
> > >I guess things like that are difficult to spot when you've had your nose
> > >on the code for too long. Thanks for the review, I'll fix this.
> >
> > no problem :-)
>
> Can you please also grep to make sure there are no other EXPORT_SYMBOL
> being added to arch/arm/*omap*/ code in these patches?
That's the only one.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2010-12-10 1:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 2:54 [RFC/PATCH v3 0/7] OMAP3 ISP driver Laurent Pinchart
2010-11-25 2:54 ` [RFC/PATCH v3 1/7] v4l: subdev: Generic ioctl support Laurent Pinchart
2010-11-25 2:54 ` [RFC/PATCH v3 2/7] v4l: Remove module_name argument to the v4l2_i2c_new_subdev* functions Laurent Pinchart
2010-11-25 2:54 ` [RFC/PATCH v3 3/7] v4l: Add subdev sensor g_skip_frames operation Laurent Pinchart
2010-11-25 2:54 ` [RFC/PATCH v3 4/7] v4l: Include linux/videodev2.h in media/v4l2-ctrls.h Laurent Pinchart
2010-11-25 2:54 ` [RFC/PATCH v3 5/7] ARM: OMAP3: Update Camera ISP definitions for OMAP3630 Laurent Pinchart
2010-12-06 19:30 ` Tony Lindgren
2010-11-25 2:54 ` [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure Laurent Pinchart
2010-11-25 7:02 ` Felipe Balbi
2010-11-25 11:17 ` Laurent Pinchart
2010-11-25 11:23 ` Felipe Balbi
2010-12-06 19:32 ` Tony Lindgren
2010-12-10 1:12 ` Laurent Pinchart [this message]
2010-11-25 7:03 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012100212.00503.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=balbi@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sakari.ailus@maxwell.research.nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.