From: Paul Mundt <lethal@linux-sh.org>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.sf.net,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 3/3] fbcon: fix situation where fbcon gets deinitialised and can't reinit.
Date: Fri, 24 Dec 2010 12:30:15 +0900 [thread overview]
Message-ID: <20101224033015.GJ28151@linux-sh.org> (raw)
In-Reply-To: <1292895677-4242-4-git-send-email-airlied@gmail.com>
On Tue, Dec 21, 2010 at 11:41:17AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> Situation as follow:
> 2 GPUs + vesafb + kms.
>
> GPU 1 is primary, vesafb binds to it as fb0
> radeon loads
> GPU 0 loads as fb1
> GPU 1 loads, vesafb gets kicked off which causes fb0 to unbind
> console, which causes the dummy console to rebind.
>
> this means fbcon_deinit gets called, which calls fbcon_exit
> since the console isn't bound anymore and we set fbcon_has_exited.
>
> GPU 1 creates a new fb0 which is primary and we want to be console.
> fbcon_fb_registered gets called sets the primary up and calls set_con2fb_map,
> however as fbcon_has_exited is set nothing further ever happens.
>
> This patch bypasses the fbcon_has_exited and checks if the console is unbound,
> if its unbound it calls the fbcon_takeover which calls the vt layer to
> call the fbcon_startup method and everthing works.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
This one looks fine, too. This does presumably depend on the change in
behaviour introduced by your 2/3 patch though. I'll hold off on applying
this until that one gets acked, then we can do this either for the next
-rc or for .38.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.sf.net,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 3/3] fbcon: fix situation where fbcon gets deinitialised and can't reinit.
Date: Fri, 24 Dec 2010 03:30:15 +0000 [thread overview]
Message-ID: <20101224033015.GJ28151@linux-sh.org> (raw)
In-Reply-To: <1292895677-4242-4-git-send-email-airlied@gmail.com>
On Tue, Dec 21, 2010 at 11:41:17AM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> Situation as follow:
> 2 GPUs + vesafb + kms.
>
> GPU 1 is primary, vesafb binds to it as fb0
> radeon loads
> GPU 0 loads as fb1
> GPU 1 loads, vesafb gets kicked off which causes fb0 to unbind
> console, which causes the dummy console to rebind.
>
> this means fbcon_deinit gets called, which calls fbcon_exit
> since the console isn't bound anymore and we set fbcon_has_exited.
>
> GPU 1 creates a new fb0 which is primary and we want to be console.
> fbcon_fb_registered gets called sets the primary up and calls set_con2fb_map,
> however as fbcon_has_exited is set nothing further ever happens.
>
> This patch bypasses the fbcon_has_exited and checks if the console is unbound,
> if its unbound it calls the fbcon_takeover which calls the vt layer to
> call the fbcon_startup method and everthing works.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
This one looks fine, too. This does presumably depend on the change in
behaviour introduced by your 2/3 patch though. I'll hold off on applying
this until that one gets acked, then we can do this either for the next
-rc or for .38.
next prev parent reply other threads:[~2010-12-24 3:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 1:41 vt/fbcon binding and handover fixes Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` [PATCH 1/3] fb: fix overlapping test off-by-one Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 7:29 ` Michel Dänzer
2010-12-21 7:29 ` Michel Dänzer
2010-12-21 7:29 ` Michel Dänzer
2010-12-21 7:29 ` Michel Dänzer
2010-12-24 3:28 ` Paul Mundt
2010-12-24 3:28 ` Paul Mundt
2010-12-24 3:28 ` Paul Mundt
2010-12-24 3:28 ` Paul Mundt
2010-12-23 16:40 ` [PATCH] Update fbdev fb_fix_screeninfo James Simmons
2010-12-21 1:41 ` [PATCH 2/3] vt: fix issue when fbcon wants to takeover a second time Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2011-01-06 23:57 ` Dave Airlie
2011-01-07 0:50 ` Greg KH
2011-01-07 0:52 ` Dave Airlie
2010-12-21 1:41 ` [PATCH 3/3] fbcon: fix situation where fbcon gets deinitialised and can't reinit Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-21 1:41 ` Dave Airlie
2010-12-24 3:30 ` Paul Mundt
2010-12-24 3:30 ` Paul Mundt
2010-12-24 3:30 ` Paul Mundt [this message]
2010-12-24 3:30 ` Paul Mundt
2010-12-21 1:41 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101224033015.GJ28151@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.sf.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.