Re: [PATCH 0/2] Fix hangup after creating checkpoint on Xen.

From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "SUZUKI, Kazuhiro" <kaz@jp.fujitsu.com>
Cc: linux-pm@lists.linux-foundation.org,
	xen-devel@lists.xensource.com, Greg KH <greg@kroah.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Fix hangup after creating checkpoint on Xen.
Date: Mon, 7 Feb 2011 10:35:29 +0100	[thread overview]
Message-ID: <201102071035.29922.rjw@sisk.pl> (raw)
In-Reply-To: <20110207.180718.885783824287845425.kaz@jp.fujitsu.com>

On Monday, February 07, 2011, SUZUKI, Kazuhiro wrote:
> Hi,

Hi,

> The following patch series fixes hangup after creating checkpoint on
> Xen. The Linux Xen guest can be saved the state to restore later, and
> also created snapshot like checkpoint via the hypervisor.
> But, when the snapshot is created for the PV guest, it will hangup.
> 
> We added 'PMSG_CANCEL' message and 'cancel' handler in dev_pm_ops
> struct in the pm-linux part.

Please don't do that, unless you can convince me there's no other way to fix
the problem you're trying to address.

In my opinion it's highly unrealistic to assume that device drivers
(or even subsystems) will implement the ->cancel() callback just for the
benefit of Xen.

And if the only subsystem that needs to implement ->cancel() is Xen, then the
issue should be addressed without modifying the device core code, in a different
way.

> In creating checkpoint mode, the resume handler of xenbus should not
> be called. In this case, it is recognized that the suspend was canceled
> in drivers/xen/manage.c and call dpm_resume_end() with PMSG_CANCEL.
> If the 'cancel' handler is defined, it is called instead of resume().
> 
> [1/2] - Fix hangup after creating checkpoint on Xen -- pm-linux part.
> [2/2] - Fix hangup after creating checkpoint on Xen -- Xen part.

Thanks,
Rafael