Re: [PATCH 6/6] ARM: pm: allow generic sleep code to be used with SMP CPU idle - Russell King

From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Colin Cross <ccross@google.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/6] ARM: pm: allow generic sleep code to be used with SMP CPU idle
Date: Mon, 14 Feb 2011 16:01:33 +0000	[thread overview]
Message-ID: <20110214160133.GA31501@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTimmSbs7Q_068ERWeKUFV_1Fyxvj37e3r21LZYCL@mail.gmail.com>

On Sun, Feb 13, 2011 at 01:59:54PM -0800, Colin Cross wrote:
> On Fri, Feb 11, 2011 at 8:19 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > Allow the generic sleep code to be used with SMP CPU idle by storing
> > N CPU stack pointers rather than just one.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> >  arch/arm/kernel/sleep.S |   26 +++++++++++++++++++++++++-
> >  1 files changed, 25 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/kernel/sleep.S b/arch/arm/kernel/sleep.S
> > index 9f106fa..e10618f 100644
> > --- a/arch/arm/kernel/sleep.S
> > +++ b/arch/arm/kernel/sleep.S
> 
> <snip>
> 
> > @@ -107,4 +129,6 @@ ENTRY(cpu_resume)
> >  ENDPROC(cpu_resume)
> >
> >  sleep_save_sp:
> > -       .word   0                               @ preserve stack phys ptr here
> > +       .rept   CONFIG_NR_CPUS
> > +       .long   0                               @ preserve stack phys ptr here
> > +       .endr
> 
> This doesn't compile on CONFIG_SMP=n, CONFIG_NR_CPUS is undefined.
> Including linux/threads.h will provide a default definition.

Added, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html