From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: linux-pm@lists.linux-foundation.org,
xen-devel@lists.xensource.com,
Iam Campbell <ian.campbell@citrix.com>
Subject: Re: [Xen-devel] [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt
Date: Tue, 22 Feb 2011 15:43:20 -0500 [thread overview]
Message-ID: <20110222204320.GB4605__16364.8376743824$1298476504$gmane$org@dumpdata.com> (raw)
In-Reply-To: <1298157158-5421-3-git-send-email-rshriram@cs.ubc.ca>
On Sat, Feb 19, 2011 at 03:12:37PM -0800, Shriram Rajagopalan wrote:
> Use PM_FREEZE, PM_THAW and PM_RESTORE power events for
> suspend/resume/checkpoint functionality, instead of PM_SUSPEND
> and PM_RESUME. Use of these pm events fixes the Xen Guest hangup
> when taking checkpoints. When a suspend event is cancelled
> (while taking checkpoints once/continuously), we use PM_THAW
> instead of PM_RESUME. PM_RESTORE is used when suspend is not
> cancelled. See Documentation/power/devices.txt and linux/pm.h
> for more info about freeze, thaw and restore. The sequence of
> pm events in a suspend-resume scenario is shown below.
>
> dpm_suspend_start(PMSG_FREEZE);
>
> dpm_suspend_noirq(PMSG_FREEZE);
>
> sysdev_suspend(PMSG_FREEZE);
> cancelled = suspend_hypercall()
> sysdev_resume();
>
> dpm_resume_noirq(cancelled ? PMSG_THAW : PMSG_RESTORE);
>
> dpm_resume_end(cancelled ? PMSG_THAW : PMSG_RESTORE);
>
> Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
> ---
> drivers/base/power/main.c | 8 ++++----
> drivers/xen/manage.c | 16 ++++++++--------
> drivers/xen/xenbus/xenbus_probe_frontend.c | 8 +++++---
> 3 files changed, 17 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 8340497..aab4f60 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -233,7 +233,7 @@ static int pm_op(struct device *dev,
> }
> break;
> #endif /* CONFIG_SUSPEND */
> -#ifdef CONFIG_HIBERNATION
> +#if defined(CONFIG_HIBERNATION) || defined(CONFIG_XEN_SAVE_RESTORE)
Could we just make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_HIBERANTION?
Like this:
diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
index 5b54892..838e20c 100644
--- a/arch/x86/xen/Kconfig
+++ b/arch/x86/xen/Kconfig
@@ -38,7 +38,7 @@ config XEN_MAX_DOMAIN_MEMORY
config XEN_SAVE_RESTORE
bool
- depends on XEN && PM
+ depends on XEN && PM && HIBERNATION
default y
config XEN_DEBUG_FS
next prev parent reply other threads:[~2011-02-22 20:43 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 23:12 [PATCH 0/3] xen: Use PM/Hibernate events for save/restore/chkpt Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 1/3] xen: xenbus PM events support Shriram Rajagopalan
2011-02-19 23:12 ` Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt Shriram Rajagopalan
2011-02-22 20:43 ` Konrad Rzeszutek Wilk [this message]
2011-02-22 20:43 ` Konrad Rzeszutek Wilk
2011-02-22 21:14 ` [Xen-devel] " Rafael J. Wysocki
2011-02-22 21:14 ` Rafael J. Wysocki
2011-02-22 22:09 ` [Xen-devel] " Shriram Rajagopalan
2011-02-22 22:09 ` Shriram Rajagopalan
2011-02-22 22:35 ` Rafael J. Wysocki
2011-02-22 22:35 ` [Xen-devel] " Rafael J. Wysocki
2011-02-22 22:36 ` Konrad Rzeszutek Wilk
2011-02-22 22:53 ` [Xen-devel] " Shriram Rajagopalan
2011-02-22 22:53 ` Shriram Rajagopalan
2011-02-22 22:36 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-02-19 23:12 ` Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 3/3] PM: pm.h - Add comments about Xen save/restore/chkpt use case Shriram Rajagopalan
2011-02-19 23:12 ` Shriram Rajagopalan
2011-02-20 7:49 ` [PATCH 0/3] xen: Use PM/Hibernate events for save/restore/chkpt Pavel Machek
2011-02-20 7:49 ` Pavel Machek
2011-02-21 10:05 ` Ian Campbell
2011-02-21 10:05 ` Ian Campbell
2011-02-21 16:40 ` [linux-pm] " Alan Stern
2011-02-21 17:17 ` Ian Campbell
2011-02-21 20:23 ` Rafael J. Wysocki
2011-02-25 16:17 ` Stefano Stabellini
2011-02-25 16:19 ` Ian Campbell
2011-02-25 16:19 ` [linux-pm] " Ian Campbell
2011-02-25 16:23 ` Stefano Stabellini
2011-02-25 16:23 ` [linux-pm] " Stefano Stabellini
2011-02-25 16:17 ` Stefano Stabellini
2011-02-21 20:23 ` Rafael J. Wysocki
2011-02-21 17:17 ` Ian Campbell
2011-02-21 16:40 ` Alan Stern
2011-02-23 18:38 ` Pavel Machek
2011-02-23 20:10 ` Rafael J. Wysocki
2011-02-24 16:13 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-02-24 16:13 ` Konrad Rzeszutek Wilk
2011-02-24 18:41 ` Rafael J. Wysocki
2011-02-25 17:19 ` Stefano Stabellini
2011-02-25 18:24 ` [Xen-devel] " Rafael J. Wysocki
2011-02-25 18:24 ` Rafael J. Wysocki
2011-02-28 11:06 ` [Xen-devel] " Stefano Stabellini
2011-03-04 16:04 ` Shriram Rajagopalan
2011-03-04 20:52 ` Rafael J. Wysocki
2011-03-04 20:52 ` [Xen-devel] " Rafael J. Wysocki
2011-03-04 16:04 ` Shriram Rajagopalan
2011-02-25 17:19 ` Stefano Stabellini
2011-02-24 18:41 ` Rafael J. Wysocki
2011-02-23 20:10 ` Rafael J. Wysocki
2011-02-23 18:38 ` Pavel Machek
2011-02-23 7:03 ` [PATCH v2 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt Shriram Rajagopalan
2011-02-23 7:03 ` Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20110222204320.GB4605__16364.8376743824$1298476504$gmane$org@dumpdata.com' \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rshriram@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.