Re: [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-pm@lists.linux-foundation.org,
	xen-devel@lists.xensource.com,
	Iam Campbell <ian.campbell@citrix.com>,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt
Date: Tue, 22 Feb 2011 17:36:38 -0500	[thread overview]
Message-ID: <20110222223638.GA1341@dumpdata.com> (raw)
In-Reply-To: <AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@mail.gmail.com>

> > Could we just make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_HIBERANTION?
> > Like this:
> >
> >
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index 5b54892..838e20c 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -38,7 +38,7 @@ config XEN_MAX_DOMAIN_MEMORY
> >
> >  config XEN_SAVE_RESTORE
> >        bool
> > -       depends on XEN && PM
> > +       depends on XEN && PM && HIBERNATION
> >        default y
> >
> >  config XEN_DEBUG_FS
> >
> >
> On that aspect, just noticed
> config PM_SLEEP
>         bool
>         depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
>         default y
> we could get rid of XEN_SAVE_RESTORE as the suspend/resume code doesnt
> depend on PM_SLEEP

OK. Do you want to respin patch #2 without the #ifdefs in the drivers/base/...
and provide a new patch (#4?) which will alter the Kconfig file appropriately?