From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] clk: Add simple gated clock
Date: Fri, 20 May 2011 11:37:03 +0000 [thread overview]
Message-ID: <201105201337.03501.arnd@arndb.de> (raw)
In-Reply-To: <1305876469.327589.409938867568.4.gpush@pororo>
On Friday 20 May 2011 09:27:49 Jeremy Kerr wrote:
> +static int clk_gate_enable(struct clk_hw *clk)
> +{
> + struct clk_gate *gate = to_clk_gate(clk);
> + u32 reg;
> +
> + reg = __raw_readl(gate->reg);
> + reg |= 1 << gate->bit_idx;
> + __raw_writel(reg, gate->reg);
> +
> + return 0;
> +}
__raw_readl/__raw_writel is a rather bad choice for a common driver,
it might not do what you need. Unfortunately, readl() also wouldn't
do the right thing on all architectures, because it might only
be available on PCI buses. Maybe iowrite32 would be best here?
Instead of the bit_idx, a mask value might be better to avoid
confusion with the different ways of counting bits from one or
the other end.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Jeremy Kerr <jeremy.kerr@canonical.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4/4] clk: Add simple gated clock
Date: Fri, 20 May 2011 13:37:03 +0200 [thread overview]
Message-ID: <201105201337.03501.arnd@arndb.de> (raw)
In-Reply-To: <1305876469.327589.409938867568.4.gpush@pororo>
On Friday 20 May 2011 09:27:49 Jeremy Kerr wrote:
> +static int clk_gate_enable(struct clk_hw *clk)
> +{
> + struct clk_gate *gate = to_clk_gate(clk);
> + u32 reg;
> +
> + reg = __raw_readl(gate->reg);
> + reg |= 1 << gate->bit_idx;
> + __raw_writel(reg, gate->reg);
> +
> + return 0;
> +}
__raw_readl/__raw_writel is a rather bad choice for a common driver,
it might not do what you need. Unfortunately, readl() also wouldn't
do the right thing on all architectures, because it might only
be available on PCI buses. Maybe iowrite32 would be best here?
Instead of the bit_idx, a mask value might be better to avoid
confusion with the different ways of counting bits from one or
the other end.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] clk: Add simple gated clock
Date: Fri, 20 May 2011 13:37:03 +0200 [thread overview]
Message-ID: <201105201337.03501.arnd@arndb.de> (raw)
In-Reply-To: <1305876469.327589.409938867568.4.gpush@pororo>
On Friday 20 May 2011 09:27:49 Jeremy Kerr wrote:
> +static int clk_gate_enable(struct clk_hw *clk)
> +{
> + struct clk_gate *gate = to_clk_gate(clk);
> + u32 reg;
> +
> + reg = __raw_readl(gate->reg);
> + reg |= 1 << gate->bit_idx;
> + __raw_writel(reg, gate->reg);
> +
> + return 0;
> +}
__raw_readl/__raw_writel is a rather bad choice for a common driver,
it might not do what you need. Unfortunately, readl() also wouldn't
do the right thing on all architectures, because it might only
be available on PCI buses. Maybe iowrite32 would be best here?
Instead of the bit_idx, a mask value might be better to avoid
confusion with the different ways of counting bits from one or
the other end.
Arnd
next prev parent reply other threads:[~2011-05-20 11:37 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 7:27 [PATCH 0/4] Add a generic struct clk Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` [PATCH 4/4] clk: Add simple gated clock Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 11:37 ` Arnd Bergmann [this message]
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 11:37 ` Arnd Bergmann
2011-05-20 22:19 ` Rob Herring
2011-05-20 22:19 ` Rob Herring
2011-05-20 22:19 ` Rob Herring
2011-05-20 7:27 ` [PATCH 2/4] clk: Implement clk_set_rate Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 12:25 ` Sascha Hauer
2011-05-20 12:25 ` Sascha Hauer
2011-05-20 12:25 ` Sascha Hauer
2011-05-24 7:59 ` Colin Cross
2011-05-24 7:59 ` Colin Cross
2011-05-24 7:59 ` Colin Cross
2011-05-25 19:03 ` Sascha Hauer
2011-05-25 19:03 ` Sascha Hauer
2011-05-25 19:03 ` Sascha Hauer
[not found] ` <1306373867.2875.162.camel@pororo>
2011-05-26 6:54 ` Sascha Hauer
2011-05-26 6:54 ` Sascha Hauer
2011-05-26 6:54 ` Sascha Hauer
2011-05-30 5:05 ` Mike Frysinger
2011-05-30 5:05 ` Mike Frysinger
2011-05-30 5:05 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 3/4] clk: Add fixed-rate clock Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-24 7:01 ` Francesco VIRLINZI
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:01 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-30 5:02 ` Mike Frysinger
2011-05-20 7:27 ` [PATCH 1/4] clk: Add a generic clock infrastructure Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 7:27 ` Jeremy Kerr
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 11:59 ` Sascha Hauer
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:25 ` Thomas Gleixner
2011-05-20 13:36 ` Sascha Hauer
2011-05-20 13:36 ` Sascha Hauer
2011-05-20 13:36 ` Sascha Hauer
2011-05-23 23:55 ` Colin Cross
2011-05-23 23:55 ` Colin Cross
2011-05-23 23:55 ` Colin Cross
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:02 ` Sascha Hauer
2011-05-24 7:51 ` Colin Cross
2011-05-24 7:51 ` Colin Cross
2011-05-24 7:51 ` Colin Cross
2011-05-24 8:38 ` Sascha Hauer
2011-05-24 8:38 ` Sascha Hauer
2011-05-24 8:38 ` Sascha Hauer
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:22 ` Richard Zhao
2011-05-25 11:43 ` Thomas Gleixner
2011-05-25 11:43 ` Thomas Gleixner
2011-05-25 11:43 ` Thomas Gleixner
2011-05-24 4:18 ` viresh kumar
2011-05-24 4:30 ` viresh kumar
2011-05-24 4:18 ` viresh kumar
2011-05-25 10:47 ` Richard Zhao
2011-05-25 10:47 ` Richard Zhao
2011-05-25 10:47 ` Richard Zhao
2011-05-30 5:00 ` Mike Frysinger
2011-05-30 5:00 ` Mike Frysinger
2011-05-30 5:00 ` Mike Frysinger
2011-05-23 23:12 ` [PATCH 0/4] Add a generic struct clk Colin Cross
2011-05-23 23:12 ` Colin Cross
2011-05-23 23:12 ` Colin Cross
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 6:26 ` Sascha Hauer
2011-05-24 7:31 ` Colin Cross
2011-05-24 7:31 ` Colin Cross
2011-05-24 7:31 ` Colin Cross
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 8:09 ` Sascha Hauer
2011-05-24 19:41 ` Colin Cross
2011-05-24 19:41 ` Colin Cross
2011-05-24 19:41 ` Colin Cross
2011-05-25 2:32 ` Richard Zhao
2011-05-25 2:32 ` Richard Zhao
2011-05-25 2:32 ` Richard Zhao
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 6:23 ` Sascha Hauer
2011-05-25 7:51 ` Thomas Gleixner
2011-05-25 7:51 ` Thomas Gleixner
2011-05-25 7:51 ` Thomas Gleixner
2011-05-27 14:39 ` Mark Brown
2011-05-27 14:39 ` Mark Brown
2011-05-27 14:39 ` Mark Brown
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:22 ` Richard Zhao
2011-05-24 17:52 ` Colin Cross
2011-05-24 17:52 ` Colin Cross
2011-05-24 17:52 ` Colin Cross
2011-05-25 2:08 ` Richard Zhao
2011-05-25 2:08 ` Richard Zhao
2011-05-25 2:08 ` Richard Zhao
2011-05-30 5:20 ` Mike Frysinger
2011-05-30 5:20 ` Mike Frysinger
2011-05-30 5:20 ` Mike Frysinger
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:09 ` Mark Brown
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 9:50 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 10:00 ` Russell King - ARM Linux
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:27 ` Mark Brown
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-10 11:52 ` Russell King - ARM Linux
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 2:49 ` Jeremy Kerr
2011-07-11 3:57 ` Mark Brown
2011-07-11 3:57 ` Mark Brown
2011-07-11 3:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105201337.03501.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.