From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Maxim Osipov <maxim.osipov@gmail.com>
Cc: Andrew Victor <linux@maxim.org.za>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] AT91: flexibity: default leds to heartbeat
Date: Tue, 31 May 2011 10:28:00 +0200 [thread overview]
Message-ID: <20110531082800.GE26294@game.jcrosoft.org> (raw)
In-Reply-To: <1306775627-6640-1-git-send-email-maxim.osipov@gmail.com>
On 18:13 Mon 30 May , Maxim Osipov wrote:
> This patch changes default behavior of Flexibity board LEDs to blinking
> for boot diagnostic purpose.
>
> Signed-off-by: Maxim Osipov <maxim.osipov@gmail.com>
> ---
> arch/arm/mach-at91/board-flexibity.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
> index 4fdc96c..8cbec8a 100644
> --- a/arch/arm/mach-at91/board-flexibity.c
> +++ b/arch/arm/mach-at91/board-flexibity.c
> @@ -96,49 +96,49 @@ static struct gpio_led flexibity_leds[] = {
> .name = "usb1:green",
> .gpio = AT91_PIN_PA12,
> .active_low = 1,
> - .default_trigger = "default-on",
> + .default_trigger = "heartbeat",
can we factorize this a few
they have all the same default_trigger and active low
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] AT91: flexibity: default leds to heartbeat
Date: Tue, 31 May 2011 10:28:00 +0200 [thread overview]
Message-ID: <20110531082800.GE26294@game.jcrosoft.org> (raw)
In-Reply-To: <1306775627-6640-1-git-send-email-maxim.osipov@gmail.com>
On 18:13 Mon 30 May , Maxim Osipov wrote:
> This patch changes default behavior of Flexibity board LEDs to blinking
> for boot diagnostic purpose.
>
> Signed-off-by: Maxim Osipov <maxim.osipov@gmail.com>
> ---
> arch/arm/mach-at91/board-flexibity.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-flexibity.c b/arch/arm/mach-at91/board-flexibity.c
> index 4fdc96c..8cbec8a 100644
> --- a/arch/arm/mach-at91/board-flexibity.c
> +++ b/arch/arm/mach-at91/board-flexibity.c
> @@ -96,49 +96,49 @@ static struct gpio_led flexibity_leds[] = {
> .name = "usb1:green",
> .gpio = AT91_PIN_PA12,
> .active_low = 1,
> - .default_trigger = "default-on",
> + .default_trigger = "heartbeat",
can we factorize this a few
they have all the same default_trigger and active low
Best Regards,
J.
next prev parent reply other threads:[~2011-05-31 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 17:13 [PATCH 1/1] AT91: flexibity: default leds to heartbeat Maxim Osipov
2011-05-30 17:13 ` Maxim Osipov
2011-05-31 8:28 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-05-31 8:28 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531082800.GE26294@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@maxim.org.za \
--cc=maxim.osipov@gmail.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.