From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Paul Walmsley <paul@pwsan.com>
Cc: Rajendra Nayak <rnayak@ti.com>,
khilman@ti.com, linux-omap@vger.kernel.org,
santosh.shilimkar@ti.com, b-cousson@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep
Date: Thu, 23 Jun 2011 16:22:49 +0100 [thread overview]
Message-ID: <20110623152249.GG9449@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1106230819540.12954@utopia.booyaka.com>
On Thu, Jun 23, 2011 at 09:04:20AM -0600, Paul Walmsley wrote:
> Since this is basically a hack to work around limitations of the current
> MMC driver, if we accept something like this, I think it should come with
> a big warning message and comment. Something like this in
> omap44xx_clockdomains_init():
>
> /*
> * XXX The OMAP L3 interconnect hardware is able to enter
> * hardware-supervised idle. But because the OMAP HSMMC
> * driver still hasn't been converted to use runtime PM, if
> * the L3 is allowed to enter hwsup idle, the kernel will
> * crash. Once the MMC driver is fixed (which patches have
> * been posted to do, with subject line "OMAP: HSMMC: cleanup
> * and runtime pm") the change to the l3_init_44xx_clkdm
> * flags should be dropped. It limits the low-power state that
> * the chip can enter.
> */
> pr_warn("WARNING: OMAP4 low power states artificially limited, due
> to unconverted HSMMC driver\n");
Do you really want to continue pissing Linus off with churn like this
rather than pressing to get problems fixed _properly_ (eg, getting the
HSMMC driver fixed) ?
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep
Date: Thu, 23 Jun 2011 16:22:49 +0100 [thread overview]
Message-ID: <20110623152249.GG9449@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1106230819540.12954@utopia.booyaka.com>
On Thu, Jun 23, 2011 at 09:04:20AM -0600, Paul Walmsley wrote:
> Since this is basically a hack to work around limitations of the current
> MMC driver, if we accept something like this, I think it should come with
> a big warning message and comment. Something like this in
> omap44xx_clockdomains_init():
>
> /*
> * XXX The OMAP L3 interconnect hardware is able to enter
> * hardware-supervised idle. But because the OMAP HSMMC
> * driver still hasn't been converted to use runtime PM, if
> * the L3 is allowed to enter hwsup idle, the kernel will
> * crash. Once the MMC driver is fixed (which patches have
> * been posted to do, with subject line "OMAP: HSMMC: cleanup
> * and runtime pm") the change to the l3_init_44xx_clkdm
> * flags should be dropped. It limits the low-power state that
> * the chip can enter.
> */
> pr_warn("WARNING: OMAP4 low power states artificially limited, due
> to unconverted HSMMC driver\n");
Do you really want to continue pissing Linus off with churn like this
rather than pressing to get problems fixed _properly_ (eg, getting the
HSMMC driver fixed) ?
next prev parent reply other threads:[~2011-06-23 15:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 10:54 [PATCH 0/8] Fix module-mode enable sequence on OMAP4 Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 2/8] OMAP2+: clockdomain: Add SoC support for clkdm_is_idle Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 3/8] OMAP2+: PM: Initialise sleep_switch to a non-valid value Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 4/8] OMAP2+: PM: idle clkdms only if already in idle Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 6/8] OMAP2+: hwmod: Follow the recomended PRCM clock enable sequence Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 7/8] OMAP: clock: Add flags to identify optional clock nodes Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-09 10:54 ` [PATCH 8/8] OMAP: clock: Enable clockdomain only for optional clocks Rajendra Nayak
2011-06-09 10:54 ` Rajendra Nayak
2011-06-23 15:04 ` [PATCH 5/8] OMAP4: PM: TEMP: Prevent l3init from idling/force sleep Paul Walmsley
2011-06-23 15:04 ` Paul Walmsley
2011-06-23 15:22 ` Russell King - ARM Linux [this message]
2011-06-23 15:22 ` Russell King - ARM Linux
2011-07-06 5:30 ` Paul Walmsley
2011-07-06 5:30 ` Paul Walmsley
2011-06-10 0:15 ` [PATCH 4/8] OMAP2+: PM: idle clkdms only if already in idle Todd Poynor
2011-06-10 0:15 ` Todd Poynor
2011-06-10 11:22 ` Rajendra Nayak
2011-06-10 11:22 ` Rajendra Nayak
2011-06-27 6:34 ` Paul Walmsley
2011-06-27 6:34 ` Paul Walmsley
2011-06-27 23:36 ` Rajendra Nayak
2011-06-27 23:36 ` Rajendra Nayak
2011-06-10 0:07 ` [PATCH 1/8] OMAP2+: clockdomain: Add an api to read idle mode Todd Poynor
2011-06-10 0:07 ` Todd Poynor
2011-06-10 11:08 ` Rajendra Nayak
2011-06-10 11:08 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623152249.GG9449@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.