From: Ido Yariv <ido@wizery.com>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 1/6] arm: davinci: Fix low level gpio irq handlers' argument
Date: Mon, 11 Jul 2011 23:33:56 +0300 [thread overview]
Message-ID: <20110711203356.GA5633@WorkStation> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024DA7A9DD@dbde02.ent.ti.com>
Hi Sekhar,
On Mon, Jul 11, 2011 at 05:28:44PM +0530, Nori, Sekhar wrote:
> Thanks for the bug fix.
>
> How about setting the handler data for bank IRQ in
> davinci_gpio_irq_setup() to &chips[bank]?
>
> chips[bank].regs should give you the register base address
> (g) and chips[bank].irq_base should give you 'n'.
>
> Also please drop the rename of irq to bank_irq as it is not
> central to the bug fix.
>
> If you spin in soon enough, we may make it to v3.0
Sure, I'll send a v3 in a few.
Thanks for the review,
Ido.
WARNING: multiple messages have this Message-ID (diff)
From: ido@wizery.com (Ido Yariv)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/6] arm: davinci: Fix low level gpio irq handlers' argument
Date: Mon, 11 Jul 2011 23:33:56 +0300 [thread overview]
Message-ID: <20110711203356.GA5633@WorkStation> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024DA7A9DD@dbde02.ent.ti.com>
Hi Sekhar,
On Mon, Jul 11, 2011 at 05:28:44PM +0530, Nori, Sekhar wrote:
> Thanks for the bug fix.
>
> How about setting the handler data for bank IRQ in
> davinci_gpio_irq_setup() to &chips[bank]?
>
> chips[bank].regs should give you the register base address
> (g) and chips[bank].irq_base should give you 'n'.
>
> Also please drop the rename of irq to bank_irq as it is not
> central to the bug fix.
>
> If you spin in soon enough, we may make it to v3.0
Sure, I'll send a v3 in a few.
Thanks for the review,
Ido.
next prev parent reply other threads:[~2011-07-11 20:34 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 13:14 [PATCH v2 0/6] arm: davinci: DA850: wl12xx expansion card Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-10 13:14 ` [PATCH v2 1/6] arm: davinci: Fix low level gpio irq handlers' argument Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-11 11:58 ` Nori, Sekhar
2011-07-11 11:58 ` Nori, Sekhar
2011-07-11 20:33 ` Ido Yariv [this message]
2011-07-11 20:33 ` Ido Yariv
2011-07-11 21:03 ` [PATCH v3 " Ido Yariv
2011-07-11 21:03 ` Ido Yariv
2011-07-12 9:22 ` Nori, Sekhar
2011-07-12 9:22 ` Nori, Sekhar
2011-07-12 22:19 ` Ido Yariv
2011-07-12 22:19 ` Ido Yariv
2011-07-10 13:14 ` [PATCH v2 2/6] arm: davinci: Explicitly set channel controllers' default queues Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-25 13:15 ` Nori, Sekhar
2011-07-25 13:15 ` Nori, Sekhar
2011-07-25 13:33 ` Sergei Shtylyov
2011-07-25 13:33 ` Sergei Shtylyov
2011-07-25 16:31 ` Nori, Sekhar
2011-07-25 16:31 ` Nori, Sekhar
2011-07-29 14:42 ` Ben Gardiner
2011-07-29 14:42 ` Ben Gardiner
2011-07-10 13:14 ` [PATCH v2 3/6] arm: davinci: mmc: Add support for set_power callback Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-25 13:19 ` Nori, Sekhar
2011-07-25 13:19 ` Nori, Sekhar
2011-07-28 20:49 ` [PATCH REPOST v2] mmc: davinci: " Ido Yariv
2011-07-28 20:49 ` Ido Yariv
2011-07-28 22:02 ` Chris Ball
2011-07-28 22:02 ` Chris Ball
2011-07-10 13:14 ` [PATCH v2 4/6] arm: davinci: DA850: Add MMC/SD1 pinmux configuration Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-10 13:14 ` [PATCH v2 5/6] arm: davinci: DA850: Add GPIO pinmux configuration for wl1271 Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-25 13:23 ` Nori, Sekhar
2011-07-25 13:23 ` Nori, Sekhar
2011-07-10 13:14 ` [PATCH v2 6/6] arm: davinci: DA850: Add wl1271/wlan support Ido Yariv
2011-07-10 13:14 ` Ido Yariv
2011-07-25 17:40 ` Nori, Sekhar
2011-07-25 17:40 ` Nori, Sekhar
2011-07-28 18:34 ` Ido Yariv
2011-07-28 18:34 ` Ido Yariv
2011-08-22 7:37 ` Harishkumar V
2011-07-28 20:52 ` [PATCH v3] davinci: Add wl1271/wlan support for AM18x Ido Yariv
2011-07-28 20:52 ` Ido Yariv
2011-07-28 21:15 ` Troy Kisky
2011-07-28 21:15 ` Troy Kisky
2011-07-28 22:06 ` Ido Yariv
2011-07-28 22:06 ` Ido Yariv
2011-07-29 18:51 ` Troy Kisky
2011-07-29 18:51 ` Troy Kisky
2011-08-03 13:27 ` Nori, Sekhar
2011-08-04 7:51 ` [PATCH v4] ARM: davinci: AM18x: Add wl1271/wlan support Ido Yariv
2011-08-04 7:51 ` Ido Yariv
2011-08-04 8:40 ` Jaya Kumar
2011-08-04 8:40 ` Jaya Kumar
2011-08-04 9:22 ` Ido Yariv
2011-08-04 9:22 ` Ido Yariv
2011-09-01 11:59 ` Nori, Sekhar
2011-09-01 11:59 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711203356.GA5633@WorkStation \
--to=ido@wizery.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.