All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Dong Aisheng <b29396@freescale.com>
Cc: alsa-devel@alsa-project.org, s.hauer@pengutronix.de,
	broonie@opensource.wolfsonmicro.com,
	u.kleine-koenig@pengutronix.de, lrg@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver
Date: Wed, 13 Jul 2011 13:57:11 +0200	[thread overview]
Message-ID: <20110713115711.GG1928@pengutronix.de> (raw)
In-Reply-To: <1310483085-31442-4-git-send-email-b29396@freescale.com>


[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]

On Tue, Jul 12, 2011 at 11:04:38PM +0800, Dong Aisheng wrote:
> The driver only supports playback firstly.
> For recording, as we have to use two saif instances to implement full
> duplex (playback & recording) due to hardware limitation, we need to
> figure out a good design to fit in ASoC.
> 
> Signed-off-by: Dong Aisheng <b29396@freescale.com>

Which version of the codec do you have? I have:

[    0.370000] sgtl5000 0-000a: sgtl5000 revision 17
[    0.370000] sgtl5000 0-000a: asoc: failed to probe CODEC sgtl5000.0-000a: -22
[    0.380000] asoc: failed to instantiate card mxs_sgtl5000: -22

The failure is because CONFIG_REGULATOR is not set and it thus fails in the
codec-driver:

#else /* CONFIG_REGULATOR */
static int ldo_regulator_register(struct snd_soc_codec *codec,
				struct regulator_init_data *init_data,
				int voltage)
{
	return -EINVAL;
}

(I can patch it to load properly, but well...)

Proper regulator support for mxs is not in mainline yet. Is that
planned? How do you do it?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver
Date: Wed, 13 Jul 2011 13:57:11 +0200	[thread overview]
Message-ID: <20110713115711.GG1928@pengutronix.de> (raw)
In-Reply-To: <1310483085-31442-4-git-send-email-b29396@freescale.com>

On Tue, Jul 12, 2011 at 11:04:38PM +0800, Dong Aisheng wrote:
> The driver only supports playback firstly.
> For recording, as we have to use two saif instances to implement full
> duplex (playback & recording) due to hardware limitation, we need to
> figure out a good design to fit in ASoC.
> 
> Signed-off-by: Dong Aisheng <b29396@freescale.com>

Which version of the codec do you have? I have:

[    0.370000] sgtl5000 0-000a: sgtl5000 revision 17
[    0.370000] sgtl5000 0-000a: asoc: failed to probe CODEC sgtl5000.0-000a: -22
[    0.380000] asoc: failed to instantiate card mxs_sgtl5000: -22

The failure is because CONFIG_REGULATOR is not set and it thus fails in the
codec-driver:

#else /* CONFIG_REGULATOR */
static int ldo_regulator_register(struct snd_soc_codec *codec,
				struct regulator_init_data *init_data,
				int voltage)
{
	return -EINVAL;
}

(I can patch it to load properly, but well...)

Proper regulator support for mxs is not in mainline yet. Is that
planned? How do you do it?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110713/957bf247/attachment-0001.sig>

  reply	other threads:[~2011-07-13 11:57 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 15:04 [PATCH V2 00/10] Dong Aisheng
2011-07-12 15:04 ` Dong Aisheng
2011-07-12 15:04 ` [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-12 23:27   ` Mark Brown
2011-07-12 23:27     ` Mark Brown
2011-07-13  3:20     ` Dong Aisheng-B29396
2011-07-13  3:20       ` Dong Aisheng-B29396
2011-07-13  6:29     ` Dong Aisheng-B29396
2011-07-13  6:29       ` Dong Aisheng-B29396
2011-07-13  7:44   ` Russell King - ARM Linux
2011-07-13  7:44     ` Russell King - ARM Linux
2011-07-13  8:17     ` Dong Aisheng-B29396
2011-07-13  8:17       ` Dong Aisheng-B29396
2011-07-14 12:31   ` Wolfram Sang
2011-07-14 12:31     ` Wolfram Sang
2011-07-14 16:15     ` Dong Aisheng
2011-07-14 16:15       ` [alsa-devel] " Dong Aisheng
2011-07-15  6:30       ` Dong Aisheng-B29396
2011-07-15  6:30         ` [alsa-devel] " Dong Aisheng-B29396
2011-07-12 15:04 ` [PATCH V2 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-13  1:03   ` Mark Brown
2011-07-13  1:03     ` Mark Brown
2011-07-13  8:14     ` [alsa-devel] " Dong Aisheng-B29396
2011-07-13  8:14       ` Dong Aisheng-B29396
2011-07-14  3:06       ` Mark Brown
2011-07-14  3:06         ` Mark Brown
2011-07-14  4:34         ` Dong Aisheng-B29396
2011-07-14  4:34           ` Dong Aisheng-B29396
2011-07-14 10:39         ` Dong Aisheng-B29396
2011-07-14 10:39           ` [alsa-devel] " Dong Aisheng-B29396
2011-07-14 11:05           ` Mark Brown
2011-07-14 11:05             ` [alsa-devel] " Mark Brown
2011-07-14 16:06             ` Dong Aisheng
2011-07-14 16:06               ` [alsa-devel] " Dong Aisheng
2011-07-12 15:04 ` [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-13 11:57   ` Wolfram Sang [this message]
2011-07-13 11:57     ` Wolfram Sang
2011-07-13 12:19     ` Dong Aisheng-B29396
2011-07-13 12:19       ` Dong Aisheng-B29396
2011-07-13 13:40       ` Dong Aisheng-B29396
2011-07-13 13:40         ` Dong Aisheng-B29396
2011-07-13 14:00         ` Wolfram Sang
2011-07-13 14:00           ` Wolfram Sang
2011-07-13 14:13           ` Dong Aisheng-B29396
2011-07-13 14:13             ` Dong Aisheng-B29396
2011-07-13 14:22           ` Dong Aisheng-B29396
2011-07-13 14:22             ` Dong Aisheng-B29396
2011-07-13 15:01             ` Wolfram Sang
2011-07-13 15:01               ` Wolfram Sang
2011-07-13 15:16               ` Dong Aisheng
2011-07-13 15:16                 ` Dong Aisheng
2011-07-13 12:46     ` Mark Brown
2011-07-13 12:46       ` Mark Brown
2011-07-13 12:59       ` Wolfram Sang
2011-07-13 12:59         ` Wolfram Sang
2011-07-13 15:58   ` Wolfram Sang
2011-07-13 15:58     ` Wolfram Sang
2011-07-14  3:04     ` [alsa-devel] " Dong Aisheng-B29396
2011-07-14  3:04       ` Dong Aisheng-B29396
     [not found]   ` <1310483085-31442-4-git-send-email-b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-07-15 15:11     ` Shawn Guo
2011-07-15 15:11       ` Shawn Guo
2011-07-15 15:17       ` Mark Brown
2011-07-15 15:17         ` Mark Brown
2011-07-12 15:04 ` [PATCH V2 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-13  9:08   ` Wolfram Sang
2011-07-13  9:08     ` Wolfram Sang
2011-07-13 11:13     ` Dong Aisheng
2011-07-13 11:13       ` [alsa-devel] " Dong Aisheng
2011-07-12 15:04 ` [PATCH V2 05/10] ARM: mxs: add saif clock Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-12 15:04 ` [PATCH V2 06/10] ARM: mxs: add saif device Dong Aisheng
2011-07-12 15:04   ` Dong Aisheng
2011-07-15 13:32   ` Wolfram Sang
2011-07-15 13:32     ` Wolfram Sang
2011-07-15 15:02     ` Dong Aisheng
2011-07-15 15:02       ` [alsa-devel] " Dong Aisheng
2011-07-15 15:34       ` Wolfram Sang
2011-07-15 15:34         ` [alsa-devel] " Wolfram Sang
2011-07-15 17:22         ` Dong Aisheng
2011-07-15 17:22           ` [alsa-devel] " Dong Aisheng
2011-07-12 18:22 ` [PATCH V2 00/10] Wolfram Sang
2011-07-12 18:22   ` Wolfram Sang
2011-07-13  3:02   ` [PATCH V2 00/10] ARM: mxs: add audio support Dong Aisheng-B29396
2011-07-13  3:02     ` Dong Aisheng-B29396
2011-07-13  3:36 ` [PATCH V2 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng
2011-07-13  3:36   ` Dong Aisheng
2011-07-13  9:13   ` Wolfram Sang
2011-07-13  9:13     ` Wolfram Sang
2011-07-13  9:56     ` Wolfram Sang
2011-07-13  9:56       ` Wolfram Sang
2011-07-13 11:09       ` Dong Aisheng-B29396
2011-07-13 11:09         ` Dong Aisheng-B29396
2011-07-13  3:39 ` [PATCH V2 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng
2011-07-13  3:39   ` Dong Aisheng
2011-07-13  3:40 ` [PATCH V2 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng
2011-07-13  3:40   ` Dong Aisheng
2011-07-13  3:40 ` [PATCH V2 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Dong Aisheng
2011-07-13  3:40   ` Dong Aisheng
2011-07-14 14:17   ` Wolfram Sang
2011-07-14 14:17     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110713115711.GG1928@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=b29396@freescale.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lrg@ti.com \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.