From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/7] at91/i2c: move register header to drivers
Date: Fri, 15 Jul 2011 17:49:31 +0200 [thread overview]
Message-ID: <20110715154931.GB20678@game.jcrosoft.org> (raw)
In-Reply-To: <20110715092314.215043d5-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On 09:23 Fri 15 Jul , Jean Delvare wrote:
> Hi Jean-Christophe,
>
> On Fri, 15 Jul 2011 01:52:00 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> > Cc: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > ---
> > drivers/i2c/busses/i2c-at91.c | 3 ++-
> > .../at91_twi.h => drivers/i2c/busses/i2c-at91.h | 7 +++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> > rename arch/arm/mach-at91/include/mach/at91_twi.h => drivers/i2c/busses/i2c-at91.h (97%)
>
> Why don't you just merge i2c-at91.h into i2c-at91.c then, if it's the
> only user?
I prefer to keep the define in a seperate file
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] at91/i2c: move register header to drivers
Date: Fri, 15 Jul 2011 17:49:31 +0200 [thread overview]
Message-ID: <20110715154931.GB20678@game.jcrosoft.org> (raw)
In-Reply-To: <20110715092314.215043d5@endymion.delvare>
On 09:23 Fri 15 Jul , Jean Delvare wrote:
> Hi Jean-Christophe,
>
> On Fri, 15 Jul 2011 01:52:00 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: linux-i2c at vger.kernel.org
> > ---
> > drivers/i2c/busses/i2c-at91.c | 3 ++-
> > .../at91_twi.h => drivers/i2c/busses/i2c-at91.h | 7 +++----
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> > rename arch/arm/mach-at91/include/mach/at91_twi.h => drivers/i2c/busses/i2c-at91.h (97%)
>
> Why don't you just merge i2c-at91.h into i2c-at91.c then, if it's the
> only user?
I prefer to keep the define in a seperate file
Best Regards,
J.
next prev parent reply other threads:[~2011-07-15 15:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 23:51 [PATCH 1/7] at91rm9200: emac move register header to drivers Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` [PATCH 2/7] at91/i2c: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1310687525-22486-2-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2011-07-15 7:23 ` Jean Delvare
2011-07-15 7:23 ` Jean Delvare
[not found] ` <20110715092314.215043d5-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-15 15:49 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-07-15 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` [PATCH 3/7] at91_mci: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` [PATCH 4/7] at91: remove non used at91_spi.h Jean-Christophe PLAGNIOL-VILLARD
2011-07-15 11:47 ` Detlef Vollmann
2011-07-15 15:46 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-15 16:44 ` Detlef Vollmann
2011-07-16 10:57 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 11:56 ` Wolfram Sang
2011-07-16 11:56 ` Wolfram Sang
2011-07-16 14:00 ` Detlef Vollmann
2011-07-16 14:00 ` Detlef Vollmann
2011-07-17 2:33 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-17 2:33 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-16 13:41 ` Detlef Vollmann
2011-07-17 2:36 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-18 7:35 ` Andrew Victor
2011-07-14 23:52 ` [PATCH 5/7] at91: remove non used at91_ssc.h Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` [PATCH 6/7] at91rm9200/rtc: move register header to drivers Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` [PATCH 7/7] at91sam9/wdt: " Jean-Christophe PLAGNIOL-VILLARD
2011-07-14 23:52 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-15 11:04 ` Wim Van Sebroeck
2011-07-15 11:04 ` Wim Van Sebroeck
2011-07-22 18:28 ` Wim Van Sebroeck
2011-07-22 18:28 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715154931.GB20678@game.jcrosoft.org \
--to=plagnioj-sclmfoaustbwk0htik3j/w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.