From: Russell King - ARM Linux <linux@arm.linux.org.uk> To: Boojin Kim <boojin.kim@samsung.com> Cc: Kukjin Kim <kgene.kim@samsung.com>, Vinod Koul <vinod.koul@intel.com>, Jassi Brar <jassisinghbrar@gmail.com>, Grant Likely <grant.likely@secretlab.ca>, linux-samsung-soc@vger.kernel.org, Mark Brown <broonie@opensource.wolfsonmicro.com>, Dan Williams <dan.j.williams@intel.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations Date: Mon, 25 Jul 2011 10:36:10 +0100 [thread overview] Message-ID: <20110725093610.GC9653@n2100.arm.linux.org.uk> (raw) In-Reply-To: <1311557312-26107-7-git-send-email-boojin.kim@samsung.com> On Mon, Jul 25, 2011 at 10:28:24AM +0900, Boojin Kim wrote: > +static unsigned samsung_dmadev_request(enum dma_ch dma_ch, > + struct samsung_dma_info *info) > +{ > + struct dma_chan *chan; > + dma_cap_mask_t mask; > + struct dma_slave_config slave_config; > + > + dma_cap_zero(mask); > + dma_cap_set(info->cap, mask); > + > + chan = dma_request_channel(mask, pl330_filter, (void *)dma_ch); > + > + if (info->direction == DMA_FROM_DEVICE) { > + memset(&slave_config, 0, sizeof(struct dma_slave_config)); > + slave_config.direction = info->direction; > + slave_config.src_addr = info->fifo; > + slave_config.src_addr_width = info->width; This should really set slave_config.src_maxburst to something sensible too, even if that's just '1'. > + dmaengine_slave_config(chan, &slave_config); > + } else if (info->direction == DMA_TO_DEVICE) { > + memset(&slave_config, 0, sizeof(struct dma_slave_config)); > + slave_config.direction = info->direction; > + slave_config.dst_addr = info->fifo; > + slave_config.dst_addr_width = info->width; Ditto for dst_maxburst. > + dmaengine_slave_config(chan, &slave_config); > + } > + > + return (unsigned)chan; I hope these interfaces yet cleaned away soon so that these casts can be killed off. > +struct samsung_dma_prep_info { > + enum dma_transaction_type cap; > + enum dma_data_direction direction; > + unsigned buf; dma_addr_t ? > + unsigned long period; > + unsigned long len; > + void (*fp)(void *data); > + void *fp_param; > +}; > + > +struct samsung_dma_info { > + enum dma_transaction_type cap; > + enum dma_data_direction direction; > + enum dma_slave_buswidth width; > + unsigned fifo; dma_addr_t ? > + struct s3c2410_dma_client *client; > +}; > + > +struct samsung_dma_ops { > + bool init; Unused?
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations Date: Mon, 25 Jul 2011 10:36:10 +0100 [thread overview] Message-ID: <20110725093610.GC9653@n2100.arm.linux.org.uk> (raw) In-Reply-To: <1311557312-26107-7-git-send-email-boojin.kim@samsung.com> On Mon, Jul 25, 2011 at 10:28:24AM +0900, Boojin Kim wrote: > +static unsigned samsung_dmadev_request(enum dma_ch dma_ch, > + struct samsung_dma_info *info) > +{ > + struct dma_chan *chan; > + dma_cap_mask_t mask; > + struct dma_slave_config slave_config; > + > + dma_cap_zero(mask); > + dma_cap_set(info->cap, mask); > + > + chan = dma_request_channel(mask, pl330_filter, (void *)dma_ch); > + > + if (info->direction == DMA_FROM_DEVICE) { > + memset(&slave_config, 0, sizeof(struct dma_slave_config)); > + slave_config.direction = info->direction; > + slave_config.src_addr = info->fifo; > + slave_config.src_addr_width = info->width; This should really set slave_config.src_maxburst to something sensible too, even if that's just '1'. > + dmaengine_slave_config(chan, &slave_config); > + } else if (info->direction == DMA_TO_DEVICE) { > + memset(&slave_config, 0, sizeof(struct dma_slave_config)); > + slave_config.direction = info->direction; > + slave_config.dst_addr = info->fifo; > + slave_config.dst_addr_width = info->width; Ditto for dst_maxburst. > + dmaengine_slave_config(chan, &slave_config); > + } > + > + return (unsigned)chan; I hope these interfaces yet cleaned away soon so that these casts can be killed off. > +struct samsung_dma_prep_info { > + enum dma_transaction_type cap; > + enum dma_data_direction direction; > + unsigned buf; dma_addr_t ? > + unsigned long period; > + unsigned long len; > + void (*fp)(void *data); > + void *fp_param; > +}; > + > +struct samsung_dma_info { > + enum dma_transaction_type cap; > + enum dma_data_direction direction; > + enum dma_slave_buswidth width; > + unsigned fifo; dma_addr_t ? > + struct s3c2410_dma_client *client; > +}; > + > +struct samsung_dma_ops { > + bool init; Unused?
next prev parent reply other threads:[~2011-07-25 9:36 UTC|newest] Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-07-25 1:28 [RESEND] [PATCH V4 0/14] To use DMA generic APIs for Samsung DMA Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 01/14] DMA: PL330: Add support runtime PM for PL330 DMAC Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-26 6:03 ` Chanwoo Choi 2011-07-26 6:03 ` Chanwoo Choi 2011-07-25 1:28 ` [PATCH V4 02/14] DMA: PL330: Update PL330 DMA API driver Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 8:57 ` Jassi Brar 2011-07-25 8:57 ` Jassi Brar 2011-07-25 9:48 ` Boojin Kim 2011-07-25 9:48 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 03/14] DMA: PL330: Support DMA_SLAVE_CONFIG command Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 10:26 ` Vinod Koul 2011-07-25 10:26 ` Vinod Koul 2011-07-25 12:51 ` Boojin Kim 2011-07-25 12:51 ` Boojin Kim 2011-07-25 13:48 ` Vinod Koul 2011-07-25 13:48 ` Vinod Koul 2011-07-26 13:04 ` Boojin Kim 2011-07-26 13:04 ` Boojin Kim 2011-07-26 13:12 ` Russell King - ARM Linux 2011-07-26 13:12 ` Russell King - ARM Linux 2011-07-25 1:28 ` [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 9:27 ` Russell King - ARM Linux 2011-07-25 9:27 ` Russell King - ARM Linux 2011-07-25 10:31 ` Boojin Kim 2011-07-25 10:31 ` Boojin Kim 2011-07-25 10:36 ` Russell King - ARM Linux 2011-07-25 10:36 ` Russell King - ARM Linux 2011-07-25 10:48 ` Vinod Koul 2011-07-25 10:48 ` Vinod Koul 2011-07-25 10:57 ` Russell King - ARM Linux 2011-07-25 10:57 ` Russell King - ARM Linux 2011-07-25 11:01 ` Vinod Koul 2011-07-25 11:01 ` Vinod Koul 2011-07-25 11:39 ` Russell King - ARM Linux 2011-07-25 11:39 ` Russell King - ARM Linux 2011-07-25 12:01 ` Vinod Koul 2011-07-25 12:01 ` Vinod Koul 2011-07-26 7:57 ` [PATCH] Improve slave/cyclic DMA engine documentation (was: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability) Russell King - ARM Linux 2011-07-26 7:57 ` Russell King - ARM Linux 2011-07-26 9:35 ` Vinod Koul 2011-07-26 9:35 ` Vinod Koul 2011-07-26 14:37 ` Jassi Brar 2011-07-26 14:37 ` Jassi Brar 2011-07-26 17:20 ` Russell King - ARM Linux 2011-07-26 17:20 ` Russell King - ARM Linux 2011-07-26 17:55 ` Jassi Brar 2011-07-26 17:55 ` Jassi Brar 2011-07-26 18:03 ` Grant Likely 2011-07-26 18:03 ` Grant Likely 2011-07-26 18:16 ` Russell King - ARM Linux 2011-07-26 18:16 ` Russell King - ARM Linux 2011-07-27 2:38 ` Vinod Koul 2011-07-27 2:38 ` Vinod Koul 2011-07-27 9:01 ` Russell King - ARM Linux 2011-07-27 9:01 ` Russell King - ARM Linux 2011-07-27 9:06 ` Koul, Vinod 2011-07-27 9:06 ` Koul, Vinod 2011-07-26 13:25 ` Russell King - ARM Linux 2011-07-26 13:25 ` Russell King - ARM Linux 2011-07-25 12:36 ` [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim 2011-07-25 12:36 ` Boojin Kim 2011-07-25 12:34 ` Boojin Kim 2011-07-25 12:34 ` Boojin Kim 2011-07-25 11:24 ` Jassi Brar 2011-07-25 11:24 ` Jassi Brar 2011-07-26 12:28 ` Boojin Kim 2011-07-26 12:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 05/14] ARM: SAMSUNG: Update to use PL330-DMA driver Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 10:52 ` Vinod Koul 2011-07-25 10:52 ` Vinod Koul 2011-07-25 11:31 ` Jassi Brar 2011-07-25 11:31 ` Jassi Brar 2011-07-25 1:28 ` [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 9:36 ` Russell King - ARM Linux [this message] 2011-07-25 9:36 ` Russell King - ARM Linux 2011-07-25 9:57 ` Boojin Kim 2011-07-25 9:57 ` Boojin Kim 2011-07-25 11:51 ` Jassi Brar 2011-07-25 11:51 ` Jassi Brar 2011-07-26 8:02 ` Russell King - ARM Linux 2011-07-26 8:02 ` Russell King - ARM Linux 2011-07-26 17:43 ` Jassi Brar 2011-07-26 17:43 ` Jassi Brar 2011-07-26 18:14 ` Russell King - ARM Linux 2011-07-26 18:14 ` Russell King - ARM Linux 2011-07-26 19:54 ` Jassi Brar 2011-07-26 19:54 ` Jassi Brar 2011-07-26 9:35 ` Boojin Kim 2011-07-26 9:35 ` Boojin Kim 2011-07-27 1:33 ` Jassi Brar 2011-07-27 1:33 ` Jassi Brar 2011-07-27 5:17 ` Boojin Kim 2011-07-27 5:17 ` Boojin Kim 2011-07-27 7:57 ` Jassi Brar 2011-07-27 7:57 ` Jassi Brar 2011-07-28 0:38 ` Boojin Kim 2011-07-28 0:38 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 07/14] ARM: EXYNOS4: Use generic DMA PL330 driver Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 11:59 ` Jassi Brar 2011-07-25 11:59 ` Jassi Brar 2011-07-25 12:59 ` Boojin Kim 2011-07-25 12:59 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 08/14] ARM: S5PV210: " Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 09/14] ARM: S5PC100: " Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 10/14] ARM: S5P64X0: " Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 11/14] ARM: SAMSUNG: Remove S3C-PL330-DMA driver Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 12/14] spi/s3c64xx: Add support DMA engine API Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 9:40 ` Russell King - ARM Linux 2011-07-25 9:40 ` Russell King - ARM Linux 2011-07-25 10:34 ` Boojin Kim 2011-07-25 10:34 ` Boojin Kim 2011-07-25 11:17 ` Vinod Koul 2011-07-25 11:17 ` Vinod Koul 2011-07-26 9:31 ` Boojin Kim 2011-07-26 9:31 ` Boojin Kim 2011-07-26 10:14 ` Vinod Koul 2011-07-26 10:14 ` Vinod Koul 2011-07-27 5:05 ` Boojin Kim 2011-07-27 5:05 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 13/14] ASoC: Samsung: Update DMA interface Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 1:28 ` [PATCH V4 14/14] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction Boojin Kim 2011-07-25 1:28 ` Boojin Kim 2011-07-25 12:08 ` Jassi Brar 2011-07-25 12:08 ` Jassi Brar 2011-07-25 21:15 ` Grant Likely 2011-07-25 21:15 ` Grant Likely 2011-07-28 1:23 ` Boojin Kim 2011-07-28 1:23 ` Boojin Kim 2011-07-25 10:17 ` [RESEND] [PATCH V4 0/14] To use DMA generic APIs for Samsung DMA Vinod Koul 2011-07-25 10:17 ` Vinod Koul 2011-07-25 11:09 ` Vinod Koul 2011-07-25 11:09 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110725093610.GC9653@n2100.arm.linux.org.uk \ --to=linux@arm.linux.org.uk \ --cc=boojin.kim@samsung.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=dan.j.williams@intel.com \ --cc=grant.likely@secretlab.ca \ --cc=jassisinghbrar@gmail.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.