Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys

From: Greg KH <gregkh@suse.de>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Wanlong Gao <wanlong.gao@gmail.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys
Date: Mon, 25 Jul 2011 23:02:48 -0700	[thread overview]
Message-ID: <20110726060248.GA3868@suse.de> (raw)
In-Reply-To: <4E2E5240.4060309@cn.fujitsu.com>

On Tue, Jul 26, 2011 at 01:36:00PM +0800, Wanlong Gao wrote:
> On 07/26/2011 12:39 PM, Greg KH wrote:
> 
> >>+
> >>+	if (drv->remove) {
> >>+		dev_dbg(_dev, "remove\n");
> >>+		status = drv->remove(dev);
> >>+	} else {
> >>+		status = 0;
> >>+	}
> >
> >Again, why would remove ever be NULL?
> >
> >This whole thing isn't needed at all.
> >
> >greg k-h
> Yeah, I see.
> 
> But Greg, why does i2c-core do this?
> like:drivers/i2c/i2c-core.c:

The i2c core has different requirements than the driver core does,
right?  They are two totally different things, please don't assume that
the rules for one are the same for the other.

greg k-h