From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Greg KH <gregkh@suse.de>
Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wanlong Gao <wanlong.gao@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys
Date: Tue, 26 Jul 2011 09:54:36 +0100 [thread overview]
Message-ID: <20110726085435.GB7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110725232533.GA25994@suse.de>
On Mon, Jul 25, 2011 at 04:25:33PM -0700, Greg KH wrote:
> On Mon, Jul 25, 2011 at 07:26:28PM +0100, Mark Brown wrote:
> > They're asking if drivers should set driver_data to NULL while
> > unbinding, which always struck me as a waste of time given that
> > nothing except a currently bound driver should be using driver_data.
> Yeah, it's not needed, as nothing should rely on that. However it's
> also not hurting anything either.
Every time I see it it always sets off a red flag, partly because we
shouldn't need to bother at all and partly because to the extent it's
valuable it's not something we should be doing on a driver by driver or
even subsystem by subsystem basis.
prev parent reply other threads:[~2011-07-26 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 15:34 [PATCH] drivers:input:set driver data to NULL for pcap_keys Wanlong Gao
2011-07-25 8:30 ` Dmitry Torokhov
2011-07-25 9:14 ` Wanlong Gao
2011-07-25 15:21 ` Greg KH
2011-07-25 15:34 ` Wanlong Gao
2011-07-25 18:19 ` Dmitry Torokhov
2011-07-25 18:29 ` Mark Brown
2011-07-25 18:37 ` Dmitry Torokhov
2011-07-26 1:29 ` Wanlong Gao
2011-07-26 4:39 ` Greg KH
2011-07-26 5:36 ` Wanlong Gao
2011-07-26 6:02 ` Greg KH
2011-07-26 6:25 ` Wanlong Gao
2011-07-26 6:45 ` Dmitry Torokhov
2011-07-26 16:41 ` Greg KH
2011-07-26 17:26 ` Dmitry Torokhov
2011-07-25 18:26 ` Mark Brown
2011-07-25 23:25 ` Greg KH
2011-07-26 8:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726085435.GB7285@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=gregkh@suse.de \
--cc=linux-input@vger.kernel.org \
--cc=wanlong.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.