All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all filesystems
Date: Sat, 30 Jul 2011 10:25:30 -0400	[thread overview]
Message-ID: <20110730142530.GA31200@infradead.org> (raw)
In-Reply-To: <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@giantdisaster.de>

On Fri, Jul 29, 2011 at 06:06:58PM +0200, Stefan Behrens wrote:
> Changed the test 062 to be generic for all filesystems and to be
> executed for all filesystems.
> Remove output of mkfs since this is specific to mkfs.xfs and now
> filtered out.

The first three patches look good, but can you please merge them into
on.  And maybe make the subject description a bit less verbose, e.g.

xfstests: make more tests generic

Use _scratch_mkfs / _scratch_mkfs_sized instead of _scratch_mkfs_xfs
where possible. 


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Stefan Behrens <sbehrens@giantdisaster.de>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all filesystems
Date: Sat, 30 Jul 2011 10:25:30 -0400	[thread overview]
Message-ID: <20110730142530.GA31200@infradead.org> (raw)
In-Reply-To: <95dfa968c48d2bd1095876a6db3369672e76db5f.1311953979.git.sbehrens@giantdisaster.de>

On Fri, Jul 29, 2011 at 06:06:58PM +0200, Stefan Behrens wrote:
> Changed the test 062 to be generic for all filesystems and to be
> executed for all filesystems.
> Remove output of mkfs since this is specific to mkfs.xfs and now
> filtered out.

The first three patches look good, but can you please merge them into
on.  And maybe make the subject description a bit less verbose, e.g.

xfstests: make more tests generic

Use _scratch_mkfs / _scratch_mkfs_sized instead of _scratch_mkfs_xfs
where possible. 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-30 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29 16:06 [PATCH v2 0/4] xfstests: Changed a couple of tests to be generic Stefan Behrens
2011-07-29 16:06 ` Stefan Behrens
2011-07-29 16:06 ` [PATCH v2 1/4] xfstests: Changed test 062 to be generic for all filesystems Stefan Behrens
2011-07-29 16:06   ` Stefan Behrens
2011-07-30 14:25   ` Christoph Hellwig [this message]
2011-07-30 14:25     ` Christoph Hellwig
2011-07-29 16:06 ` [PATCH v2 2/4] xfstests: Changed tests 083, 117, 120 and 192 " Stefan Behrens
2011-07-29 16:06   ` Stefan Behrens
2011-07-29 16:07 ` [PATCH v2 3/4] xfstests: Changed test 015 " Stefan Behrens
2011-07-29 16:07   ` Stefan Behrens
2011-07-29 16:07 ` [PATCH v2 4/4] xfstests: Changed test 079 " Stefan Behrens
2011-07-29 16:07   ` Stefan Behrens
2011-07-30 14:28   ` Christoph Hellwig
2011-07-30 14:28     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110730142530.GA31200@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sbehrens@giantdisaster.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.