From: Arnd Bergmann <arnd@arndb.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
Joerg Roedel <Joerg.Roedel@amd.com>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API
Date: Thu, 18 Aug 2011 15:35:42 +0200 [thread overview]
Message-ID: <201108181535.42339.arnd@arndb.de> (raw)
In-Reply-To: <201108181101.57882.laurent.pinchart@ideasonboard.com>
On Thursday 18 August 2011, Laurent Pinchart wrote:
> > +static int omap_iommu_domain_init(struct iommu_domain *domain)
> > +{
> > + struct omap_iommu_domain *omap_domain;
> > +
> > + omap_domain = kzalloc(sizeof(*omap_domain), GFP_KERNEL);
> > + if (!omap_domain) {
> > + pr_err("kzalloc failed\n");
> > + goto out;
>
> You can directly return -ENOMEM here, and remove the "out:" label.
Risking to get into bike-shedding here, I would comment that the current
code is actually better. I would not mix the two methods of error handling
in one function. If you use goto labels, better use them consistenly and
have only one 'return' statement.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API
Date: Thu, 18 Aug 2011 15:35:42 +0200 [thread overview]
Message-ID: <201108181535.42339.arnd@arndb.de> (raw)
In-Reply-To: <201108181101.57882.laurent.pinchart@ideasonboard.com>
On Thursday 18 August 2011, Laurent Pinchart wrote:
> > +static int omap_iommu_domain_init(struct iommu_domain *domain)
> > +{
> > + struct omap_iommu_domain *omap_domain;
> > +
> > + omap_domain = kzalloc(sizeof(*omap_domain), GFP_KERNEL);
> > + if (!omap_domain) {
> > + pr_err("kzalloc failed\n");
> > + goto out;
>
> You can directly return -ENOMEM here, and remove the "out:" label.
Risking to get into bike-shedding here, I would comment that the current
code is actually better. I would not mix the two methods of error handling
in one function. If you use goto labels, better use them consistenly and
have only one 'return' statement.
Arnd
next prev parent reply other threads:[~2011-08-18 13:35 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 23:10 [PATCH 0/7] omap: iommu migration, relocation and cleanups Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 9:01 ` Laurent Pinchart
2011-08-18 9:01 ` Laurent Pinchart
2011-08-18 9:05 ` Ohad Ben-Cohen
2011-08-18 9:05 ` Ohad Ben-Cohen
2011-08-18 13:35 ` Arnd Bergmann [this message]
2011-08-18 13:35 ` Arnd Bergmann
2011-08-23 14:07 ` Roedel, Joerg
2011-08-23 14:07 ` Roedel, Joerg
2011-08-23 14:59 ` Ohad Ben-Cohen
2011-08-23 14:59 ` Ohad Ben-Cohen
2011-08-24 12:46 ` Ohad Ben-Cohen
2011-08-24 12:46 ` Ohad Ben-Cohen
2011-08-24 13:15 ` Roedel, Joerg
2011-08-24 13:15 ` Roedel, Joerg
2011-08-24 14:46 ` Ohad Ben-Cohen
2011-08-24 14:46 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 2/7] omap: iommu/iovmm: move to dedicated iommu folder Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 13:38 ` Arnd Bergmann
2011-08-18 13:38 ` Arnd Bergmann
2011-08-18 13:53 ` Ohad Ben-Cohen
2011-08-18 13:53 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 3/7] omap: iommu: stop exporting local functions Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 4/7] omap: iommu: PREFETCH_IOTLB cleanup Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 5:27 ` Hiroshi DOYU
2011-08-18 5:27 ` Hiroshi DOYU
2011-08-18 6:33 ` Ohad Ben-Cohen
2011-08-18 6:33 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 5/7] omap: iovmm: remove unused functionality Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 10:19 ` Hiroshi DOYU
2011-08-18 10:19 ` Hiroshi DOYU
2011-08-18 10:23 ` Ohad Ben-Cohen
2011-08-18 10:23 ` Ohad Ben-Cohen
2011-08-18 12:45 ` Hiroshi DOYU
2011-08-18 12:45 ` Hiroshi DOYU
2011-08-17 23:10 ` [PATCH 6/7] omap: iommu: remove unused exported API Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 10:49 ` Hiroshi DOYU
2011-08-18 10:49 ` Hiroshi DOYU
2011-08-18 11:01 ` Ohad Ben-Cohen
2011-08-18 11:01 ` Ohad Ben-Cohen
2011-08-18 13:40 ` David Cohen
2011-08-18 13:40 ` David Cohen
2011-08-18 13:45 ` Ohad Ben-Cohen
2011-08-18 13:45 ` Ohad Ben-Cohen
2011-08-17 23:10 ` [PATCH 7/7] omap: iommu: omapify 'struct iommu' and exposed API Ohad Ben-Cohen
2011-08-17 23:10 ` Ohad Ben-Cohen
2011-08-18 9:12 ` [PATCH 0/7] omap: iommu migration, relocation and cleanups Laurent Pinchart
2011-08-18 9:12 ` Laurent Pinchart
2011-08-18 10:50 ` Hiroshi DOYU
2011-08-18 10:50 ` Hiroshi DOYU
2011-08-23 14:26 ` Roedel, Joerg
2011-08-23 14:26 ` Roedel, Joerg
2011-08-23 15:15 ` Ohad Ben-Cohen
2011-08-23 15:15 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108181535.42339.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Hiroshi.DOYU@nokia.com \
--cc=Joerg.Roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.