From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Darius Augulis
<augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [PATCH REPOST 2/2] i2c-imx: add device tree probe support
Date: Fri, 9 Sep 2011 09:18:45 +0200 [thread overview]
Message-ID: <20110909071845.GI28816@pengutronix.de> (raw)
In-Reply-To: <4E69A0AE.1060004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello Rob,
On Fri, Sep 09, 2011 at 12:14:22AM -0500, Rob Herring wrote:
> > +i2c@83fc4000 { /* I2C2 on i.MX51 */
> > + compatible = "fsl,imx51-i2c", "fsl,imx1-i2c";
> > + reg = <0x83fc4000 0x4000>;
> > + interrupts = <63>;
> > +};
> > +
> > +i2c@70038000 { /* HS-I2C on i.MX51 */
>
> The mainline driver doesn't support the HS-I2C block does it?
>
> The high speed and "old" i2c blocks on MX51 are basically different
> blocks, so the compatible property should be different.
I stumbled about that recently, too and found in
arch/arm/plat-mxc/devices/platform-imx-i2c.c that the third device
description for imx51 is a normal "imx-i2c" one using
MX51_HSI2C_DMA_BASE_ADDR. So I concluded it's different but compatible.
board-mx51_babbage.c uses imx51_add_hsi2c but doesn't add a bus
description. So It might not attract attention if the driver doesn't
match the device.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH REPOST 2/2] i2c-imx: add device tree probe support
Date: Fri, 9 Sep 2011 09:18:45 +0200 [thread overview]
Message-ID: <20110909071845.GI28816@pengutronix.de> (raw)
In-Reply-To: <4E69A0AE.1060004@gmail.com>
Hello Rob,
On Fri, Sep 09, 2011 at 12:14:22AM -0500, Rob Herring wrote:
> > +i2c at 83fc4000 { /* I2C2 on i.MX51 */
> > + compatible = "fsl,imx51-i2c", "fsl,imx1-i2c";
> > + reg = <0x83fc4000 0x4000>;
> > + interrupts = <63>;
> > +};
> > +
> > +i2c at 70038000 { /* HS-I2C on i.MX51 */
>
> The mainline driver doesn't support the HS-I2C block does it?
>
> The high speed and "old" i2c blocks on MX51 are basically different
> blocks, so the compatible property should be different.
I stumbled about that recently, too and found in
arch/arm/plat-mxc/devices/platform-imx-i2c.c that the third device
description for imx51 is a normal "imx-i2c" one using
MX51_HSI2C_DMA_BASE_ADDR. So I concluded it's different but compatible.
board-mx51_babbage.c uses imx51_add_hsi2c but doesn't add a bus
description. So It might not attract attention if the driver doesn't
match the device.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-09-09 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 7:09 [PATCH REPOST v2 0/2] Add device tree probe for i2c-imx driver Shawn Guo
2011-09-08 7:09 ` Shawn Guo
[not found] ` <1315465775-31335-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-08 7:09 ` [PATCH REPOST 1/2] i2c-imx: remove init/exit hooks from platform data Shawn Guo
2011-09-08 7:09 ` Shawn Guo
2011-09-08 7:09 ` [PATCH REPOST 2/2] i2c-imx: add device tree probe support Shawn Guo
2011-09-08 7:09 ` Shawn Guo
[not found] ` <1315465775-31335-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-09-09 5:14 ` Rob Herring
2011-09-09 5:14 ` Rob Herring
[not found] ` <4E69A0AE.1060004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-09-09 7:18 ` Uwe Kleine-König [this message]
2011-09-09 7:18 ` Uwe Kleine-König
[not found] ` <20110909071845.GI28816-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-09-09 11:04 ` Shawn Guo
2011-09-09 11:04 ` Shawn Guo
2011-09-09 11:10 ` Lothar Waßmann
2011-09-09 11:10 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909071845.GI28816@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=augulis.darius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.