From: Jeff Layton <jlayton@redhat.com>
To: "Steven J. Magnani" <steve@digidescorp.com>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.brantley@deshaw.com, hch@infradead.org,
miklos@szeredi.hu, pstaubach@exagrid.com
Subject: Re: [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls
Date: Wed, 11 Jul 2012 15:00:39 -0400 [thread overview]
Message-ID: <20120711150039.08845e85@tlielax.poochiereds.net> (raw)
In-Reply-To: <1342032143.2190.22.camel@iscandar.digidescorp.com>
On Wed, 11 Jul 2012 13:42:23 -0500
"Steven J. Magnani" <steve@digidescorp.com> wrote:
> Jeff -
>
> On Fri, 2012-06-29 at 14:57 -0400, Jeff Layton wrote:
> > This patchset is the third version of the patchset to add ESTALE
> > handling to several syscalls. The basic idea is to allow the client to
> > gracefully retry the lookup and call when a NFS server returns ESTALE.
>
> I exercised this using 3.5-rc5 against a memory-starved server that
> exports a FAT-backed filesystem. Where normally I see lots of ESTALE
> errors due to inode eviction, with this patchset I see none. And, the
> performance is much better than the only other way I know to eliminate
> the errors, which is to mount with 'lookupcache=none'.
>
> It's not an exhaustive test by any means, just a data point for you.
> Thanks!
>
> Lightly-tested-by: Steve Magnani <steve@digidescorp.com>
Awesome -- thanks for testing it.
Yeah "lookupcache=none" has been the standard answer for people
suffering from ESTALE problems, but the perf hit can be quite nasty.
Avoiding that is one of the main drivers for handling ESTALE this way.
With luck, we'll see at least some of this set go in for 3.6.
--
Jeff Layton <jlayton@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Steven J. Magnani" <steve-vU5URLkSDwzJhSu7km37dQ@public.gmane.org>
Cc: viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
michael.brantley-Iq/kdjr4a97QT0dZR+AlfA@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
miklos-sUDqSbJrdHQHWmgEVkV9KA@public.gmane.org,
pstaubach-83r9SdEf25FBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls
Date: Wed, 11 Jul 2012 15:00:39 -0400 [thread overview]
Message-ID: <20120711150039.08845e85@tlielax.poochiereds.net> (raw)
In-Reply-To: <1342032143.2190.22.camel-GF+V7FdoMD4Ycxa7k1C3m3PVXB/TiYYQ@public.gmane.org>
On Wed, 11 Jul 2012 13:42:23 -0500
"Steven J. Magnani" <steve-vU5URLkSDwzJhSu7km37dQ@public.gmane.org> wrote:
> Jeff -
>
> On Fri, 2012-06-29 at 14:57 -0400, Jeff Layton wrote:
> > This patchset is the third version of the patchset to add ESTALE
> > handling to several syscalls. The basic idea is to allow the client to
> > gracefully retry the lookup and call when a NFS server returns ESTALE.
>
> I exercised this using 3.5-rc5 against a memory-starved server that
> exports a FAT-backed filesystem. Where normally I see lots of ESTALE
> errors due to inode eviction, with this patchset I see none. And, the
> performance is much better than the only other way I know to eliminate
> the errors, which is to mount with 'lookupcache=none'.
>
> It's not an exhaustive test by any means, just a data point for you.
> Thanks!
>
> Lightly-tested-by: Steve Magnani <steve-vU5URLkSDwzJhSu7km37dQ@public.gmane.org>
Awesome -- thanks for testing it.
Yeah "lookupcache=none" has been the standard answer for people
suffering from ESTALE problems, but the perf hit can be quite nasty.
Avoiding that is one of the main drivers for handling ESTALE this way.
With luck, we'll see at least some of this set go in for 3.6.
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-11 19:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:57 [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls Jeff Layton
2012-06-29 18:57 ` Jeff Layton
2012-06-29 18:57 ` [PATCH v3 01/17] vfs: add a retry_estale helper function to handle retries on ESTALE Jeff Layton
2012-06-29 18:57 ` [PATCH v3 02/17] vfs: add a kern_path_at function Jeff Layton
2012-06-29 18:57 ` Jeff Layton
2012-06-29 18:57 ` [PATCH v3 03/17] vfs: make fstatat retry on ESTALE errors from getattr call Jeff Layton
2012-06-29 18:57 ` [PATCH v3 04/17] vfs: fix readlinkat to retry on ESTALE Jeff Layton
2012-06-29 18:57 ` [PATCH v3 05/17] vfs: remove user_path_at_empty Jeff Layton
2012-06-29 18:57 ` Jeff Layton
2012-06-29 18:57 ` [PATCH v3 06/17] vfs: turn "empty" arg in getname_flags into a bool Jeff Layton
2012-06-29 18:57 ` [PATCH v3 07/17] vfs: add new "reval" argument to kern_path_create Jeff Layton
2012-06-29 18:57 ` [PATCH v3 08/17] vfs: fix mknodat to retry on ESTALE errors Jeff Layton
2012-06-29 18:57 ` [PATCH v3 09/17] vfs: fix mkdir " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 10/17] vfs: fix symlinkat " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 11/17] vfs: fix linkat " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 12/17] vfs: make rmdir " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 13/17] vfs: make do_unlinkat " Jeff Layton
2012-06-29 18:57 ` Jeff Layton
2012-06-29 18:57 ` [PATCH v3 14/17] vfs: fix renameat to " Jeff Layton
2012-06-29 18:57 ` [PATCH v3 15/17] vfs: remove user_path_parent Jeff Layton
2012-06-29 18:57 ` [PATCH v3 16/17] vfs: have do_sys_truncate retry once on an ESTALE error Jeff Layton
2012-06-29 18:58 ` [PATCH v3 17/17] vfs: have faccessat " Jeff Layton
2012-07-11 18:42 ` [PATCH v3 00/17] vfs: add the ability to retry on ESTALE to several syscalls Steven J. Magnani
2012-07-11 19:00 ` Jeff Layton [this message]
2012-07-11 19:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711150039.08845e85@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=michael.brantley@deshaw.com \
--cc=miklos@szeredi.hu \
--cc=pstaubach@exagrid.com \
--cc=steve@digidescorp.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.