All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: xfs-oss <xfs@oss.sgi.com>, Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Xfstests/254: add more cases for testing btrfs snapshot in 254
Date: Fri, 20 Jul 2012 10:24:33 +1000	[thread overview]
Message-ID: <20120720002433.GH23387@dastard> (raw)
In-Reply-To: <5007E0FB.9040208@cn.fujitsu.com>

On Thu, Jul 19, 2012 at 06:27:07PM +0800, Liu Bo wrote:
> From: Zhou Bo <zhoub-fnst@cn.fujitsu.com>
> 
> This patch adds more cases in 254 for testing btrfs snapshot.
> 
> Signed-off-by: Zhou Bo <zhoub-fnst@cn.fujitsu.com>

I think it is better to create a new test than modify the old one.
That way it is easy to tell the difference between a new failure and
regression.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: Linux Btrfs <linux-btrfs@vger.kernel.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Xfstests/254: add more cases for testing btrfs snapshot in 254
Date: Fri, 20 Jul 2012 10:24:33 +1000	[thread overview]
Message-ID: <20120720002433.GH23387@dastard> (raw)
In-Reply-To: <5007E0FB.9040208@cn.fujitsu.com>

On Thu, Jul 19, 2012 at 06:27:07PM +0800, Liu Bo wrote:
> From: Zhou Bo <zhoub-fnst@cn.fujitsu.com>
> 
> This patch adds more cases in 254 for testing btrfs snapshot.
> 
> Signed-off-by: Zhou Bo <zhoub-fnst@cn.fujitsu.com>

I think it is better to create a new test than modify the old one.
That way it is easy to tell the difference between a new failure and
regression.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-20  0:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19 10:27 [PATCH] Xfstests/254: add more cases for testing btrfs snapshot in 254 Liu Bo
2012-07-19 10:27 ` Liu Bo
2012-07-20  0:24 ` Dave Chinner [this message]
2012-07-20  0:24   ` Dave Chinner
2012-07-20  1:36   ` Liu Bo
2012-07-20  1:36     ` Liu Bo
  -- strict thread matches above, loose matches on Subject: below --
2012-07-19  9:24 Liu Bo
2012-07-19 10:32 ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120720002433.GH23387@dastard \
    --to=david@fromorbit.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=liubo2009@cn.fujitsu.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.