All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Kosina <jkosina@suse.cz>, Jaya Kumar <jayalk@intworks.biz>,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/7] HID: picoLCD updates
Date: Tue, 31 Jul 2012 09:59:09 +0200	[thread overview]
Message-ID: <20120731095909.08d60f70@pluto.restena.lu> (raw)
In-Reply-To: <CANq1E4Tb1Er+O54rN3OteMXqeXAXDr4Z-dvY+RQxZW_NdAfifw@mail.gmail.com>

Hi David,

On Tue, 31 Jul 2012 09:26:07 David Herrmann wrote:
> This is not directly related to this patchset, but did you fix the
> locking issue with hid-core? It is still on my todo-list but I haven't
> gotten around fixing it, yet. However, I plan on fixing it this
> summer, but if picolcd does not require it, it's probably not worth
> the work.

I worked around it with patch 6/7 as in disabling the version check.

The other probing steps don't expect a response from the hardware, thus
are not affected.

But it would definitely be helpful to be able to revert that one.
Understanding and fixing the FB-related misbehavior on quick bind/unbind
seems more important though.


Not related with this, getting a return value from
usbhid_submit_report() as in -EAGAIN or -ENODEV would help in order
to avoid the ugly 
  hid-picolcd 0003:04D8:C002.0003: usb_submit_urb(out) failed: -19
lines in kernel log and stopping interaction with hardware when it's
gone already or giving it time to consume its queue when there is lots
of data being sent.


Regards,
Bruno

WARNING: multiple messages have this Message-ID (diff)
From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Kosina <jkosina@suse.cz>, Jaya Kumar <jayalk@intworks.biz>,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 0/7] HID: picoLCD updates
Date: Tue, 31 Jul 2012 07:59:09 +0000	[thread overview]
Message-ID: <20120731095909.08d60f70@pluto.restena.lu> (raw)
In-Reply-To: <CANq1E4Tb1Er+O54rN3OteMXqeXAXDr4Z-dvY+RQxZW_NdAfifw@mail.gmail.com>

Hi David,

On Tue, 31 Jul 2012 09:26:07 David Herrmann wrote:
> This is not directly related to this patchset, but did you fix the
> locking issue with hid-core? It is still on my todo-list but I haven't
> gotten around fixing it, yet. However, I plan on fixing it this
> summer, but if picolcd does not require it, it's probably not worth
> the work.

I worked around it with patch 6/7 as in disabling the version check.

The other probing steps don't expect a response from the hardware, thus
are not affected.

But it would definitely be helpful to be able to revert that one.
Understanding and fixing the FB-related misbehavior on quick bind/unbind
seems more important though.


Not related with this, getting a return value from
usbhid_submit_report() as in -EAGAIN or -ENODEV would help in order
to avoid the ugly 
  hid-picolcd 0003:04D8:C002.0003: usb_submit_urb(out) failed: -19
lines in kernel log and stopping interaction with hardware when it's
gone already or giving it time to consume its queue when there is lots
of data being sent.


Regards,
Bruno

  reply	other threads:[~2012-07-31  7:59 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 19:36 [PATCH 0/7] HID: picoLCD updates Bruno Prémont
2012-07-30 19:36 ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 1/7] HID: picoLCD: split driver code Bruno Prémont
2012-07-30 19:59   ` Bruno Prémont
2012-07-30 19:59     ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 2/7] HID: picoLCD: Replace own refcounting with fbdev's Bruno Prémont
2012-07-30 19:38   ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 3/7] HID: picoLCD: prevent NULL pointer dereference on unplug Bruno Prémont
2012-07-30 19:38   ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 4/7] HID: picoLCD: satify some checkpatch warnings Bruno Prémont
2012-07-30 19:38   ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 5/7] HID: picoLCD: Improve unplug handling Bruno Prémont
2012-07-30 19:38   ` Bruno Prémont
2012-07-30 19:38 ` [PATCH 6/7] HID: picoLCD: disable version check during probe Bruno Prémont
2012-07-30 19:38   ` Bruno Prémont
2012-08-15  8:15   ` Jiri Kosina
2012-08-15  8:15     ` Jiri Kosina
2012-08-19 16:56     ` [PATCH 6/7 v2] HID: picoLCD: drop " Bruno Prémont
2012-08-19 16:56       ` Bruno Prémont
2012-08-19 16:56       ` Bruno Prémont
2012-09-17 18:21       ` Bruno Prémont
2012-09-17 18:21         ` Bruno Prémont
2012-09-17 18:21         ` Bruno Prémont
2012-09-19 11:45         ` Jiri Kosina
2012-09-19 11:45           ` Jiri Kosina
2012-09-19 11:45           ` Jiri Kosina
2012-07-30 19:39 ` [PATCH 7/7] HID: picoLCD: add myself to MAINTAINERS Bruno Prémont
2012-07-30 19:39   ` Bruno Prémont
2012-07-31  7:26 ` [PATCH 0/7] HID: picoLCD updates David Herrmann
2012-07-31  7:26   ` David Herrmann
2012-07-31  7:26   ` David Herrmann
2012-07-31  7:59   ` Bruno Prémont [this message]
2012-07-31  7:59     ` Bruno Prémont
2012-08-09 18:09 ` Bruno Prémont
2012-08-09 18:09   ` Bruno Prémont
2012-08-13 23:27   ` Tejun Heo
2012-08-13 23:27     ` Tejun Heo
2012-08-13 23:27     ` Tejun Heo
2012-08-14  6:30     ` Bruno Prémont
2012-08-14  6:30       ` Bruno Prémont
2012-08-14  6:30       ` Bruno Prémont
2012-08-14 17:31       ` Tejun Heo
2012-08-14 17:31         ` Tejun Heo
2012-08-14 17:31         ` Tejun Heo
2012-08-15  8:27 ` Jiri Kosina
2012-08-15  8:27   ` Jiri Kosina
2012-08-15  8:27   ` Jiri Kosina
2012-08-15  9:42   ` Bruno Prémont
2012-08-15  9:42     ` Bruno Prémont
2012-08-15  9:42     ` Bruno Prémont
2012-08-15 12:11     ` Jiri Kosina
2012-08-15 12:11       ` Jiri Kosina
2012-08-15 12:11       ` Jiri Kosina
2012-08-15 15:16       ` Bruno Prémont
2012-08-15 15:16         ` Bruno Prémont
2012-08-15 21:32         ` Jiri Kosina
2012-08-15 21:32           ` Jiri Kosina
2012-08-15 21:32           ` Jiri Kosina
2012-08-16 16:30           ` Bruno Prémont
2012-08-16 16:30             ` Bruno Prémont
2012-08-16 16:30             ` Bruno Prémont
2012-08-16 16:47             ` Jiri Kosina
2012-08-16 16:47               ` Jiri Kosina
2012-08-18 12:40               ` Bruno Prémont
2012-08-18 12:40                 ` Bruno Prémont
2012-08-18 13:19                 ` Alan Stern
2012-08-18 13:19                   ` Alan Stern
2012-08-18 13:19                   ` Alan Stern
2012-08-18 13:48                   ` Bruno Prémont
2012-08-18 13:48                     ` Bruno Prémont
2012-08-18 13:48                     ` Bruno Prémont
2012-08-18 18:49                     ` Bruno Prémont
2012-08-18 18:49                       ` Bruno Prémont
2012-08-18 18:49                       ` Bruno Prémont
2012-08-19  0:11                     ` Alan Stern
2012-08-19  0:11                       ` Alan Stern
2012-08-19  0:11                       ` Alan Stern
2012-08-19 16:23                       ` Bruno Prémont
2012-08-19 16:23                         ` Bruno Prémont
2012-08-19 16:23                         ` Bruno Prémont
2012-08-19 19:56                         ` Alan Stern
2012-08-19 19:56                           ` Alan Stern
2012-08-19 19:56                           ` Alan Stern
2012-08-19 17:28 ` [PATCH 0/6] HID: picoLCD additional fixes + CIR support Bruno Prémont
2012-08-19 17:28   ` Bruno Prémont
2012-08-19 17:31   ` [PATCH 1/6] HID: picoLCD: prevent NULL pointer dereferences Bruno Prémont
2012-08-19 17:31     ` Bruno Prémont
2012-08-19 17:32   ` [PATCH 2/6] HID: picoLCD: rework hid-fbdev interaction Bruno Prémont
2012-08-19 17:32     ` Bruno Prémont
2012-08-19 17:32     ` Bruno Prémont
2012-08-19 17:32   ` [PATCH 3/6] HID: picoLCD: Add support for CIR Bruno Prémont
2012-08-19 17:32     ` Bruno Prémont
2012-09-14 14:15     ` Mauro Carvalho Chehab
2012-09-14 14:15       ` Mauro Carvalho Chehab
2012-08-19 17:33   ` [PATCH 4/6] HID: picoLCD: optimize for inactive debugfs Bruno Prémont
2012-08-19 17:33     ` Bruno Prémont
2012-08-19 17:33   ` [PATCH 5/6] HID: picoLCD: fix dumping of IR_DATA report Bruno Prémont
2012-08-19 17:33     ` Bruno Prémont
2012-08-19 17:33   ` [PATCH 6/6] HID: picoLCD: use proper device as input_dev parent Bruno Prémont
2012-08-19 17:33     ` Bruno Prémont
2012-09-05  9:50   ` [PATCH 0/6] HID: picoLCD additional fixes + CIR support Jiri Kosina
2012-09-05  9:50     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731095909.08d60f70@pluto.restena.lu \
    --to=bonbons@linux-vserver.org \
    --cc=dh.herrmann@googlemail.com \
    --cc=jayalk@intworks.biz \
    --cc=jkosina@suse.cz \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.