All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Benoit Cousson <b-cousson@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	devicetree-discuss@lists.ozlabs.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Liam Girdwood <lrg@ti.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH v2 1/9] ARM/ASoC: omap-mcbsp: Move OMAP2+ clock	parenting code to ASoC driver
Date: Mon, 13 Aug 2012 16:35:54 +0100	[thread overview]
Message-ID: <20120813153554.GA31662@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1344867768-26335-2-git-send-email-peter.ujfalusi@ti.com>

On Mon, Aug 13, 2012 at 05:22:40PM +0300, Peter Ujfalusi wrote:
> +	fck_src = clk_get(mcbsp->dev, src);
> +	if (IS_ERR_OR_NULL(fck_src)) {

I know the same error is in the original code, but let's stop propagating
it.  IS_ERR() only here please.

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] ARM/ASoC: omap-mcbsp: Move OMAP2+ clock parenting code to ASoC driver
Date: Mon, 13 Aug 2012 16:35:54 +0100	[thread overview]
Message-ID: <20120813153554.GA31662@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1344867768-26335-2-git-send-email-peter.ujfalusi@ti.com>

On Mon, Aug 13, 2012 at 05:22:40PM +0300, Peter Ujfalusi wrote:
> +	fck_src = clk_get(mcbsp->dev, src);
> +	if (IS_ERR_OR_NULL(fck_src)) {

I know the same error is in the original code, but let's stop propagating
it.  IS_ERR() only here please.

  reply	other threads:[~2012-08-13 15:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 14:22 [PATCH v2 0/9] ARM/ASoC: OMAP McBSP device tree support Peter Ujfalusi
2012-08-13 14:22 ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 1/9] ARM/ASoC: omap-mcbsp: Move OMAP2+ clock parenting code to ASoC driver Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 15:35   ` Russell King - ARM Linux [this message]
2012-08-13 15:35     ` Russell King - ARM Linux
2012-08-14  6:14     ` Peter Ujfalusi
2012-08-14  6:14       ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 2/9] ARM: OMAP: mcbsp: Enable FIFO use for OMAP2430 Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 3/9] ARM: OMAP: board-am3517evm: Configure McBSP1 CLKR/FSR signal source Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 4/9] ASoC: am3517evm: Do not configure McBSP1 CLKR/FSR signal muxing Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 5/9] ARM/ASoC: omap-mcbsp: Remove CLKR/FSR mux configuration code Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 6/9] ASoC: omap-mcbsp: Remove unused defines Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 7/9] ASoC: omap-mcbsp: Remove cpu_is_omap* checks from the code Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 8/9] ARM: OMAP2+: McBSP: Do not create legacy devices when booting with DT data Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi
2012-08-13 14:22 ` [PATCH v2 9/9] ASoC: omap-mcbsp: Add device tree bindings Peter Ujfalusi
2012-08-13 14:22   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120813153554.GA31662@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=b-cousson@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.