Re: [PATCH 01/16] hashtable: introduce a small and naive hashtable

From: NeilBrown <neilb@suse.de>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: torvalds@linux-foundation.org, tj@kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, paul.gortmaker@windriver.com,
	davem@davemloft.net, rostedt@goodmis.org, mingo@elte.hu,
	ebiederm@xmission.com, aarcange@redhat.com, ericvh@gmail.com,
	netdev@vger.kernel.org, josh@joshtriplett.org,
	eric.dumazet@gmail.com, mathieu.desnoyers@efficios.com,
	axboe@kernel.dk, agk@redhat.com, dm-devel@redhat.com,
	ccaulfie@redhat.com, teigland@redhat.com,
	Trond.Myklebust@netapp.com, bfields@fieldses.org,
	fweisbec@gmail.com, jesse@nicira.com,
	venkat.x.venkatsubra@oracle.com, ejt@redhat.com,
	snitzer@redhat.com, edumazet@google.com,
	linux-nfs@vger.kernel.org, dev@openvswitch.org,
	rds-devel@oss.oracle.com, lw@cn.fujitsu.com
Subject: Re: [PATCH 01/16] hashtable: introduce a small and naive hashtable
Date: Wed, 15 Aug 2012 09:25:23 +1000	[thread overview]
Message-ID: <20120815092523.00a909ef@notabene.brown> (raw)
In-Reply-To: <1344961490-4068-2-git-send-email-levinsasha928@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Tue, 14 Aug 2012 18:24:35 +0200 Sasha Levin <levinsasha928@gmail.com>
wrote:

> +static inline void hash_init_size(struct hlist_head *hashtable, int bits)
> +{
> +	int i;
> +
> +	for (i = 0; i < HASH_SIZE(bits); i++)
> +		INIT_HLIST_HEAD(hashtable + i);
> +}

This seems like an inefficient way to do "memset(hashtable, 0, ...);".
And in many cases it isn't needed as the hash table is static and initialised
to zero.
I note that in the SUNRPC/cache patch you call hash_init(), but in the lockd
patch you don't.  You don't actually need to in either case.

I realise that any optimisation here is for code that is only executed once
per boot, so no big deal, and even the presence of extra code making the
kernel bigger is unlikely to be an issue.  But I'd at least like to see
consistency: Either use hash_init everywhere, even when not needed, or only
use it where absolutely needed which might be no-where because static tables
are already initialised, and dynamic tables can use GFP_ZERO.

And if you keep hash_init_size I would rather see a memset(0)....

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]