From: Arnd Bergmann <arnd@arndb.de>
To: Chao Xie <xiechao.mail@gmail.com>
Cc: haojian.zhuang@gmail.com, mturquette@linaro.org,
viresh.linux@gmail.com, s.hauer@pengutronix.de,
chao.xie@marvell.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 3/5] clk: mmp: add clock definition for pxa910
Date: Thu, 16 Aug 2012 08:09:21 +0000 [thread overview]
Message-ID: <201208160809.21662.arnd@arndb.de> (raw)
In-Reply-To: <CADApbej91_Y84sC9R1b0+LgDTzFUH8CveYsDi4wDWOQxkGnnFg@mail.gmail.com>
On Thursday 16 August 2012, Chao Xie wrote:
> >> + clocks[uart0_mux] =
> >> + clk_register_mux(NULL, "uart0_mux", uart_parent,
> >> + ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT,
> >> + apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
> i can change remove the clocks array, but even make the sentence
> shorter, most of them still can not fit in one line.
Don't worry too much about the line length or a particular style. This is
all about readability, and the style you use above may conform to some
written style guide, but it's not the most readable one. If you reformat
it to
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent),
CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent,
ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT,
apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
I still find that more readable.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/5] clk: mmp: add clock definition for pxa910
Date: Thu, 16 Aug 2012 08:09:21 +0000 [thread overview]
Message-ID: <201208160809.21662.arnd@arndb.de> (raw)
In-Reply-To: <CADApbej91_Y84sC9R1b0+LgDTzFUH8CveYsDi4wDWOQxkGnnFg@mail.gmail.com>
On Thursday 16 August 2012, Chao Xie wrote:
> >> + clocks[uart0_mux] =
> >> + clk_register_mux(NULL, "uart0_mux", uart_parent,
> >> + ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT,
> >> + apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
> i can change remove the clocks array, but even make the sentence
> shorter, most of them still can not fit in one line.
Don't worry too much about the line length or a particular style. This is
all about readability, and the style you use above may conform to some
written style guide, but it's not the most readable one. If you reformat
it to
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent, ARRAY_SIZE(uart_parent),
CLK_SET_RATE_PARENT, apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
or
clk = clk_register_mux(NULL, "uart0_mux", uart_parent,
ARRAY_SIZE(uart_parent), CLK_SET_RATE_PARENT,
apbc_base + APBC_UART0, 4, 3, 0, &clk_lock);
I still find that more readable.
Arnd
next prev parent reply other threads:[~2012-08-16 8:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 3:08 [PATCH V3 0/5] clk: mmp: add clock framework for mmp Chao Xie
2012-08-16 3:08 ` Chao Xie
2012-08-16 3:08 ` [PATCH V3 1/5] clk: mmp: add mmp specific clocks Chao Xie
2012-08-16 3:08 ` Chao Xie
2012-08-16 7:18 ` Arnd Bergmann
2012-08-16 7:18 ` Arnd Bergmann
2012-08-16 3:08 ` [PATCH V3 2/5] clk: mmp: add clock definition for pxa168 Chao Xie
2012-08-16 3:08 ` Chao Xie
2012-08-16 3:08 ` [PATCH V3 3/5] clk: mmp: add clock definition for pxa910 Chao Xie
2012-08-16 3:08 ` Chao Xie
2012-08-16 7:17 ` Arnd Bergmann
2012-08-16 7:17 ` Arnd Bergmann
2012-08-16 7:37 ` Chao Xie
2012-08-16 7:37 ` Chao Xie
2012-08-16 8:09 ` Arnd Bergmann [this message]
2012-08-16 8:09 ` Arnd Bergmann
2012-08-16 3:08 ` [PATCH V3 4/5] clk: mmp: add clock definition for mmp2 Chao Xie
2012-08-16 3:08 ` Chao Xie
2012-08-16 3:08 ` [PATCH V3 5/5] arm: mmp: make all SOCs use common clock by default Chao Xie
2012-08-16 3:08 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208160809.21662.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=chao.xie@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=viresh.linux@gmail.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.