From: Shawn Guo <shawn.guo@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Yong Shen <yong.shen@linaro.org>,
Shawn Guo <shawn.guo@freescale.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: imx: select CPU_FREQ_TABLE when needed
Date: Thu, 23 Aug 2012 10:13:21 +0800 [thread overview]
Message-ID: <20120823021318.GC24242@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1345648390-4234-6-git-send-email-arnd@arndb.de>
On Wed, Aug 22, 2012 at 05:13:09PM +0200, Arnd Bergmann wrote:
> The i.MX cpufreq implementation uses the CPU_FREQ_TABLE helpers,
> so it needs to select that code to be built. This problem has
> apparently existed since the i.MX cpufreq code was first merged
> in v3.6.37.
>
s/v3.6.37/v2.6.37?
Otherwise,
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Building IMX without CPU_FREQ_TABLE results in:
>
> arch/arm/plat-mxc/built-in.o: In function `mxc_cpufreq_exit':
> arch/arm/plat-mxc/cpufreq.c:173: undefined reference to `cpufreq_frequency_table_put_attr'
> arch/arm/plat-mxc/built-in.o: In function `mxc_set_target':
> arch/arm/plat-mxc/cpufreq.c:84: undefined reference to `cpufreq_frequency_table_target'
> arch/arm/plat-mxc/built-in.o: In function `mxc_verify_speed':
> arch/arm/plat-mxc/cpufreq.c:65: undefined reference to `cpufreq_frequency_table_verify'
> arch/arm/plat-mxc/built-in.o: In function `mxc_cpufreq_init':
> arch/arm/plat-mxc/cpufreq.c:154: undefined reference to `cpufreq_frequency_table_cpuinfo'
> arch/arm/plat-mxc/cpufreq.c:162: undefined reference to `cpufreq_frequency_table_get_attr'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Yong Shen <yong.shen@linaro.org>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: stable@vger.kernel.org
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e91c7cd..84b5a0c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -2150,6 +2150,7 @@ source "drivers/cpufreq/Kconfig"
> config CPU_FREQ_IMX
> tristate "CPUfreq driver for i.MX CPUs"
> depends on ARCH_MXC && CPU_FREQ
> + select CPU_FREQ_TABLE
> help
> This enables the CPUfreq driver for i.MX CPUs.
>
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: imx: select CPU_FREQ_TABLE when needed
Date: Thu, 23 Aug 2012 10:13:21 +0800 [thread overview]
Message-ID: <20120823021318.GC24242@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1345648390-4234-6-git-send-email-arnd@arndb.de>
On Wed, Aug 22, 2012 at 05:13:09PM +0200, Arnd Bergmann wrote:
> The i.MX cpufreq implementation uses the CPU_FREQ_TABLE helpers,
> so it needs to select that code to be built. This problem has
> apparently existed since the i.MX cpufreq code was first merged
> in v3.6.37.
>
s/v3.6.37/v2.6.37?
Otherwise,
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Building IMX without CPU_FREQ_TABLE results in:
>
> arch/arm/plat-mxc/built-in.o: In function `mxc_cpufreq_exit':
> arch/arm/plat-mxc/cpufreq.c:173: undefined reference to `cpufreq_frequency_table_put_attr'
> arch/arm/plat-mxc/built-in.o: In function `mxc_set_target':
> arch/arm/plat-mxc/cpufreq.c:84: undefined reference to `cpufreq_frequency_table_target'
> arch/arm/plat-mxc/built-in.o: In function `mxc_verify_speed':
> arch/arm/plat-mxc/cpufreq.c:65: undefined reference to `cpufreq_frequency_table_verify'
> arch/arm/plat-mxc/built-in.o: In function `mxc_cpufreq_init':
> arch/arm/plat-mxc/cpufreq.c:154: undefined reference to `cpufreq_frequency_table_cpuinfo'
> arch/arm/plat-mxc/cpufreq.c:162: undefined reference to `cpufreq_frequency_table_get_attr'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Yong Shen <yong.shen@linaro.org>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: stable at vger.kernel.org
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e91c7cd..84b5a0c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -2150,6 +2150,7 @@ source "drivers/cpufreq/Kconfig"
> config CPU_FREQ_IMX
> tristate "CPUfreq driver for i.MX CPUs"
> depends on ARCH_MXC && CPU_FREQ
> + select CPU_FREQ_TABLE
> help
> This enables the CPUfreq driver for i.MX CPUs.
>
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-08-23 2:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 15:13 [PATCH 0/6] ARM: randconfig bugs Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-22 15:13 ` [PATCH 1/6] ARM: ux500: don't select LEDS_GPIO for snowball Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 14:26 ` Arnd Bergmann
2012-08-23 14:26 ` Arnd Bergmann
2012-08-27 23:40 ` Linus Walleij
2012-08-27 23:40 ` Linus Walleij
2012-08-22 15:13 ` [PATCH 2/6] ARM: omap: allow building omap44xx without SMP Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-22 15:36 ` Shilimkar, Santosh
2012-08-22 15:36 ` Shilimkar, Santosh
2012-08-22 17:22 ` Arnd Bergmann
2012-08-22 17:22 ` Arnd Bergmann
2012-08-23 7:05 ` Shilimkar, Santosh
2012-08-23 7:05 ` Shilimkar, Santosh
2012-08-23 12:12 ` Arnd Bergmann
2012-08-23 12:12 ` Arnd Bergmann
2012-08-23 13:00 ` Shilimkar, Santosh
2012-08-23 13:00 ` Shilimkar, Santosh
2012-08-23 13:32 ` Arnd Bergmann
2012-08-23 13:32 ` Arnd Bergmann
2012-08-22 15:13 ` [PATCH 3/6] ARM: imx: build pm-imx5 code only when PM is enabled Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:07 ` Shawn Guo
2012-08-23 2:07 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 4/6] ARM: imx: fix ksz9021rn_phy_fixup Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:10 ` Shawn Guo
2012-08-23 2:10 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 5/6] ARM: imx: select CPU_FREQ_TABLE when needed Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:13 ` Shawn Guo [this message]
2012-08-23 2:13 ` Shawn Guo
2012-08-22 15:13 ` [PATCH 6/6] ARM: imx: select ARM_CPU_SUSPEND when necessary Arnd Bergmann
2012-08-22 15:13 ` Arnd Bergmann
2012-08-23 2:41 ` Shawn Guo
2012-08-23 2:41 ` Shawn Guo
2012-08-23 14:20 ` Arnd Bergmann
2012-08-23 14:20 ` Arnd Bergmann
2012-08-23 14:55 ` Shawn Guo
2012-08-23 14:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823021318.GC24242@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=stable@vger.kernel.org \
--cc=yong.shen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.