From: Sascha Hauer <s.hauer@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
"HACHIMI Samir" <shachimi@adeneo-embedded.com>,
thierry.reding@avionic-design.de, linux-kernel@vger.kernel.org,
"Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Subject: Re: [PATCH 8/9] ARM i.MX53: Add pwms to dtsi
Date: Fri, 31 Aug 2012 15:07:23 +0200 [thread overview]
Message-ID: <20120831130723.GS26594@pengutronix.de> (raw)
In-Reply-To: <20120830223219.GF3613@r65073-Latitude-D630>
On Fri, Aug 31, 2012 at 06:32:20AM +0800, Shawn Guo wrote:
> On Tue, Aug 28, 2012 at 01:48:23PM +0200, Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Conflicts:
> > arch/arm/mach-imx/clk-imx51-imx53.c
>
> Yeah, I know you have sorted out conflicts :)
:)
>
> > ---
> > arch/arm/boot/dts/imx53.dtsi | 14 ++++++++++++++
> > arch/arm/mach-imx/clk-imx51-imx53.c | 4 ++++
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index cd37165..7ec17e4 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -189,6 +189,20 @@
> > status = "disabled";
> > };
> >
> > + pwm1: pwm@53fb4000 {
> > + #pwm-cells = <3>;
>
> pwm-cells should be 2?
Yes, right. We have a patch internally that allows us to pass a
'inverted' flag to the pwm, hence I accidently have 3 here.
> > clk_register_clkdev(clk[ssi1_ipg_gate], NULL, "63fcc000.ssi");
> > clk_register_clkdev(clk[ssi2_ipg_gate], NULL, "50014000.ssi");
> > clk_register_clkdev(clk[ssi3_ipg_gate], NULL, "63fd0000.ssi");
> > + clk_register_clkdev(clk[pwm1_ipg_gate], "ipg", "53fb4000.pwm");
> > + clk_register_clkdev(clk[pwm1_hf_gate], "per", "53fb4000.pwm");
> > + clk_register_clkdev(clk[pwm2_ipg_gate], "ipg", "53fb8000.pwm");
> > + clk_register_clkdev(clk[pwm2_hf_gate], "per", "53fb8000.pwm");
>
> It should be in a separate patch?
Should it? Surely I can do this, I had the feeling though that it
belongs together.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] ARM i.MX53: Add pwms to dtsi
Date: Fri, 31 Aug 2012 15:07:23 +0200 [thread overview]
Message-ID: <20120831130723.GS26594@pengutronix.de> (raw)
In-Reply-To: <20120830223219.GF3613@r65073-Latitude-D630>
On Fri, Aug 31, 2012 at 06:32:20AM +0800, Shawn Guo wrote:
> On Tue, Aug 28, 2012 at 01:48:23PM +0200, Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Conflicts:
> > arch/arm/mach-imx/clk-imx51-imx53.c
>
> Yeah, I know you have sorted out conflicts :)
:)
>
> > ---
> > arch/arm/boot/dts/imx53.dtsi | 14 ++++++++++++++
> > arch/arm/mach-imx/clk-imx51-imx53.c | 4 ++++
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index cd37165..7ec17e4 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -189,6 +189,20 @@
> > status = "disabled";
> > };
> >
> > + pwm1: pwm at 53fb4000 {
> > + #pwm-cells = <3>;
>
> pwm-cells should be 2?
Yes, right. We have a patch internally that allows us to pass a
'inverted' flag to the pwm, hence I accidently have 3 here.
> > clk_register_clkdev(clk[ssi1_ipg_gate], NULL, "63fcc000.ssi");
> > clk_register_clkdev(clk[ssi2_ipg_gate], NULL, "50014000.ssi");
> > clk_register_clkdev(clk[ssi3_ipg_gate], NULL, "63fd0000.ssi");
> > + clk_register_clkdev(clk[pwm1_ipg_gate], "ipg", "53fb4000.pwm");
> > + clk_register_clkdev(clk[pwm1_hf_gate], "per", "53fb4000.pwm");
> > + clk_register_clkdev(clk[pwm2_ipg_gate], "ipg", "53fb8000.pwm");
> > + clk_register_clkdev(clk[pwm2_hf_gate], "per", "53fb8000.pwm");
>
> It should be in a separate patch?
Should it? Surely I can do this, I had the feeling though that it
belongs together.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-08-31 13:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 11:48 i.MX pwm patches Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 1/9] pwm i.MX: factor out SoC specific functions Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 2/9] pwm i.MX: remove unnecessary if in pwm_[en|dis]able Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 3/9] pwm i.MX: add functions to enable/disable pwm Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 4/9] pwm i.MX: Use module_platform_driver Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 5/9] pwm i.MX: add devicetree support Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-30 22:26 ` Shawn Guo
2012-08-30 22:26 ` Shawn Guo
2012-08-28 11:48 ` [PATCH 6/9] pwm i.MX: use per clock unconditionally Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 7/9] pwm i.MX: fix clock lookup Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-28 11:48 ` [PATCH 8/9] ARM i.MX53: Add pwms to dtsi Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-30 22:32 ` Shawn Guo
2012-08-30 22:32 ` Shawn Guo
2012-08-31 13:07 ` Sascha Hauer [this message]
2012-08-31 13:07 ` Sascha Hauer
2012-08-31 0:16 ` Shawn Guo
2012-08-31 0:16 ` Shawn Guo
2012-09-07 13:29 ` Thierry Reding
2012-09-07 13:29 ` Thierry Reding
2012-09-07 17:26 ` Sascha Hauer
2012-09-07 17:26 ` Sascha Hauer
2012-09-07 20:10 ` Thierry Reding
2012-09-07 20:10 ` Thierry Reding
2012-08-28 11:48 ` [PATCH 9/9] pwm i.MX: add devicetree support Sascha Hauer
2012-08-28 11:48 ` Sascha Hauer
2012-08-30 22:28 ` Shawn Guo
2012-08-30 22:28 ` Shawn Guo
2012-08-30 21:45 ` i.MX pwm patches Shawn Guo
2012-08-30 21:45 ` Shawn Guo
2012-08-31 13:05 ` Sascha Hauer
2012-08-31 13:05 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831130723.GS26594@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=benoit.thebaudeau@advansee.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shachimi@adeneo-embedded.com \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.