From: Felipe Balbi <balbi@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Felipe Balbi <balbi@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver
Date: Tue, 4 Sep 2012 14:41:01 +0300 [thread overview]
Message-ID: <20120904114059.GC12901@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120904093142.GB855@harshnoise.musicnaut.iki.fi>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
Hi,
On Tue, Sep 04, 2012 at 12:31:42PM +0300, Aaro Koskinen wrote:
> On Tue, Sep 04, 2012 at 12:05:07PM +0300, Felipe Balbi wrote:
> > > + * CBUS I2C driver for Nokia Internet Tablets.
>
> [...]
>
> > this version misses the entire IRQ handling we already had on linux-omap
> > tree, so it's quite a regression.
>
> There's no interrupts used in plain CBUS protocol/communication I think?
>
> But Retu MFD supports the GPIO IRQ. I added the code for this set. And
> the power button driver (patch 4/4) is using this functionality:
>
> # cat /proc/interrupts
> [...]
> 204: 29 GPIO retu-mfd
> 224: 29 RETU retu-pwrbutton
oops, indeed. My bad. I looked at the wrong patch. Nevermind, this
series looks good to me.
FWIW:
Acked-by: Felipe Balbi <balbi@ti.com>
(for entire series)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-04 11:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 20:23 [PATCH 0/4] cbus/retu drivers to mainline Aaro Koskinen
2012-09-03 20:23 ` [PATCH 1/4] i2c: introduce i2c-cbus driver Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-04 9:05 ` Felipe Balbi
2012-09-04 9:31 ` Aaro Koskinen
2012-09-04 9:31 ` Aaro Koskinen
2012-09-04 11:41 ` Felipe Balbi [this message]
2012-09-13 10:53 ` Wolfram Sang
2012-09-13 14:51 ` Aaro Koskinen
2012-09-13 14:51 ` Aaro Koskinen
2012-09-14 10:08 ` Wolfram Sang
2012-09-14 10:21 ` Jean Delvare
2012-09-14 10:21 ` Jean Delvare
2012-09-14 12:16 ` Felipe Balbi
2012-09-14 12:16 ` Felipe Balbi
2012-09-19 20:08 ` Aaro Koskinen
2012-09-20 10:43 ` Wolfram Sang
2012-09-03 20:23 ` [PATCH 2/4] mfd: introduce retu-mfd driver Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-19 16:02 ` Samuel Ortiz
2012-09-19 20:09 ` Aaro Koskinen
2012-09-03 20:23 ` [PATCH 3/4] watchdog: introduce retu_wdt driver Aaro Koskinen
2012-09-03 20:23 ` [PATCH 4/4] input: misc: introduce retu-pwrbutton Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-04 16:09 ` [PATCH 0/4] cbus/retu drivers to mainline Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904114059.GC12901@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.