From: Felipe Balbi <balbi@ti.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Jean Delvare <khali@linux-fr.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver
Date: Fri, 14 Sep 2012 15:16:55 +0300 [thread overview]
Message-ID: <20120914121652.GC20659@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120914100806.GC2630@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]
On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote:
> On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote:
> > Add i2c driver to enable access to devices behind CBUS on Nokia Internet
> > Tablets.
> >
> > The patch also adds CBUS I2C configuration for N8x0 which is one of the
> > users of this driver.
> >
> > Cc: linux-i2c@vger.kernel.org
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
>
> OK, I found the short paragrahp about CBUS in the I2C spec, so I2C might
> be an appropriate place. Still, before deciding if it should rather be
> in the core directory, I still have a few questions.
>
> Also, does anybody know of a generic bit-banging implementation in the
> kernel which could be used here?
there is i2c-gpio, but it wouldn't help much for cbus, unless we change
it quite a lot. The generic i2c_algo_bit_data would have to be changed
to learn about a 3 wire bus. I guess the impact is much bigger than just
accepting this small, self-contained driver.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/4] i2c: introduce i2c-cbus driver
Date: Fri, 14 Sep 2012 15:16:55 +0300 [thread overview]
Message-ID: <20120914121652.GC20659@arwen.pp.htv.fi> (raw)
In-Reply-To: <20120914100806.GC2630-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote:
> On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote:
> > Add i2c driver to enable access to devices behind CBUS on Nokia Internet
> > Tablets.
> >
> > The patch also adds CBUS I2C configuration for N8x0 which is one of the
> > users of this driver.
> >
> > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
>
> OK, I found the short paragrahp about CBUS in the I2C spec, so I2C might
> be an appropriate place. Still, before deciding if it should rather be
> in the core directory, I still have a few questions.
>
> Also, does anybody know of a generic bit-banging implementation in the
> kernel which could be used here?
there is i2c-gpio, but it wouldn't help much for cbus, unless we change
it quite a lot. The generic i2c_algo_bit_data would have to be changed
to learn about a 3 wire bus. I guess the impact is much bigger than just
accepting this small, self-contained driver.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-14 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 20:23 [PATCH 0/4] cbus/retu drivers to mainline Aaro Koskinen
2012-09-03 20:23 ` [PATCH 1/4] i2c: introduce i2c-cbus driver Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-04 9:05 ` Felipe Balbi
2012-09-04 9:31 ` Aaro Koskinen
2012-09-04 9:31 ` Aaro Koskinen
2012-09-04 11:41 ` Felipe Balbi
2012-09-13 10:53 ` Wolfram Sang
2012-09-13 14:51 ` Aaro Koskinen
2012-09-13 14:51 ` Aaro Koskinen
2012-09-14 10:08 ` Wolfram Sang
2012-09-14 10:21 ` Jean Delvare
2012-09-14 10:21 ` Jean Delvare
2012-09-14 12:16 ` Felipe Balbi [this message]
2012-09-14 12:16 ` Felipe Balbi
2012-09-19 20:08 ` Aaro Koskinen
2012-09-20 10:43 ` Wolfram Sang
2012-09-03 20:23 ` [PATCH 2/4] mfd: introduce retu-mfd driver Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-19 16:02 ` Samuel Ortiz
2012-09-19 20:09 ` Aaro Koskinen
2012-09-03 20:23 ` [PATCH 3/4] watchdog: introduce retu_wdt driver Aaro Koskinen
2012-09-03 20:23 ` [PATCH 4/4] input: misc: introduce retu-pwrbutton Aaro Koskinen
2012-09-03 20:23 ` Aaro Koskinen
2012-09-04 16:09 ` [PATCH 0/4] cbus/retu drivers to mainline Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914121652.GC20659@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.