From: Felipe Balbi <balbi@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
balbi@ti.com
Subject: Re: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox
Date: Fri, 28 Sep 2012 15:59:30 +0300 [thread overview]
Message-ID: <20120928125929.GM31006@arwen.pp.htv.fi> (raw)
In-Reply-To: <1348836795-4783-5-git-send-email-kishon@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]
Hi,
On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote:
> Add an API in the omap glue layer to write to the mailbox register which
> can be used by comparator driver(twl). To pass the detection of the attached
> device (signified by VBUS, ID) to the dwc3 core, dwc3 core has to write
> to the mailbox regiter.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/dwc3/dwc3-omap.c | 59 +++++++++++++++++++++++++++++++++++++++++
> include/linux/usb/dwc3-omap.h | 30 +++++++++++++++++++++
> 2 files changed, 89 insertions(+)
> create mode 100644 include/linux/usb/dwc3-omap.h
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index a1704c6..7ae4d73 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -43,6 +43,7 @@
> #include <linux/spinlock.h>
> #include <linux/platform_device.h>
> #include <linux/platform_data/dwc3-omap.h>
> +#include <linux/usb/dwc3-omap.h>
> #include <linux/pm_runtime.h>
> #include <linux/dma-mapping.h>
> #include <linux/ioport.h>
> @@ -126,6 +127,8 @@ struct dwc3_omap {
> u32 dma_status:1;
> };
>
> +struct dwc3_omap *_omap;
> +
> static inline u32 dwc3_omap_readl(void __iomem *base, u32 offset)
> {
> return readl(base + offset);
> @@ -136,6 +139,56 @@ static inline void dwc3_omap_writel(void __iomem *base, u32 offset, u32 value)
> writel(value, base + offset);
> }
>
> +void omap_dwc3_mailbox(enum omap_dwc3_vbus_id_status status)
all other functions are "dwc3_omap_", let's keep it consistent.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox
Date: Fri, 28 Sep 2012 15:59:30 +0300 [thread overview]
Message-ID: <20120928125929.GM31006@arwen.pp.htv.fi> (raw)
In-Reply-To: <1348836795-4783-5-git-send-email-kishon@ti.com>
Hi,
On Fri, Sep 28, 2012 at 06:23:13PM +0530, Kishon Vijay Abraham I wrote:
> Add an API in the omap glue layer to write to the mailbox register which
> can be used by comparator driver(twl). To pass the detection of the attached
> device (signified by VBUS, ID) to the dwc3 core, dwc3 core has to write
> to the mailbox regiter.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/usb/dwc3/dwc3-omap.c | 59 +++++++++++++++++++++++++++++++++++++++++
> include/linux/usb/dwc3-omap.h | 30 +++++++++++++++++++++
> 2 files changed, 89 insertions(+)
> create mode 100644 include/linux/usb/dwc3-omap.h
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index a1704c6..7ae4d73 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -43,6 +43,7 @@
> #include <linux/spinlock.h>
> #include <linux/platform_device.h>
> #include <linux/platform_data/dwc3-omap.h>
> +#include <linux/usb/dwc3-omap.h>
> #include <linux/pm_runtime.h>
> #include <linux/dma-mapping.h>
> #include <linux/ioport.h>
> @@ -126,6 +127,8 @@ struct dwc3_omap {
> u32 dma_status:1;
> };
>
> +struct dwc3_omap *_omap;
> +
> static inline u32 dwc3_omap_readl(void __iomem *base, u32 offset)
> {
> return readl(base + offset);
> @@ -136,6 +139,56 @@ static inline void dwc3_omap_writel(void __iomem *base, u32 offset, u32 value)
> writel(value, base + offset);
> }
>
> +void omap_dwc3_mailbox(enum omap_dwc3_vbus_id_status status)
all other functions are "dwc3_omap_", let's keep it consistent.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120928/f88dff54/attachment.sig>
next prev parent reply other threads:[~2012-09-28 13:04 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:53 [PATCH 0/6] usb: dwc3-omap: add dt support Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-10-01 8:50 ` Felipe Balbi
2012-10-01 8:50 ` Felipe Balbi
2012-09-28 12:53 ` [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` [PATCH 3/6] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:59 ` Felipe Balbi [this message]
2012-09-28 12:59 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 13:02 ` Felipe Balbi
2012-09-28 13:02 ` Felipe Balbi
2012-09-28 13:32 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:32 ` ABRAHAM, KISHON VIJAY
2012-09-30 16:47 ` Sergei Shtylyov
2012-09-30 16:47 ` Sergei Shtylyov
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928125929.GM31006@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.