From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sasha Levin <levinsasha928@gmail.com>,
virtualization@lists.linux-foundation.org,
Thomas Lendacky <tahm@linux.vnet.ibm.com>,
avi@redhat.com
Subject: Re: [PATCH 0/3] virtio-net: inline header support
Date: Fri, 12 Oct 2012 13:52:58 +0200 [thread overview]
Message-ID: <20121012135258.75ca3310@BR9GNB5Z> (raw)
In-Reply-To: <87wqyw63et.fsf@rustcorp.com.au>
On Fri, 12 Oct 2012 09:07:46 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > On Thu, Oct 11, 2012 at 10:33:31AM +1030, Rusty Russell wrote:
> >> OK. Well, Anthony wants qemu to be robust in this regard, so I am
> >> tempted to rework all the qemu drivers to handle arbitrary layouts.
> >> They could use a good audit anyway.
> >
> > I agree here. Still trying to understand whether we can agree to use
> > a feature bit for this, or not.
>
> I'd *like* to imply it by the new PCI layout, but if it doesn't work
> we'll add a new feature bit.
>
> I'm resisting a feature bit, since it constrains future implementations
> which could otherwise assume it.
>
> >> This would become a glaring exception, but I'm tempted to fix it to 32
> >> bytes at the same time as we get the new pci layout (ie. for the virtio
> >> 1.0 spec).
> >
> > But this isn't a virtio-pci only issue, is it?
> > qemu has s390 bus with same limmitation.
> > How can we tie it to pci layout?
>
> They can use a transport feature if they need to, of course. But
> perhaps the timing with ccw will coincide with the fix, in which they
> don't need to, but it might be a bit late.
>
> Cornelia?
My virtio-ccw host code is still going through a bit of rework, so it
might well go in after the fix.
There's also the existing (non-spec'ed) s390-virtio transport. While it
will likely be deprecated sometime in the future, it should probably
get a feature bit for consistency's sake.
>
> Cheers,
> Rusty.
>
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Sasha Levin <levinsasha928@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
avi@redhat.com, Thomas Lendacky <tahm@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] virtio-net: inline header support
Date: Fri, 12 Oct 2012 13:52:58 +0200 [thread overview]
Message-ID: <20121012135258.75ca3310@BR9GNB5Z> (raw)
In-Reply-To: <87wqyw63et.fsf@rustcorp.com.au>
On Fri, 12 Oct 2012 09:07:46 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > On Thu, Oct 11, 2012 at 10:33:31AM +1030, Rusty Russell wrote:
> >> OK. Well, Anthony wants qemu to be robust in this regard, so I am
> >> tempted to rework all the qemu drivers to handle arbitrary layouts.
> >> They could use a good audit anyway.
> >
> > I agree here. Still trying to understand whether we can agree to use
> > a feature bit for this, or not.
>
> I'd *like* to imply it by the new PCI layout, but if it doesn't work
> we'll add a new feature bit.
>
> I'm resisting a feature bit, since it constrains future implementations
> which could otherwise assume it.
>
> >> This would become a glaring exception, but I'm tempted to fix it to 32
> >> bytes at the same time as we get the new pci layout (ie. for the virtio
> >> 1.0 spec).
> >
> > But this isn't a virtio-pci only issue, is it?
> > qemu has s390 bus with same limmitation.
> > How can we tie it to pci layout?
>
> They can use a transport feature if they need to, of course. But
> perhaps the timing with ccw will coincide with the fix, in which they
> don't need to, but it might be a bit late.
>
> Cornelia?
My virtio-ccw host code is still going through a bit of rework, so it
might well go in after the fix.
There's also the existing (non-spec'ed) s390-virtio transport. While it
will likely be deprecated sometime in the future, it should probably
get a feature bit for consistency's sake.
>
> Cheers,
> Rusty.
>
next prev parent reply other threads:[~2012-10-12 11:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 9:26 [PATCH 0/3] virtio-net: inline header support Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-09-28 9:26 ` [PATCH 1/3] virtio: add API to query ring capacity Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-09-28 9:26 ` [PATCH 2/3] virtio-net: correct capacity math on ring full Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-10-04 0:24 ` Rusty Russell
2012-09-28 9:26 ` [PATCH 3/3] virtio-net: put virtio net header inline with data Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-10-03 6:44 ` [PATCH 0/3] virtio-net: inline header support Rusty Russell
2012-10-03 7:10 ` Rusty Russell
2012-10-04 1:24 ` Anthony Liguori
2012-10-04 3:34 ` Rusty Russell
2012-10-04 4:29 ` Anthony Liguori
2012-10-04 7:44 ` Rusty Russell
2012-10-05 7:47 ` Paolo Bonzini
2012-10-05 7:47 ` Paolo Bonzini
2012-10-08 21:31 ` Michael S. Tsirkin
2012-10-08 21:31 ` Michael S. Tsirkin
2012-10-04 1:35 ` Anthony Liguori
2012-10-04 5:17 ` Rusty Russell
2012-10-08 20:41 ` Michael S. Tsirkin
2012-10-08 20:41 ` Michael S. Tsirkin
2012-10-03 6:44 ` Rusty Russell
2012-10-03 10:53 ` Paolo Bonzini
2012-10-03 10:53 ` Paolo Bonzini
2012-10-04 0:11 ` Rusty Russell
2012-10-04 7:09 ` Paolo Bonzini
2012-10-04 12:51 ` Rusty Russell
2012-10-04 13:23 ` Paolo Bonzini
2012-10-05 5:43 ` Rusty Russell
2012-10-06 12:54 ` Paolo Bonzini
2012-10-06 12:54 ` Paolo Bonzini
2012-10-09 4:59 ` Rusty Russell
2012-10-09 4:59 ` Rusty Russell
2012-10-09 7:27 ` Paolo Bonzini
2012-10-09 7:27 ` Paolo Bonzini
2012-10-11 0:03 ` Rusty Russell
2012-10-11 0:03 ` Rusty Russell
2012-10-11 11:04 ` Michael S. Tsirkin
2012-10-11 11:04 ` Michael S. Tsirkin
2012-10-11 22:37 ` Rusty Russell
2012-10-11 22:37 ` Rusty Russell
2012-10-12 7:38 ` Paolo Bonzini
2012-10-12 7:38 ` Paolo Bonzini
2012-10-12 11:52 ` Cornelia Huck [this message]
2012-10-12 11:52 ` Cornelia Huck
2012-10-05 5:43 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012135258.75ca3310@BR9GNB5Z \
--to=cornelia.huck@de.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tahm@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.