Re: [RFC 2/7] capebus: Add beaglebone board support

From: Tony Lindgren <tony@atomide.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Koen Kooi <koen@dominion.thruhere.net>,
	Matt Porter <mporter@ti.com>, Russ Dill <Russ.Dill@ti.com>,
	linux-omap@vger.kernel.org
Subject: Re: [RFC 2/7] capebus: Add beaglebone board support
Date: Tue, 30 Oct 2012 16:57:15 -0700	[thread overview]
Message-ID: <20121030235714.GB12739@atomide.com> (raw)
In-Reply-To: <DE47929E-9579-4DD2-B01C-08554D49FADE@antoniou-consulting.com>

* Pantelis Antoniou <panto@antoniou-consulting.com> [121030 13:18]:
> On Oct 30, 2012, at 9:39 PM, Tony Lindgren wrote:
> 
> > * Pantelis Antoniou <panto@antoniou-consulting.com> [121030 12:00]:
> >> +
> >> +	priv->lcdc_oh = omap_hwmod_lookup("lcdc");
> >> +	if (priv->lcdc_oh == NULL) {
> >> +		dev_err(&pdev->dev, "Failed to lookup omap_hwmod lcdc\n");
> >> +		return -ENODEV;
> >> +	}
> >> +
> >> +	priv->lcdc_pdev = omap_device_build("da8xx_lcdc", 0, priv->lcdc_oh,
> >> +			&priv->lcd_pdata,
> >> +			sizeof(struct da8xx_lcdc_platform_data),
> >> +			NULL, 0, 0);
> >> +	if (priv->lcdc_pdev == NULL) {
> >> +		dev_err(&pdev->dev, "Failed to build LCDC device\n");
> >> +		return -ENODEV;
> >> +	}
> > 
> > ..and these kind of things need to become private to
> > arch/arm/mach-omap2, we already have it working for other
> > devices with device tree.
> > 
> > Regards,
> > 
> > Tony
> 
> I see,
> 
> I know that if the device driver is DTified it will pick up the hwmod automatically.
> The issue is that the driver is question is not yet; how would I go about
> creating the platform device and having it pick up the hwmod automatically?

Maybe you should make this DT only driver for omap? We already
have am33xx DT only to start with.

If you really need the platform device still, just take a look
at the many platform device creating files under arch/arm/mach-omap2.

Regards,

Tony