Re: [PATCH v2 06/11] HID: hid-multitouch: support T and C for win8 devices

From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/11] HID: hid-multitouch: support T and C for win8 devices
Date: Wed, 31 Oct 2012 19:47:50 +0100	[thread overview]
Message-ID: <20121031184750.GA1740@polaris.bitmath.org> (raw)
In-Reply-To: <CAN+gG=GRd6re056mn_C-UH0r8NgPiH98npxShMe3Ost_dcnzfg@mail.gmail.com>

> >> +                             usage_index) {
> >> +                             hid_map_usage(hi, usage, bit, max,
> >> +                                     EV_ABS, ABS_MT_TOOL_X);
> >> +                             set_abs(hi->input, ABS_MT_TOOL_X, field,
> >> +                                     cls->sn_move);
> >> +                     } else {
> >> +                             hid_map_usage(hi, usage, bit, max,
> >>                                       EV_ABS, ABS_MT_POSITION_X);
> >> -                     set_abs(hi->input, ABS_MT_POSITION_X, field,
> >> -                             cls->sn_move);
> >> +                             set_abs(hi->input, ABS_MT_POSITION_X, field,
> >> +                                     cls->sn_move);
> >> +                     }
> >> +
> >
> > Do we really want to do the latter several times, even if the device is not a win8 one?
> 
> I don't get your point here. The only difference with the previous
> release is that it will treat differently the first in the array than
> the others. For non win8 devices, there is no changes in the behavior.
> Could you elaborate a little bit more, please?

I was wondering what we want to do about multiple reports in the
general casel. Not that important though, the patch will probably look
fine in your next version.

Thanks,
Henrik