From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] OMAP: DSS: panel-n8x0: register the DSS driver after SPI probe
Date: Thu, 22 Nov 2012 15:56:32 +0000 [thread overview]
Message-ID: <20121122155632.GB13187@blackmetal.musicnaut.iki.fi> (raw)
In-Reply-To: <50AE4306.60203@ti.com>
On Thu, Nov 22, 2012 at 05:21:42PM +0200, Tomi Valkeinen wrote:
> On 2012-11-22 17:17, Aaro Koskinen wrote:
> > On Thu, Nov 22, 2012 at 02:18:57PM +0200, Tomi Valkeinen wrote:
> >> On 2012-11-21 21:48, Aaro Koskinen wrote:
> >>> Register the DSS driver after SPI probe. This simplifies the
> >>> initialization. This is similar to what is being done e.g.
> >>> in panel-acx565akm.
> >>
> >> Is this a fix? The description sounds like it's just a cleanup.
> >
> > Yes, it's a cleanup. I should have sent it separately, sorry.
>
> Ok. Did you actually manage to test it?
Yes, the patch works but there are still issues and I can't get the
display yet alive:
[ 4.081390] n8x0_panel display0: invalid s1d1374x revision 00
[ 4.087738] omapfb omapfb: Failed to enable display 'lcd'
[ 4.093475] omapfb omapfb: failed to initialize default display
For some reason all the blizzard_read_reg()s return just zeroes. I have
set up the panel_reset and ctrl_pwrdown GPIOs (30, 15) according to the
Maemo kernel, but maybe there's still more initializations I need to do
from the board file...
> I haven't tested N800 for ages, as I don't have a serial console for
> my N800, and last times I've tried I didn't manage to get it to boot.
It works. I use busybox/dropbear/USB networking to get a "console".
A.
WARNING: multiple messages have this Message-ID (diff)
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] OMAP: DSS: panel-n8x0: register the DSS driver after SPI probe
Date: Thu, 22 Nov 2012 17:56:32 +0200 [thread overview]
Message-ID: <20121122155632.GB13187@blackmetal.musicnaut.iki.fi> (raw)
In-Reply-To: <50AE4306.60203@ti.com>
On Thu, Nov 22, 2012 at 05:21:42PM +0200, Tomi Valkeinen wrote:
> On 2012-11-22 17:17, Aaro Koskinen wrote:
> > On Thu, Nov 22, 2012 at 02:18:57PM +0200, Tomi Valkeinen wrote:
> >> On 2012-11-21 21:48, Aaro Koskinen wrote:
> >>> Register the DSS driver after SPI probe. This simplifies the
> >>> initialization. This is similar to what is being done e.g.
> >>> in panel-acx565akm.
> >>
> >> Is this a fix? The description sounds like it's just a cleanup.
> >
> > Yes, it's a cleanup. I should have sent it separately, sorry.
>
> Ok. Did you actually manage to test it?
Yes, the patch works but there are still issues and I can't get the
display yet alive:
[ 4.081390] n8x0_panel display0: invalid s1d1374x revision 00
[ 4.087738] omapfb omapfb: Failed to enable display 'lcd'
[ 4.093475] omapfb omapfb: failed to initialize default display
For some reason all the blizzard_read_reg()s return just zeroes. I have
set up the panel_reset and ctrl_pwrdown GPIOs (30, 15) according to the
Maemo kernel, but maybe there's still more initializations I need to do
from the board file...
> I haven't tested N800 for ages, as I don't have a serial console for
> my N800, and last times I've tried I didn't manage to get it to boot.
It works. I use busybox/dropbear/USB networking to get a "console".
A.
next prev parent reply other threads:[~2012-11-22 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 19:48 [PATCH 1/2] OMAP: DSS: do not fail if dpll4_m4_ck is missing Aaro Koskinen
2012-11-21 19:48 ` Aaro Koskinen
2012-11-21 19:48 ` [PATCH 2/2] OMAP: DSS: panel-n8x0: register the DSS driver after SPI probe Aaro Koskinen
2012-11-21 19:48 ` Aaro Koskinen
2012-11-22 12:18 ` Tomi Valkeinen
2012-11-22 12:18 ` Tomi Valkeinen
2012-11-22 15:17 ` Aaro Koskinen
2012-11-22 15:17 ` Aaro Koskinen
2012-11-22 15:21 ` Tomi Valkeinen
2012-11-22 15:21 ` Tomi Valkeinen
2012-11-22 15:56 ` Aaro Koskinen [this message]
2012-11-22 15:56 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122155632.GB13187@blackmetal.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.