From: Sam Ravnborg <sam@ravnborg.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Jim Cromie <jim.cromie@gmail.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Michal Marek <mmarek@suse.cz>,
Tony Lindgren <tony@atomide.com>,
Jonathan Kliegman <kliegs@chromium.org>,
Chris Zankel <chris@zankel.net>,
Bill Pemberton <wfp5p@viridian.itc.virginia.edu>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/2] init.h: Remove __dev* sections from the kernel
Date: Fri, 30 Nov 2012 19:11:56 +0100 [thread overview]
Message-ID: <20121130181156.GA18287@merkur.ravnborg.org> (raw)
In-Reply-To: <20121129184328.GB15110@kroah.com>
On Thu, Nov 29, 2012 at 10:43:28AM -0800, Greg Kroah-Hartman wrote:
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> With the recent work to remove CONFIG_HOTPLUG, we are starting to get a
> bunch of __devinit section warnings, despite CONFIG_HOTPLUG always being
> enabled. So, stop marking the sections entirely, by defining them away
> the section markings in init.h
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> ---
> include/linux/init.h | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/init.h b/include/linux/init.h
> index e59041e..f63692d 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -93,13 +93,13 @@
>
> #define __exit __section(.exit.text) __exitused __cold notrace
>
> -/* Used for HOTPLUG */
> -#define __devinit __section(.devinit.text) __cold notrace
> -#define __devinitdata __section(.devinit.data)
> -#define __devinitconst __constsection(.devinit.rodata)
> -#define __devexit __section(.devexit.text) __exitused __cold notrace
> -#define __devexitdata __section(.devexit.data)
> -#define __devexitconst __constsection(.devexit.rodata)
> +/* Used for HOTPLUG, but that is always enabled now, so just make them noops */
This comment should be explicit that these are provided only for backward compatibility
and their usage is discouarged.
Sam
next prev parent reply other threads:[~2012-11-30 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 18:41 [PATCH 0/2] Remove __dev* sections from the kernel Greg Kroah-Hartman
2012-11-29 18:43 ` [PATCH 1/2] init.h: " Greg Kroah-Hartman
2012-11-29 18:45 ` [PATCH 1/2] modpost.c: Stop checking __dev* section mismatches Greg Kroah-Hartman
2012-11-30 18:13 ` Sam Ravnborg
2012-11-30 18:11 ` Sam Ravnborg [this message]
2012-11-30 18:28 ` [PATCH 1/2] init.h: Remove __dev* sections from the kernel Greg Kroah-Hartman
2012-11-30 20:39 ` H. Peter Anvin
2012-11-30 20:43 ` Bill Pemberton
2012-11-30 20:43 ` Bill Pemberton
2012-11-30 20:45 ` Greg Kroah-Hartman
2012-11-30 20:39 ` H. Peter Anvin
2012-11-30 20:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130181156.GA18287@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=chris@zankel.net \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jim.cromie@gmail.com \
--cc=kliegs@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=tony@atomide.com \
--cc=wfp5p@viridian.itc.virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.