From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Jim Cromie <jim.cromie@gmail.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Michal Marek <mmarek@suse.cz>,
Tony Lindgren <tony@atomide.com>,
Jonathan Kliegman <kliegs@chromium.org>,
Chris Zankel <chris@zankel.net>,
Bill Pemberton <wfp5p@viridian.itc.virginia.edu>,
Fengguang Wu <fengguang.wu@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 1/2] init.h: Remove __dev* sections from the kernel
Date: Fri, 30 Nov 2012 12:47:36 -0800 [thread overview]
Message-ID: <20121130204736.GB32483@kroah.com> (raw)
In-Reply-To: <50B9198F.7050806@zytor.com>
On Fri, Nov 30, 2012 at 12:39:43PM -0800, H. Peter Anvin wrote:
> On 11/29/2012 10:43 AM, Greg Kroah-Hartman wrote:
> >
> >-/* Used for HOTPLUG */
> >-#define __devinit __section(.devinit.text) __cold notrace
> >-#define __devinitdata __section(.devinit.data)
> >-#define __devinitconst __constsection(.devinit.rodata)
> >-#define __devexit __section(.devexit.text) __exitused __cold notrace
> >-#define __devexitdata __section(.devexit.data)
> >-#define __devexitconst __constsection(.devexit.rodata)
> >+/* Used for HOTPLUG, but that is always enabled now, so just make them noops */
> >+#define __devinit
> >+#define __devinitdata
> >+#define __devinitconst
> >+#define __devexit
> >+#define __devexitdata
> >+#define __devexitconst
> >
>
> Second question... what about the __exitused __cold notrace annotations?
__exitused shouldn't matter, we shouldn't be optimizing these away at
all anymore. I don't know about __cold and notrace, but given that
these could be traced, I don't see why that marking got there in the
first place.
In reading compiler-gcc4.h, and knowing just how infrequent these
functions are ever called, I would be amazed if the __cold marking ever
even helped anything out here.
thanks,
greg k-h
prev parent reply other threads:[~2012-11-30 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 18:41 [PATCH 0/2] Remove __dev* sections from the kernel Greg Kroah-Hartman
2012-11-29 18:43 ` [PATCH 1/2] init.h: " Greg Kroah-Hartman
2012-11-29 18:45 ` [PATCH 1/2] modpost.c: Stop checking __dev* section mismatches Greg Kroah-Hartman
2012-11-30 18:13 ` Sam Ravnborg
2012-11-30 18:11 ` [PATCH 1/2] init.h: Remove __dev* sections from the kernel Sam Ravnborg
2012-11-30 18:28 ` Greg Kroah-Hartman
2012-11-30 20:39 ` H. Peter Anvin
2012-11-30 20:43 ` Bill Pemberton
2012-11-30 20:43 ` Bill Pemberton
2012-11-30 20:45 ` Greg Kroah-Hartman
2012-11-30 20:39 ` H. Peter Anvin
2012-11-30 20:47 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130204736.GB32483@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=chris@zankel.net \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=jim.cromie@gmail.com \
--cc=kliegs@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=tony@atomide.com \
--cc=wfp5p@viridian.itc.virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.