From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: jasowang@redhat.com, krkumar2@in.ibm.com, kvm@vger.kernel.org,
mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr,
shiyer@redhat.com
Subject: Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net
Date: Fri, 7 Dec 2012 15:13:30 -0800 [thread overview]
Message-ID: <20121207151330.3cd111a4@samsung-9> (raw)
In-Reply-To: <20121207.153556.989159003987459765.davem@davemloft.net>
On Fri, 07 Dec 2012 15:35:56 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Sat, 8 Dec 2012 01:04:54 +0800
>
> > This series is an update version (hope the final version) of multiqueue
> > (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were
> > addressed, the work were based on Krishna Kumar's work to let virtio-net use
> > multiple rx/tx queues to do the packets reception and transmission. Performance
> > test show the aggregate latency were increased greately but may get some
> > regression in small packet transmission. Due to this, multiqueue were disabled
> > by default. If user want to benefit form the multiqueue, ethtool -L could be
> > used to enable the feature.
> >
> > Please review and comments.
> >
> > A protype implementation of qemu-kvm support could by found in
> > git://github.com/jasowang/qemu-kvm-mq.git. To start a guest with two queues, you
> > could specify the queues parameters to both tap and virtio-net like:
> >
> > ./qemu-kvm -netdev tap,queues=2,... -device virtio-net-pci,queues=2,...
> >
> > then enable the multiqueue through ethtool by:
> >
> > ethtool -L eth0 combined 2
>
> It seems like most, if not all, of the feedback given for this series
> has been addressed by Jason.
>
> Can I get some ACKs?
Other than the minor style nit in the first patch, I see no issues.
This is really needed by Virtual Routers.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
bhutchings@solarflare.com, jwhan@filewood.snu.ac.kr,
shiyer@redhat.com
Subject: Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net
Date: Fri, 7 Dec 2012 15:13:30 -0800 [thread overview]
Message-ID: <20121207151330.3cd111a4@samsung-9> (raw)
In-Reply-To: <20121207.153556.989159003987459765.davem@davemloft.net>
On Fri, 07 Dec 2012 15:35:56 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Sat, 8 Dec 2012 01:04:54 +0800
>
> > This series is an update version (hope the final version) of multiqueue
> > (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were
> > addressed, the work were based on Krishna Kumar's work to let virtio-net use
> > multiple rx/tx queues to do the packets reception and transmission. Performance
> > test show the aggregate latency were increased greately but may get some
> > regression in small packet transmission. Due to this, multiqueue were disabled
> > by default. If user want to benefit form the multiqueue, ethtool -L could be
> > used to enable the feature.
> >
> > Please review and comments.
> >
> > A protype implementation of qemu-kvm support could by found in
> > git://github.com/jasowang/qemu-kvm-mq.git. To start a guest with two queues, you
> > could specify the queues parameters to both tap and virtio-net like:
> >
> > ./qemu-kvm -netdev tap,queues=2,... -device virtio-net-pci,queues=2,...
> >
> > then enable the multiqueue through ethtool by:
> >
> > ethtool -L eth0 combined 2
>
> It seems like most, if not all, of the feedback given for this series
> has been addressed by Jason.
>
> Can I get some ACKs?
Other than the minor style nit in the first patch, I see no issues.
This is really needed by Virtual Routers.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2012-12-07 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 17:04 [PATCH net-next v3 0/3] Multiqueue support in virtio-net Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 17:04 ` [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 23:11 ` Stephen Hemminger
2012-12-07 23:11 ` Stephen Hemminger
2012-12-07 17:04 ` [PATCH net-next v3 2/3] virtio_net: multiqueue support Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 17:04 ` [PATCH net-next v3 3/3] virtio-net: support changing the number of queue pairs through ethtool Jason Wang
2012-12-07 17:04 ` Jason Wang
2012-12-07 20:35 ` [PATCH net-next v3 0/3] Multiqueue support in virtio-net David Miller
2012-12-07 20:35 ` David Miller
2012-12-07 23:13 ` Stephen Hemminger [this message]
2012-12-07 23:13 ` Stephen Hemminger
2012-12-09 5:32 ` David Miller
2012-12-09 5:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207151330.3cd111a4@samsung-9 \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shiyer@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.