From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org,
mprivozn@redhat.com, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, stefanha@redhat.com,
jwhan@filewood.snu.ac.kr, shiyer@redhat.com
Subject: Re: [PATCH 07/12] virtio: introduce virtio_queue_del()
Date: Tue, 8 Jan 2013 09:14:39 +0200 [thread overview]
Message-ID: <20130108071439.GJ11305@redhat.com> (raw)
In-Reply-To: <1356690724-37891-8-git-send-email-jasowang@redhat.com>
On Fri, Dec 28, 2012 at 06:31:59PM +0800, Jason Wang wrote:
> Some device (such as virtio-net) needs the ability to destroy or re-order the
> virtqueues, this patch adds a helper to do this.
>
> Signed-off-by: Jason Wang <jasowang>
Actually del_queue unlike what the subject says :)
> ---
> hw/virtio.c | 9 +++++++++
> hw/virtio.h | 2 ++
> 2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio.c b/hw/virtio.c
> index f40a8c5..bc3c9c3 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -700,6 +700,15 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
> return &vdev->vq[i];
> }
>
> +void virtio_del_queue(VirtIODevice *vdev, int n)
> +{
> + if (n < 0 || n >= VIRTIO_PCI_QUEUE_MAX) {
> + abort();
> + }
> +
> + vdev->vq[n].vring.num = 0;
> +}
> +
> void virtio_irq(VirtQueue *vq)
> {
> trace_virtio_irq(vq);
> diff --git a/hw/virtio.h b/hw/virtio.h
> index 7c17f7b..f6cb0f9 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -138,6 +138,8 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
> void (*handle_output)(VirtIODevice *,
> VirtQueue *));
>
> +void virtio_del_queue(VirtIODevice *vdev, int n);
> +
> void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem,
> unsigned int len);
> void virtqueue_flush(VirtQueue *vq, unsigned int count);
> --
> 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: krkumar2@in.ibm.com, aliguori@us.ibm.com, kvm@vger.kernel.org,
mprivozn@redhat.com, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, stefanha@redhat.com,
jwhan@filewood.snu.ac.kr, shiyer@redhat.com
Subject: Re: [Qemu-devel] [PATCH 07/12] virtio: introduce virtio_queue_del()
Date: Tue, 8 Jan 2013 09:14:39 +0200 [thread overview]
Message-ID: <20130108071439.GJ11305@redhat.com> (raw)
In-Reply-To: <1356690724-37891-8-git-send-email-jasowang@redhat.com>
On Fri, Dec 28, 2012 at 06:31:59PM +0800, Jason Wang wrote:
> Some device (such as virtio-net) needs the ability to destroy or re-order the
> virtqueues, this patch adds a helper to do this.
>
> Signed-off-by: Jason Wang <jasowang>
Actually del_queue unlike what the subject says :)
> ---
> hw/virtio.c | 9 +++++++++
> hw/virtio.h | 2 ++
> 2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio.c b/hw/virtio.c
> index f40a8c5..bc3c9c3 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -700,6 +700,15 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
> return &vdev->vq[i];
> }
>
> +void virtio_del_queue(VirtIODevice *vdev, int n)
> +{
> + if (n < 0 || n >= VIRTIO_PCI_QUEUE_MAX) {
> + abort();
> + }
> +
> + vdev->vq[n].vring.num = 0;
> +}
> +
> void virtio_irq(VirtQueue *vq)
> {
> trace_virtio_irq(vq);
> diff --git a/hw/virtio.h b/hw/virtio.h
> index 7c17f7b..f6cb0f9 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -138,6 +138,8 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
> void (*handle_output)(VirtIODevice *,
> VirtQueue *));
>
> +void virtio_del_queue(VirtIODevice *vdev, int n);
> +
> void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem,
> unsigned int len);
> void virtqueue_flush(VirtQueue *vq, unsigned int count);
> --
> 1.7.1
next prev parent reply other threads:[~2013-01-08 7:14 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 10:31 [PATCH 00/12] Multiqueue virtio-net Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 01/12] tap: multiqueue support Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2013-01-09 9:56 ` Stefan Hajnoczi
2013-01-09 9:56 ` [Qemu-devel] " Stefan Hajnoczi
2013-01-09 15:25 ` Jason Wang
2013-01-09 15:25 ` [Qemu-devel] " Jason Wang
2013-01-10 8:32 ` Stefan Hajnoczi
2013-01-10 8:32 ` [Qemu-devel] " Stefan Hajnoczi
2013-01-10 10:28 ` Stefan Hajnoczi
2013-01-10 10:28 ` [Qemu-devel] " Stefan Hajnoczi
2013-01-10 13:52 ` Jason Wang
2013-01-10 13:52 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 02/12] net: introduce qemu_get_queue() Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 03/12] net: introduce qemu_get_nic() Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 04/12] net: intorduce qemu_del_nic() Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 05/12] net: multiqueue support Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 18:06 ` Blue Swirl
2012-12-28 18:06 ` [Qemu-devel] " Blue Swirl
2012-12-28 10:31 ` [PATCH 06/12] vhost: " Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2012-12-28 10:31 ` [PATCH 07/12] virtio: introduce virtio_queue_del() Jason Wang
2012-12-28 10:31 ` [Qemu-devel] " Jason Wang
2013-01-08 7:14 ` Michael S. Tsirkin [this message]
2013-01-08 7:14 ` Michael S. Tsirkin
2013-01-08 9:28 ` Jason Wang
2013-01-08 9:28 ` [Qemu-devel] " Jason Wang
2012-12-28 10:32 ` [PATCH 08/12] virtio: add a queue_index to VirtQueue Jason Wang
2012-12-28 10:32 ` [Qemu-devel] " Jason Wang
2012-12-28 10:32 ` [PATCH 09/12] virtio-net: separate virtqueue from VirtIONet Jason Wang
2012-12-28 10:32 ` [Qemu-devel] " Jason Wang
2012-12-28 10:32 ` [PATCH 10/12] virtio-net: multiqueue support Jason Wang
2012-12-28 10:32 ` [Qemu-devel] " Jason Wang
2012-12-28 17:52 ` Blue Swirl
2012-12-28 17:52 ` [Qemu-devel] " Blue Swirl
2013-01-04 5:12 ` Jason Wang
2013-01-04 5:12 ` [Qemu-devel] " Jason Wang
2013-01-04 20:41 ` Blue Swirl
2013-01-04 20:41 ` [Qemu-devel] " Blue Swirl
2013-01-08 9:07 ` Wanlong Gao
2013-01-08 9:07 ` Wanlong Gao
2013-01-08 9:29 ` Jason Wang
2013-01-08 9:29 ` [Qemu-devel] " Jason Wang
2013-01-08 9:32 ` Wanlong Gao
2013-01-08 9:32 ` Wanlong Gao
2013-01-08 9:49 ` Wanlong Gao
2013-01-08 9:49 ` Wanlong Gao
2013-01-08 9:51 ` Jason Wang
2013-01-08 9:51 ` [Qemu-devel] " Jason Wang
2013-01-08 10:00 ` Wanlong Gao
2013-01-08 10:14 ` Jason Wang
2013-01-08 10:14 ` [Qemu-devel] " Jason Wang
2013-01-08 11:24 ` Wanlong Gao
2013-01-09 3:11 ` Jason Wang
2013-01-09 8:23 ` Wanlong Gao
2013-01-09 9:30 ` Jason Wang
2013-01-09 9:30 ` [Qemu-devel] " Jason Wang
2013-01-09 10:01 ` Wanlong Gao
2013-01-09 10:01 ` Wanlong Gao
2013-01-09 15:26 ` Jason Wang
2013-01-10 6:43 ` Jason Wang
2013-01-10 6:49 ` Wanlong Gao
2013-01-10 6:49 ` Wanlong Gao
2013-01-10 7:16 ` Jason Wang
2013-01-10 7:16 ` [Qemu-devel] " Jason Wang
2013-01-10 9:06 ` Wanlong Gao
2013-01-10 9:06 ` [Qemu-devel] " Wanlong Gao
2013-01-10 9:40 ` Jason Wang
2012-12-28 10:32 ` [PATCH 11/12] virtio-net: migration support for multiqueue Jason Wang
2012-12-28 10:32 ` [Qemu-devel] " Jason Wang
2013-01-08 7:10 ` Michael S. Tsirkin
2013-01-08 7:10 ` [Qemu-devel] " Michael S. Tsirkin
2013-01-08 9:27 ` Jason Wang
2013-01-08 9:27 ` [Qemu-devel] " Jason Wang
2012-12-28 10:32 ` [PATCH 12/12] virtio-net: compat multiqueue support Jason Wang
2012-12-28 10:32 ` [Qemu-devel] " Jason Wang
2013-01-09 14:29 ` [Qemu-devel] [PATCH 00/12] Multiqueue virtio-net Stefan Hajnoczi
2013-01-09 14:29 ` Stefan Hajnoczi
2013-01-09 15:32 ` Michael S. Tsirkin
2013-01-09 15:32 ` Michael S. Tsirkin
2013-01-09 15:33 ` Jason Wang
2013-01-09 15:33 ` [Qemu-devel] " Jason Wang
2013-01-10 8:44 ` Stefan Hajnoczi
2013-01-10 8:44 ` [Qemu-devel] " Stefan Hajnoczi
2013-01-10 9:34 ` Jason Wang
2013-01-10 9:34 ` Jason Wang
2013-01-10 11:49 ` Stefan Hajnoczi
2013-01-10 11:49 ` Stefan Hajnoczi
2013-01-10 14:15 ` Jason Wang
2013-01-10 14:15 ` [Qemu-devel] " Jason Wang
2013-01-14 19:44 ` Anthony Liguori
2013-01-14 19:44 ` [Qemu-devel] " Anthony Liguori
2013-01-15 10:12 ` Jason Wang
2013-01-15 10:12 ` [Qemu-devel] " Jason Wang
2013-01-16 15:09 ` Anthony Liguori
2013-01-16 15:09 ` [Qemu-devel] " Anthony Liguori
2013-01-16 15:19 ` Michael S. Tsirkin
2013-01-16 15:19 ` [Qemu-devel] " Michael S. Tsirkin
2013-01-16 16:14 ` Anthony Liguori
2013-01-16 16:14 ` [Qemu-devel] " Anthony Liguori
2013-01-16 16:48 ` Michael S. Tsirkin
2013-01-16 16:48 ` [Qemu-devel] " Michael S. Tsirkin
2013-01-17 10:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130108071439.GJ11305@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jasowang@redhat.com \
--cc=jwhan@filewood.snu.ac.kr \
--cc=krkumar2@in.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=shiyer@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.