From: Felipe Balbi <balbi@ti.com> To: Santosh Shilimkar <santosh.shilimkar@ti.com> Cc: linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] ARM: OMAP5: Update SOC id detection code for ES2 Date: Wed, 20 Feb 2013 17:29:40 +0200 [thread overview] Message-ID: <20130220152940.GE16652@arwen.pp.htv.fi> (raw) In-Reply-To: <1361374034-21831-2-git-send-email-santosh.shilimkar@ti.com> [-- Attachment #1: Type: text/plain, Size: 786 bytes --] Hi, On Wed, Feb 20, 2013 at 08:57:07PM +0530, Santosh Shilimkar wrote: > case 0xb998: > switch (rev) { > case 0: > - default: > omap_revision = OMAP5432_REV_ES1_0; > + break; > + case 1: > + omap_revision = OMAP5432_REV_ES2_0; > + break; > + default: > + omap_revision = OMAP5432_REV_ES2_0; no need for the duplication: + case 1: + default: + omap_revision = OMAP5432_REV_ES2_0; will work just fine. > } > break; > > default: > /* Unknown default to latest silicon rev as default*/ > - omap_revision = OMAP5430_REV_ES1_0; > + omap_revision = OMAP5430_REV_ES2_0; how about we default to 0xffffffff ? That's the highest possible version, just not sure if our revision macros can cope with it. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/8] ARM: OMAP5: Update SOC id detection code for ES2 Date: Wed, 20 Feb 2013 17:29:40 +0200 [thread overview] Message-ID: <20130220152940.GE16652@arwen.pp.htv.fi> (raw) In-Reply-To: <1361374034-21831-2-git-send-email-santosh.shilimkar@ti.com> Hi, On Wed, Feb 20, 2013 at 08:57:07PM +0530, Santosh Shilimkar wrote: > case 0xb998: > switch (rev) { > case 0: > - default: > omap_revision = OMAP5432_REV_ES1_0; > + break; > + case 1: > + omap_revision = OMAP5432_REV_ES2_0; > + break; > + default: > + omap_revision = OMAP5432_REV_ES2_0; no need for the duplication: + case 1: + default: + omap_revision = OMAP5432_REV_ES2_0; will work just fine. > } > break; > > default: > /* Unknown default to latest silicon rev as default*/ > - omap_revision = OMAP5430_REV_ES1_0; > + omap_revision = OMAP5430_REV_ES2_0; how about we default to 0xffffffff ? That's the highest possible version, just not sure if our revision macros can cope with it. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130220/9913146e/attachment.sig>
next prev parent reply other threads:[~2013-02-20 15:29 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-20 15:27 [PATCH 0/8] ARM: OMAP5: Few updates discovered with es2.0 Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 1/8] ARM: OMAP5: Update SOC id detection code for ES2 Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:29 ` Felipe Balbi [this message] 2013-02-20 15:29 ` Felipe Balbi 2013-02-20 16:03 ` Santosh Shilimkar 2013-02-20 16:03 ` Santosh Shilimkar 2013-02-20 16:27 ` Felipe Balbi 2013-02-20 16:27 ` Felipe Balbi 2013-02-20 16:31 ` Santosh Shilimkar 2013-02-20 16:31 ` Santosh Shilimkar 2013-02-20 16:32 ` Felipe Balbi 2013-02-20 16:32 ` Felipe Balbi 2013-02-20 15:27 ` [PATCH 2/8] ARM: OMAP5: timer: Update the clocksource name as per clock data Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-21 12:52 ` Sergei Shtylyov 2013-02-21 12:52 ` Sergei Shtylyov 2013-02-21 12:57 ` Santosh Shilimkar 2013-02-21 12:57 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 3/8] ARM: OMAP5: prm: Allow prm init to success on OMAP5 SOCs Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:30 ` Felipe Balbi 2013-02-20 15:30 ` Felipe Balbi 2013-02-21 12:50 ` Sergei Shtylyov 2013-02-21 12:50 ` Sergei Shtylyov 2013-02-20 15:27 ` [PATCH 4/8] ARM: OMAP5: Reuse prm read_inst/write_inst Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 5/8] ARM: OMAP5: Update SAR RAM base address Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 6/8] ARM: OMAP5: Update SAR memory layout for WakeupGen Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 7/8] ARM: OMAP5: Make errata i688 workaround available Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-02-20 15:27 ` [PATCH 8/8] ARM: OMAP5: clock: No Freqsel on OMAP5 devices Santosh Shilimkar 2013-02-20 15:27 ` Santosh Shilimkar 2013-03-15 8:39 ` Santosh Shilimkar 2013-03-15 8:39 ` Santosh Shilimkar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130220152940.GE16652@arwen.pp.htv.fi \ --to=balbi@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=santosh.shilimkar@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.