Re: [PATCH 0/3] crypto: sahara: Add support for SAHARA in i.MX27.

From: Sascha Hauer <s.hauer@pengutronix.de>
To: javier Martin <javier.martin@vista-silicon.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	kernel@pengutronix.de, herbert@gondor.apana.org.au,
	davem@davemloft.net, tony@atomide.com, swarren@nvidia.com,
	shawn.guo@linaro.org, gcembed@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 0/3] crypto: sahara: Add support for SAHARA in i.MX27.
Date: Thu, 21 Feb 2013 16:18:19 +0100	[thread overview]
Message-ID: <20130221151819.GZ1906@pengutronix.de> (raw)
In-Reply-To: <CACKLOr1-EPK=DLz0SY+1E35qSMdtCsueuqdzV4VZdbkoM+TD6A@mail.gmail.com>

On Thu, Feb 21, 2013 at 03:18:36PM +0100, javier Martin wrote:
> Hi Arnd,
> 
> On 21 February 2013 13:59, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thursday 21 February 2013, Javier Martin wrote:
> >> This series of patches provide AES-ECB and AES-CBC support
> >> for the SAHARA2 cryptographic accelerator which is inside the i.MX27 SoC.
> >> It is expected that more algorithms will be supported in the future.
> >>
> >> For testing, a Visstrim M10 board has been used and the code related
> >> to this platform has been included too.
> >
> > As a new device driver, this needs to be supported on the DT based imx27
> > machines, while support for the individual board files seems unnecessary.
> >
> > How about converting the Visstrim M10 board file over to DT so you don't
> > have to add any more infrastructure for imx that we will just have to
> > remove again one day?
> 
> We know about the existence of DT and the constant migration process
> that is taking place towards it.
> 
> Moreover we are strongly interested in converting the Visstrim SM10
> platform to DT. Unfortunately, there are several issues that need to
> be solved so that Visstrim M10 can be fully converted to DT:
> - full SoC camera DT support
> - DT support for ov7670
> - pinctrl support for i.MX27

For the pinctrl stuff I suggest doing what we have done for the newer
i.MX SoCs before we had pinctrl: Match by board compatible string and
call into the board code for using the static pinctrl tables which are
already there. I would like to have propert pinctrl support for the
older i.MX, but probably the motivation for writing it is quite low for
the older SoCs.

We have a patch in the queue converting the clock lookups for i.MX27 to
dt which should be ready for posting soon.

Then the main road blockers should be out of the way to get rid of the
bulk of the board code.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |