From: Tony Lindgren <tony@atomide.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
Date: Fri, 8 Mar 2013 11:48:02 -0800 [thread overview]
Message-ID: <20130308194802.GG11806@atomide.com> (raw)
In-Reply-To: <513A2B20.30805@codeaurora.org>
* Stephen Boyd <sboyd@codeaurora.org> [130308 10:21]:
> On 03/08/13 10:07, Tony Lindgren wrote:
> >
> > Adding that produces the following:
> >
> > ...
> > OMAP clockevent source: GPTIMER1 at 32768 Hz
> > sched_clock: 32 bits at 32kHz, resolution 30517ns, wraps every 131071999ms
> > OMAP clocksource: 32k_counter at 32768 Hz
> > Console: colour dummy device 80x30
> > Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
> > Unable to handle kernel NULL pointer dereference at virtual address 0000001d
> > pgd = c0004000
> > [0000001d] *pgd=00000000
> > Internal error: Oops: 5 [#1] SMP ARM
> > Modules linked in:
> > CPU: 0 Not tainted (3.9.0-rc1-12182-g90ac757-dirty #42)
> > PC is at 0xe7d7f0a0
> > LR is at twd_handler+0x34/0x40
> > pc : [<e7d7f0a0>] lr : [<c001a650>] psr: 200001d3
> > sp : c0791ea0 ip : c0790000 fp : 00000004
> > r10: ed806780 r9 : c0805840 r8 : 00e0c000
> > r7 : c07919c0 r6 : ed801900 r5 : 0000001d r4 : 00000001
> > r3 : fa240600 r2 : fa24060c r1 : c0090d28 r0 : c0090d28
> > Flags: nzCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment kernel
> > Control: 10c53c7d Table: 8000404a DAC: 00000017
> > Process swapper/0 (pid: 0, stack limit = 0xc0790240)
> > Stack: (0xc0791ea0 to 0xc0792000)
> > 1ea0: c07997a8 c00ac80c 0000001d c078e248 c0790000 00000000 c07997a8 00000000
> > 1ec0: c0790000 c00a9e2c 0000001d c00152a8 fa24010c c0791f00 c0799904 fa240110
> > 1ee0: c082b260 c000868c 200001d3 c004901c 20000153 ffffffff c0791f34 c052db64
> > 1f00: 00000001 00000001 c079bc90 00000000 00000000 00000000 00000048 00000048
> > 1f20: c082b260 00000000 c0790000 00000004 00000000 c0791f48 60000153 c004901c
> > 1f40: 20000153 ffffffff 00000000 00000000 00000000 00000000 c082b260 00000048
> > 1f60: 00000000 00000000 00000000 60000153 c033e2ec c0791fac c08292bc c0829240
> > 1f80: c076f678 ffffffff 411fc092 c07988c0 00000000 c0529c88 c068460c c0791fac
> > 1fa0: c082924c c07515b4 c068460c c080bb1c 00000011 c0829258 bfffffff c0736884
> > 1fc0: ffffffff ffffffff c0736474 00000000 00000000 c076f678 00000000 10c53c7d
> > 1fe0: c0798934 c076fa7c c079d16c 8000406a 00000000 80008074 00000000 00000000
> > [<c001a650>] (twd_handler+0x34/0x40) from [<c00ac80c>] (handle_percpu_devid_irq+0xb8/0x128)
> > [<c00ac80c>] (handle_percpu_devid_irq+0xb8/0x128) from [<c00a9e2c>] (generic_handle_irq+0x30/0x3c)
> > [<c00a9e2c>] (generic_handle_irq+0x30/0x3c) from [<c00152a8>] (handle_IRQ+0x48/0xa8)
> > [<c00152a8>] (handle_IRQ+0x48/0xa8) from [<c000868c>] (gic_handle_irq+0x30/0x6c)
> > [<c000868c>] (gic_handle_irq+0x30/0x6c) from [<c052db64>] (__irq_svc+0x44/0x5c)
> > Exception stack(0xc0791f00 to 0xc0791f48)
> > 1f00: 00000001 00000001 c079bc90 00000000 00000000 00000000 00000048 00000048
> > 1f20: c082b260 00000000 c0790000 00000004 00000000 c0791f48 60000153 c004901c
> > 1f40: 20000153 ffffffff
> > [<c052db64>] (__irq_svc+0x44/0x5c) from [<c004901c>] (vprintk_emit+0x1f8/0x544)
> > [<c004901c>] (vprintk_emit+0x1f8/0x544) from [<c0529c88>] (printk+0x30/0x40)
> > [<c0529c88>] (printk+0x30/0x40) from [<c07515b4>] (lockdep_info+0x10/0xb4)
> > [<c07515b4>] (lockdep_info+0x10/0xb4) from [<c0736884>] (start_kernel+0x1dc/0x328)
> > [<c0736884>] (start_kernel+0x1dc/0x328) from [<80008074>] (0x80008074)
> > Code: 57555555 55755154 557d5554 55d55655 (54555575)
> >
>
> Ah. Two bugs :-(
>
> ----8<-----
>
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index 081de6f..4ea3e9d 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -227,7 +227,7 @@ static void __cpuinit twd_calibrate_rate(void)
>
> static irqreturn_t twd_handler(int irq, void *dev_id)
> {
> - struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
> + struct clock_event_device *evt = dev_id;
>
> if (twd_timer_ack()) {
> evt->event_handler(evt);
>
Yup thanks that fixes it, both fixes are needed. So for this patch + the
two fixes please feel free to add:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API
Date: Fri, 8 Mar 2013 11:48:02 -0800 [thread overview]
Message-ID: <20130308194802.GG11806@atomide.com> (raw)
In-Reply-To: <513A2B20.30805@codeaurora.org>
* Stephen Boyd <sboyd@codeaurora.org> [130308 10:21]:
> On 03/08/13 10:07, Tony Lindgren wrote:
> >
> > Adding that produces the following:
> >
> > ...
> > OMAP clockevent source: GPTIMER1 at 32768 Hz
> > sched_clock: 32 bits at 32kHz, resolution 30517ns, wraps every 131071999ms
> > OMAP clocksource: 32k_counter at 32768 Hz
> > Console: colour dummy device 80x30
> > Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
> > Unable to handle kernel NULL pointer dereference at virtual address 0000001d
> > pgd = c0004000
> > [0000001d] *pgd=00000000
> > Internal error: Oops: 5 [#1] SMP ARM
> > Modules linked in:
> > CPU: 0 Not tainted (3.9.0-rc1-12182-g90ac757-dirty #42)
> > PC is at 0xe7d7f0a0
> > LR is at twd_handler+0x34/0x40
> > pc : [<e7d7f0a0>] lr : [<c001a650>] psr: 200001d3
> > sp : c0791ea0 ip : c0790000 fp : 00000004
> > r10: ed806780 r9 : c0805840 r8 : 00e0c000
> > r7 : c07919c0 r6 : ed801900 r5 : 0000001d r4 : 00000001
> > r3 : fa240600 r2 : fa24060c r1 : c0090d28 r0 : c0090d28
> > Flags: nzCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment kernel
> > Control: 10c53c7d Table: 8000404a DAC: 00000017
> > Process swapper/0 (pid: 0, stack limit = 0xc0790240)
> > Stack: (0xc0791ea0 to 0xc0792000)
> > 1ea0: c07997a8 c00ac80c 0000001d c078e248 c0790000 00000000 c07997a8 00000000
> > 1ec0: c0790000 c00a9e2c 0000001d c00152a8 fa24010c c0791f00 c0799904 fa240110
> > 1ee0: c082b260 c000868c 200001d3 c004901c 20000153 ffffffff c0791f34 c052db64
> > 1f00: 00000001 00000001 c079bc90 00000000 00000000 00000000 00000048 00000048
> > 1f20: c082b260 00000000 c0790000 00000004 00000000 c0791f48 60000153 c004901c
> > 1f40: 20000153 ffffffff 00000000 00000000 00000000 00000000 c082b260 00000048
> > 1f60: 00000000 00000000 00000000 60000153 c033e2ec c0791fac c08292bc c0829240
> > 1f80: c076f678 ffffffff 411fc092 c07988c0 00000000 c0529c88 c068460c c0791fac
> > 1fa0: c082924c c07515b4 c068460c c080bb1c 00000011 c0829258 bfffffff c0736884
> > 1fc0: ffffffff ffffffff c0736474 00000000 00000000 c076f678 00000000 10c53c7d
> > 1fe0: c0798934 c076fa7c c079d16c 8000406a 00000000 80008074 00000000 00000000
> > [<c001a650>] (twd_handler+0x34/0x40) from [<c00ac80c>] (handle_percpu_devid_irq+0xb8/0x128)
> > [<c00ac80c>] (handle_percpu_devid_irq+0xb8/0x128) from [<c00a9e2c>] (generic_handle_irq+0x30/0x3c)
> > [<c00a9e2c>] (generic_handle_irq+0x30/0x3c) from [<c00152a8>] (handle_IRQ+0x48/0xa8)
> > [<c00152a8>] (handle_IRQ+0x48/0xa8) from [<c000868c>] (gic_handle_irq+0x30/0x6c)
> > [<c000868c>] (gic_handle_irq+0x30/0x6c) from [<c052db64>] (__irq_svc+0x44/0x5c)
> > Exception stack(0xc0791f00 to 0xc0791f48)
> > 1f00: 00000001 00000001 c079bc90 00000000 00000000 00000000 00000048 00000048
> > 1f20: c082b260 00000000 c0790000 00000004 00000000 c0791f48 60000153 c004901c
> > 1f40: 20000153 ffffffff
> > [<c052db64>] (__irq_svc+0x44/0x5c) from [<c004901c>] (vprintk_emit+0x1f8/0x544)
> > [<c004901c>] (vprintk_emit+0x1f8/0x544) from [<c0529c88>] (printk+0x30/0x40)
> > [<c0529c88>] (printk+0x30/0x40) from [<c07515b4>] (lockdep_info+0x10/0xb4)
> > [<c07515b4>] (lockdep_info+0x10/0xb4) from [<c0736884>] (start_kernel+0x1dc/0x328)
> > [<c0736884>] (start_kernel+0x1dc/0x328) from [<80008074>] (0x80008074)
> > Code: 57555555 55755154 557d5554 55d55655 (54555575)
> >
>
> Ah. Two bugs :-(
>
> ----8<-----
>
> diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
> index 081de6f..4ea3e9d 100644
> --- a/arch/arm/kernel/smp_twd.c
> +++ b/arch/arm/kernel/smp_twd.c
> @@ -227,7 +227,7 @@ static void __cpuinit twd_calibrate_rate(void)
>
> static irqreturn_t twd_handler(int irq, void *dev_id)
> {
> - struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
> + struct clock_event_device *evt = dev_id;
>
> if (twd_timer_ack()) {
> evt->event_handler(evt);
>
Yup thanks that fixes it, both fixes are needed. So for this patch + the
two fixes please feel free to add:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-03-08 19:48 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 0:03 [PATCHv2 0/10] Remove ARM local timer API Stephen Boyd
2013-03-07 0:03 ` Stephen Boyd
2013-03-07 0:03 ` [PATCH 01/10] clocksource: add generic dummy timer driver Stephen Boyd
2013-03-07 0:03 ` Stephen Boyd
2013-03-07 14:00 ` Thomas Gleixner
2013-03-07 14:00 ` Thomas Gleixner
2013-03-07 21:41 ` Stephen Boyd
2013-03-07 21:41 ` Stephen Boyd
2013-03-07 0:03 ` [PATCH 02/10] ARM: smp: Remove duplicate dummy timer implementation Stephen Boyd
2013-03-07 0:03 ` Stephen Boyd
2013-03-07 0:03 ` Stephen Boyd
2013-03-07 0:03 ` [PATCH 03/10] ARM: smp_twd: Divorce smp_twd from local timer API Stephen Boyd
2013-03-07 0:03 ` Stephen Boyd
2013-03-08 0:40 ` Tony Lindgren
2013-03-08 0:40 ` Tony Lindgren
2013-03-08 1:14 ` Stephen Boyd
2013-03-08 1:14 ` Stephen Boyd
2013-03-08 18:07 ` Tony Lindgren
2013-03-08 18:07 ` Tony Lindgren
2013-03-08 18:17 ` Stephen Boyd
2013-03-08 18:17 ` Stephen Boyd
2013-03-08 19:48 ` Tony Lindgren [this message]
2013-03-08 19:48 ` Tony Lindgren
2013-03-08 19:50 ` Stephen Boyd
2013-03-08 19:50 ` Stephen Boyd
2013-03-08 20:08 ` Tony Lindgren
2013-03-08 20:08 ` Tony Lindgren
2013-03-08 20:17 ` Stephen Boyd
2013-03-08 20:17 ` Stephen Boyd
2013-03-08 20:29 ` Tony Lindgren
2013-03-08 20:29 ` Tony Lindgren
2013-03-09 1:06 ` Stephen Boyd
2013-03-09 1:06 ` Stephen Boyd
2013-03-11 17:28 ` Tony Lindgren
2013-03-11 17:28 ` Tony Lindgren
2013-03-11 22:17 ` Stephen Boyd
2013-03-11 22:17 ` Stephen Boyd
2013-03-11 22:50 ` Tony Lindgren
2013-03-11 22:50 ` Tony Lindgren
2013-03-12 1:20 ` Stephen Boyd
2013-03-12 1:20 ` Stephen Boyd
2013-03-12 17:06 ` Tony Lindgren
2013-03-12 17:06 ` Tony Lindgren
2013-03-07 0:04 ` [PATCH 04/10] ARM: OMAP2+: Divorce " Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-08 19:50 ` Tony Lindgren
2013-03-08 19:50 ` Tony Lindgren
2013-03-11 15:29 ` Santosh Shilimkar
2013-03-11 15:29 ` Santosh Shilimkar
2013-03-11 15:29 ` Santosh Shilimkar
2013-03-07 0:04 ` [PATCH 05/10] ARM: EXYNOS4: Divorce mct " Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` [PATCH 06/10] ARM: PRIMA2: Divorce timer-marco " Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` [PATCH 07/10] ARM: msm: Divorce msm_timer " Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` [PATCH 08/10] clocksource: time-armada-370-xp: Fix sparse warning Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` [PATCH 09/10] clocksource: time-armada-370-xp: Divorce from local timer API Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-07 0:04 ` [PATCH 10/10] ARM: smp: Remove " Stephen Boyd
2013-03-07 0:04 ` Stephen Boyd
2013-03-08 19:55 ` Tony Lindgren
2013-03-08 19:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308194802.GG11806@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.