All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Timur Tabi <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 01/10] imx-ssi: Fix AC97 rates
Date: Mon, 11 Mar 2013 20:51:08 +0100	[thread overview]
Message-ID: <20130311195108.GC18350@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5A8F81PzCjKHrkZ_AtGMr341d6OmYHMQvdzgunmGFDVsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Fabio,

On Sun, Mar 10, 2013 at 03:47:10PM -0300, Fabio Estevam wrote:
> Hi Markus,
> 
> On Sun, Mar 10, 2013 at 3:33 PM, Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> > From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >
> > This device supports multiple rates as described in later AC97
> > standards. This patch allows playback of different sample frequencies
> > without conversion.
> >
> > Signed-off-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Signed-off-by: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> >  sound/soc/fsl/imx-ssi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Currently we have the following ssi drivers for imx:
> 
> sound/soc/fsl/imx-ssi.c: for i.mx SoCs running on non-dt platform
> sound/soc/fsl/fsl_ssi.c: for PowerPC and i.mx SoCs running on dt platforms
> 
> I see that in this series you convert sound/soc/fsl/imx-ssi.c into dt.
> 
> Shouldn't we use sound/soc/fsl/fsl_ssi.c instead and maybe even get
> rid of sound/soc/fsl/imx-ssi.c when all imx become converted to dt?
> 

At the moment fsl-ssi and imx-ssi don't seem to have very much in
common. However I could try to merge the imx-ssi driver code into
fsl_ssi and make it handle imx27-ssi differently.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] imx-ssi: Fix AC97 rates
Date: Mon, 11 Mar 2013 20:51:08 +0100	[thread overview]
Message-ID: <20130311195108.GC18350@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5A8F81PzCjKHrkZ_AtGMr341d6OmYHMQvdzgunmGFDVsw@mail.gmail.com>

Hi Fabio,

On Sun, Mar 10, 2013 at 03:47:10PM -0300, Fabio Estevam wrote:
> Hi Markus,
> 
> On Sun, Mar 10, 2013 at 3:33 PM, Markus Pargmann <mpa@pengutronix.de> wrote:
> > From: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > This device supports multiple rates as described in later AC97
> > standards. This patch allows playback of different sample frequencies
> > without conversion.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> > ---
> >  sound/soc/fsl/imx-ssi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Currently we have the following ssi drivers for imx:
> 
> sound/soc/fsl/imx-ssi.c: for i.mx SoCs running on non-dt platform
> sound/soc/fsl/fsl_ssi.c: for PowerPC and i.mx SoCs running on dt platforms
> 
> I see that in this series you convert sound/soc/fsl/imx-ssi.c into dt.
> 
> Shouldn't we use sound/soc/fsl/fsl_ssi.c instead and maybe even get
> rid of sound/soc/fsl/imx-ssi.c when all imx become converted to dt?
> 

At the moment fsl-ssi and imx-ssi don't seem to have very much in
common. However I could try to merge the imx-ssi driver code into
fsl_ssi and make it handle imx27-ssi differently.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2013-03-11 19:51 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10 18:33 [PATCH 00/10] ASoC: imx sound: Add DT support Markus Pargmann
2013-03-10 18:33 ` Markus Pargmann
     [not found] ` <1362940391-8338-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-10 18:33   ` [PATCH 01/10] imx-ssi: Fix AC97 rates Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
     [not found]     ` <1362940391-8338-2-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-10 18:47       ` Fabio Estevam
2013-03-10 18:47         ` Fabio Estevam
     [not found]         ` <CAOMZO5A8F81PzCjKHrkZ_AtGMr341d6OmYHMQvdzgunmGFDVsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-11 19:51           ` Markus Pargmann [this message]
2013-03-11 19:51             ` Markus Pargmann
2013-03-13 22:55             ` Timur Tabi
2013-03-13 22:55               ` Timur Tabi
     [not found]               ` <CAOZdJXXm=jJv3zyD4j11t3BgNGyKz6V9jzShQLTk-BTiwDjvMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-14 12:44                 ` Markus Pargmann
2013-03-14 12:44                   ` Markus Pargmann
2013-03-12 18:52       ` Mark Brown
2013-03-12 18:52         ` Mark Brown
2013-03-10 18:33   ` [PATCH 02/10] imx-ssi: Fix occasional AC97 reset failure Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
2013-03-12 18:53     ` Mark Brown
2013-03-12 18:53       ` Mark Brown
2013-03-10 18:33   ` [PATCH 03/10] mx-ssi: flush fifos Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
     [not found]     ` <1362940391-8338-4-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12 18:54       ` Mark Brown
2013-03-12 18:54         ` Mark Brown
2013-03-10 18:33   ` [PATCH 04/10] ASoC: Kconfig: imx-ssi needs imx-fiq and imx-dma Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
     [not found]     ` <1362940391-8338-5-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12 18:55       ` Mark Brown
2013-03-12 18:55         ` Mark Brown
     [not found]         ` <20130312185510.GV19942-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-14 12:42           ` Markus Pargmann
2013-03-14 12:42             ` Markus Pargmann
2013-03-10 18:33   ` [PATCH 05/10] ASoC: pcm030 audio fabric: remove __init from probe Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
     [not found]     ` <1362940391-8338-6-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12 18:55       ` Mark Brown
2013-03-12 18:55         ` Mark Brown
2013-03-10 18:33   ` [PATCH 06/10] ARM: soc-audio phycore-ac97: fix driver init order Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
2013-03-11 11:10     ` Mark Brown
2013-03-11 11:10       ` Mark Brown
     [not found]       ` <20130311111011.GA10617-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-11 19:56         ` Markus Pargmann
2013-03-11 19:56           ` Markus Pargmann
2013-03-10 18:33   ` [PATCH 07/10] ASoC: phycore-ac97: Add DT support Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
     [not found]     ` <1362940391-8338-8-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-12 18:59       ` Mark Brown
2013-03-12 18:59         ` Mark Brown
     [not found]         ` <20130312185921.GX19942-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-14 12:55           ` Markus Pargmann
2013-03-14 12:55             ` Markus Pargmann
2013-03-10 18:33   ` [PATCH 08/10] ASoC: dmaengine_pcm: Add open function for DT DMA request Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
2013-03-12 19:02     ` Mark Brown
2013-03-12 19:02       ` Mark Brown
     [not found]       ` <20130312190206.GY19942-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-13  2:18         ` Shawn Guo
2013-03-13  2:18           ` Shawn Guo
2013-03-13 10:49           ` Mark Brown
2013-03-13 10:49             ` Mark Brown
     [not found]             ` <20130313104945.GI25610-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-14  6:04               ` Shawn Guo
2013-03-14  6:04                 ` Shawn Guo
2013-03-15  1:12                 ` Mark Brown
2013-03-15  1:12                   ` Mark Brown
     [not found]           ` <20130313021712.GD27461-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2013-03-14 13:08             ` Markus Pargmann
2013-03-14 13:08               ` Markus Pargmann
2013-03-15  3:42               ` Shawn Guo
2013-03-15  3:42                 ` Shawn Guo
2013-03-15  9:07                 ` Markus Pargmann
2013-03-15  9:07                   ` Markus Pargmann
2013-03-10 18:33   ` [PATCH 09/10] ASoC: imx-pcm-dma: Add support for DMA init by device node Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
2013-03-10 18:33   ` [PATCH 10/10] ASoC: imx-ssi: Add imx27 and pca100 DT support Markus Pargmann
2013-03-10 18:33     ` Markus Pargmann
2013-03-10 18:55     ` Alexander Shiyan
2013-03-10 18:55       ` Alexander Shiyan
2013-03-13 22:53 ` [PATCH 00/10] ASoC: imx sound: Add " Timur Tabi
2013-03-13 22:53   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130311195108.GC18350@pengutronix.de \
    --to=mpa-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.