Re: [PATCH v2] ADP1653 board code for Nokia RX-51

From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ADP1653 board code for Nokia RX-51
Date: Sun, 24 Mar 2013 15:19:49 +0100	[thread overview]
Message-ID: <201303241519.49243@pali> (raw)
In-Reply-To: <20130307221827.GE31984@valkosipuli.retiisi.org.uk>

[-- Attachment #1: Type: Text/Plain, Size: 2384 bytes --]

On Thursday 07 March 2013 23:18:27 Sakari Ailus wrote:
> Hi guys,
> 
> On Wed, Mar 06, 2013 at 10:44:41PM +0100, Sebastian Reichel 
wrote:
> > On Wed, Mar 06, 2013 at 09:20:16PM +0100, Pali Rohár wrote:
> > > On Wednesday 06 March 2013 21:12:06 Pali Rohár wrote:
> > > > On Sunday 17 February 2013 20:03:03 Aaro Koskinen wrote:
> > > > > On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár 
wrote:
> > > > > > +/*
> > > > > > + * arch/arm/mach-omap2/board-rx51-camera.c
> > > > > > + *
> > > > > > + * Copyright (C) 2008 Nokia Corporation
> > > > > > + *
> > > > > > + * Contact: Sakari Ailus <sakari.ailus@nokia.com>
> > > > > > + *          Tuukka Toivonen
> > > > > > <tuukka.o.toivonen@nokia.com>
> > > > > 
> > > > > You should put these people to CC... Just to see if
> > > > > the addresses are still valid (which I doubt).
> > > > 
> > > > Ok, trying :-)
> > > 
> > > I got "Delivery Status Notification (Failure)" for both
> > > addresses.
> 
> This is expected.
> 
> > Sakari Ailus hosts some code on github [0], which has the
> > following email address:
> > sakari.ailus+gitorious@retiisi.org.uk
> > 
> > I added it to this mail's CC.
> > 
> > [0] https://gitorious.org/~sailus
> 
> Nice to hear people are interested in this. ;-)
> 
> The primary reason I haven't tried submitting this to mainline
> is that ARM board code has a bad reputation these days. The
> N900 does not have yet support for device tree (AFAIK), which
> also would require a few bits and pieces on the flash driver
> to work.
> 
> Also the sensor and lens drivers would need at least some work
> before being ready for submission to mainline for camera to
> be usable. Unfortunately I haven't had recently time to work
> on this. N9(50) support has higher priority for myself. That,
> too, is pending the DT support for the device.
> 
> There's indeed more up-to-date code in my repository. Even if
> it's not too close to mainline anymore it should be a better
> starting point than the old kernel from MeeGo.
> 
> <URL:https://gitorious.org/omap3camera/pages/Home>

Hi,

this board code is same in your git repository and on meego obs.

Patch only adding support for adp1653 driver which is already in 
upstream kernel.

Are there any other problems with this patch to go for upstream?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]