From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Pavel Machek <pavel@ucw.cz>, Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ADP1653 board code for Nokia RX-51
Date: Fri, 20 Sep 2013 00:30:36 +0200 [thread overview]
Message-ID: <201309200030.36606@pali> (raw)
In-Reply-To: <20130918174211.GU9994@atomide.com>
[-- Attachment #1: Type: Text/Plain, Size: 1858 bytes --]
On Wednesday 18 September 2013 19:42:12 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [130918 09:08]:
> > On Wednesday 18 September 2013 15:16:44 Pavel Machek wrote:
> > > On Sun 2013-09-08 02:02:52, Aaro Koskinen wrote:
> > > > Hi,
> > > >
> > > > On Fri, Sep 06, 2013 at 10:34:05PM +0200, Pali Rohár
wrote:
> > > > > > --- /dev/null
> > > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c
> > > >
> > > > [...]
> > > >
> > > > > Ping, can you review this patch v2?
> > > >
> > > > I don't think Tony will accept any new board stuff for
> > > > RX-51/N900. See for example:
> > > > http://marc.info/?l=linux-kernel&m=137629626213187&w=2
> > > >
> > > > There should be initial Nokia N900 DTS file in 3.12-rc1,
> > > > and we should continue converting this board fully to
> > > > DT.
> > >
> > > That's not reasonable. N900 is pretty far away from
> > > working with device tree. Yes, I was able to get some
> > > bits merged, but that should not be excuse to halt other
> > > N900 development.
> > >
> > > Pavel
> >
> > Right. So Tony, will you accept future patches for board
> > files?
>
> Only fixes to board-*.c files please unless there's a _really_
> good reason to make things more complex with the platform
> data. Let's not make the DT conversion any more complex than
> it already is.
>
> Getting things working with DT for the devices is pretty
> trivial in most cases. And we can also still initialize the
> legacy devices using platform data the same way as earlier.
>
> Regards,
>
> Tony
So, what to this with this patch v2 (it was sent 06.03.2013)?
It adding board support for ADP1653 flash torch which is part of
rx51 camera code. Driver itself is already in kernel tree.
Can you comment/review this patch?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-09-19 22:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 15:16 [PATCH] ADP1653 board code for Nokia RX-51 Pali Rohár
2013-02-17 19:03 ` Aaro Koskinen
2013-02-17 19:03 ` Aaro Koskinen
2013-03-06 20:12 ` [PATCH v2] " Pali Rohár
2013-03-06 20:20 ` Pali Rohár
2013-03-06 21:44 ` Sebastian Reichel
2013-03-07 22:18 ` Sakari Ailus
2013-03-24 14:19 ` Pali Rohár
2013-03-24 21:46 ` Sakari Ailus
2013-03-24 21:46 ` Sakari Ailus
2013-03-25 23:07 ` Laurent Pinchart
2013-04-03 22:22 ` Sakari Ailus
2013-04-04 13:11 ` Laurent Pinchart
2013-09-06 20:35 ` [PATCH v2] Camera drivers " Pali Rohár
2013-09-09 21:40 ` Sakari Ailus
2013-09-06 20:34 ` [PATCH v2] ADP1653 board code " Pali Rohár
2013-09-07 23:02 ` Aaro Koskinen
2013-09-17 23:50 ` Tony Lindgren
2013-09-18 14:12 ` Javier Martinez Canillas
2013-09-18 14:12 ` Javier Martinez Canillas
2013-09-18 17:45 ` Tony Lindgren
2013-09-18 13:16 ` Pavel Machek
2013-09-18 16:00 ` Pali Rohár
2013-09-18 17:42 ` Tony Lindgren
2013-09-19 22:30 ` Pali Rohár [this message]
2013-09-20 16:33 ` Tony Lindgren
2013-09-21 12:37 ` Pavel Machek
2013-09-23 17:21 ` Tony Lindgren
2013-09-23 23:15 ` Pavel Machek
2013-03-30 18:24 ` [PATCH] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309200030.36606@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.