From: Pavel Machek <pavel@ucw.cz> To: "Pali Rohár" <pali.rohar@gmail.com> Cc: Tony Lindgren <tony@atomide.com>, Russell King <linux@arm.linux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Ivaylo Dimitrov <freemangordon@abv.bg> Subject: Re: [PATCH] arm: omap: RX-51: ARM errata 430973 workaround Date: Sat, 30 Mar 2013 19:36:54 +0100 [thread overview] Message-ID: <20130330183654.GH28947@amd.pavel.ucw.cz> (raw) In-Reply-To: <1362044548-5398-1-git-send-email-pali.rohar@gmail.com> Hi! > +u32 rx51_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2, > + u32 arg3, u32 arg4) > +{ > + u32 ret; > + u32 param[5]; > + > + param[0] = nargs+1; > + param[1] = arg1; > + param[2] = arg2; > + param[3] = arg3; > + param[4] = arg4; > + > + /* > + * Secure API needs physical address > + * pointer for the parameters > + */ > + flush_cache_all(); > + outer_clean_range(__pa(param), __pa(param + 5)); > + ret = rx51_ppa_smc(idx, flag, __pa(param)); > + > + return ret; > +} You can do without ret variable... Also more detailed changelog would be nice... like what exact problem this works around. <google> So... some CPU errata where code sharing virtual addresses could be executed improperly? > @@ -103,6 +104,12 @@ static void __init rx51_init(void) > rx51_peripherals_init(); > rx51_camera_init(); > > +#ifdef CONFIG_ARM_ERRATA_430973 > + printk(KERN_INFO "Enabling ARM errata 430973 workaround.\n"); > + /* set IBE to 1 */ > + rx51_secure_update_aux_cr(1 << 6, 0); > +#endif > + Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm: omap: RX-51: ARM errata 430973 workaround Date: Sat, 30 Mar 2013 19:36:54 +0100 [thread overview] Message-ID: <20130330183654.GH28947@amd.pavel.ucw.cz> (raw) In-Reply-To: <1362044548-5398-1-git-send-email-pali.rohar@gmail.com> Hi! > +u32 rx51_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2, > + u32 arg3, u32 arg4) > +{ > + u32 ret; > + u32 param[5]; > + > + param[0] = nargs+1; > + param[1] = arg1; > + param[2] = arg2; > + param[3] = arg3; > + param[4] = arg4; > + > + /* > + * Secure API needs physical address > + * pointer for the parameters > + */ > + flush_cache_all(); > + outer_clean_range(__pa(param), __pa(param + 5)); > + ret = rx51_ppa_smc(idx, flag, __pa(param)); > + > + return ret; > +} You can do without ret variable... Also more detailed changelog would be nice... like what exact problem this works around. <google> So... some CPU errata where code sharing virtual addresses could be executed improperly? > @@ -103,6 +104,12 @@ static void __init rx51_init(void) > rx51_peripherals_init(); > rx51_camera_init(); > > +#ifdef CONFIG_ARM_ERRATA_430973 > + printk(KERN_INFO "Enabling ARM errata 430973 workaround.\n"); > + /* set IBE to 1 */ > + rx51_secure_update_aux_cr(1 << 6, 0); > +#endif > + Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-03-30 18:36 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-28 9:42 [PATCH] arm: omap: RX-51: ARM errata 430973 workaround Pali Rohár 2013-02-28 9:42 ` Pali Rohár 2013-02-28 9:42 ` Pali Rohár 2013-02-28 14:40 ` Nishanth Menon 2013-02-28 14:40 ` Nishanth Menon 2013-02-28 14:40 ` Nishanth Menon 2013-03-01 9:43 ` Peter De Schrijver 2013-03-01 9:43 ` Peter De Schrijver 2013-03-01 9:43 ` Peter De Schrijver 2013-03-30 18:36 ` Pavel Machek [this message] 2013-03-30 18:36 ` Pavel Machek 2013-07-10 12:59 ` [PATCH v2 0/2] " Pali Rohár 2013-07-10 12:59 ` Pali Rohár 2013-07-10 12:59 ` [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Pali Rohár 2013-07-10 12:59 ` Pali Rohár 2013-07-10 17:45 ` Dave Martin 2013-07-10 17:45 ` Dave Martin 2013-07-10 17:45 ` Dave Martin 2013-07-10 12:59 ` [PATCH v2 2/2] RX-51: ARM errata 430973 workaround Pali Rohár 2013-07-10 12:59 ` Pali Rohár 2013-09-17 23:24 ` Tony Lindgren 2013-09-17 23:24 ` Tony Lindgren 2013-09-18 8:33 ` Pali Rohár 2013-09-18 8:33 ` Pali Rohár 2013-09-18 17:18 ` Tony Lindgren 2013-09-18 17:18 ` Tony Lindgren 2013-09-18 18:13 ` Pali Rohár 2013-09-18 18:13 ` Pali Rohár 2013-09-18 18:21 ` Tony Lindgren 2013-09-18 18:21 ` Tony Lindgren 2013-09-24 0:15 ` Pavel Machek 2013-09-24 0:15 ` Pavel Machek 2013-09-24 16:51 ` Tony Lindgren 2013-09-24 16:51 ` Tony Lindgren 2013-09-18 19:22 ` [PATCH v3 " Pali Rohár 2013-09-18 19:22 ` Pali Rohár 2013-09-18 19:27 ` Tony Lindgren 2013-09-18 19:27 ` Tony Lindgren 2013-09-18 19:43 ` [PATCH v4 " Pali Rohár 2013-09-18 19:43 ` Pali Rohár 2013-03-01 7:47 [PATCH] arm: omap: " Ивайло Димитров 2013-03-01 14:38 ` Nishanth Menon 2013-03-01 14:38 ` Nishanth Menon 2013-03-04 18:58 ` Tony Lindgren 2013-03-04 18:58 ` Tony Lindgren 2013-03-06 14:09 ` Pali Rohár 2013-03-06 14:09 ` Pali Rohár 2013-03-06 17:51 ` Tony Lindgren 2013-03-06 17:51 ` Tony Lindgren 2013-03-06 19:13 ` Pali Rohár 2013-03-06 19:13 ` Pali Rohár 2013-03-24 14:26 ` Pali Rohár 2013-03-24 14:26 ` Pali Rohár 2013-03-27 20:56 ` Tony Lindgren 2013-03-27 20:56 ` Tony Lindgren 2013-03-27 20:56 ` Tony Lindgren 2013-03-27 21:05 ` Pali Rohár 2013-03-27 21:05 ` Pali Rohár 2013-03-27 21:12 ` Tony Lindgren 2013-03-27 21:12 ` Tony Lindgren 2013-03-28 9:50 ` Russell King - ARM Linux 2013-03-28 9:50 ` Russell King - ARM Linux 2013-03-28 10:07 ` Santosh Shilimkar 2013-03-28 10:07 ` Santosh Shilimkar 2013-03-28 15:53 ` Tony Lindgren 2013-03-28 15:53 ` Tony Lindgren 2013-03-01 10:09 Ивайло Димитров 2013-03-01 23:51 ` Aaro Koskinen 2013-03-01 23:51 ` Aaro Koskinen 2013-03-01 23:51 ` Aaro Koskinen 2013-03-06 9:32 Ивайло Димитров 2013-03-28 5:30 Ивайло Димитров 2013-03-28 15:58 ` Tony Lindgren 2013-03-28 15:58 ` Tony Lindgren 2013-03-28 15:58 ` Tony Lindgren 2013-03-30 22:31 Ивайло Димитров 2013-03-31 7:37 ` Pavel Machek 2013-03-31 7:37 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130330183654.GH28947@amd.pavel.ucw.cz \ --to=pavel@ucw.cz \ --cc=freemangordon@abv.bg \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=pali.rohar@gmail.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.